All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [GIT PULL] A Single RISC-V Update for 4.19-rc6
Date: Tue, 25 Sep 2018 10:32:12 -0700	[thread overview]
Message-ID: <20180925173212.GA21414@infradead.org> (raw)
In-Reply-To: <mhng-3ad7c756-ed90-4cfd-b178-cd09e021a758@palmer-si-x1c4>

On Tue, Sep 25, 2018 at 09:26:51AM -0700, Palmer Dabbelt wrote:
> On Tue, 25 Sep 2018 09:15:38 PDT (-0700), Christoph Hellwig wrote:
> > I think this fix isn't quite right actually - we don't need asm-generic
> > asm-prototypes.h, as said in the review of this patch.
> > 
> > Also on it's own it isn't going to help with doing a modversions enabled
> > build, as the return_to_handler export needs to be dropped.
> 
> Ah, sorry -- my understanding was that while this wasn't the cleanest fix,
> it would at least enable the Debian people to work around their issue.  If
> that's not the case then I'll just drop this PR, but I'd really like to
> enable the Debian people to ship kernel images and that's a big step.
> 
> Did I misunderstand what's going on here?  I tried to build it according to
> the patch's instructions and don't remember seeing the warnings, but I might
> just be wrong here...

You'll only see the warning when you actually install the modules
if I remember correctly.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Palmer Dabbelt <palmer@sifive.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-riscv@lists.infradead.org
Subject: Re: [GIT PULL] A Single RISC-V Update for 4.19-rc6
Date: Tue, 25 Sep 2018 10:32:12 -0700	[thread overview]
Message-ID: <20180925173212.GA21414@infradead.org> (raw)
Message-ID: <20180925173212.xWAgHcnaQ6GspVPCwnCMmckth_HTpZ66Gt9RwD6-oP8@z> (raw)
In-Reply-To: <mhng-3ad7c756-ed90-4cfd-b178-cd09e021a758@palmer-si-x1c4>

On Tue, Sep 25, 2018 at 09:26:51AM -0700, Palmer Dabbelt wrote:
> On Tue, 25 Sep 2018 09:15:38 PDT (-0700), Christoph Hellwig wrote:
> > I think this fix isn't quite right actually - we don't need asm-generic
> > asm-prototypes.h, as said in the review of this patch.
> > 
> > Also on it's own it isn't going to help with doing a modversions enabled
> > build, as the return_to_handler export needs to be dropped.
> 
> Ah, sorry -- my understanding was that while this wasn't the cleanest fix,
> it would at least enable the Debian people to work around their issue.  If
> that's not the case then I'll just drop this PR, but I'd really like to
> enable the Debian people to ship kernel images and that's a big step.
> 
> Did I misunderstand what's going on here?  I tried to build it according to
> the patch's instructions and don't remember seeing the warnings, but I might
> just be wrong here...

You'll only see the warning when you actually install the modules
if I remember correctly.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2018-09-25 17:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 20:45 [GIT PULL] A Single RISC-V Update for 4.19-rc6 Palmer Dabbelt
2018-09-24 20:45 ` Palmer Dabbelt
2018-09-25 16:15 ` Christoph Hellwig
2018-09-25 16:15   ` Christoph Hellwig
2018-09-25 16:26   ` Palmer Dabbelt
2018-09-25 16:26     ` Palmer Dabbelt
2018-09-25 17:32     ` Christoph Hellwig [this message]
2018-09-25 17:32       ` Christoph Hellwig
2018-09-25 17:57       ` Palmer Dabbelt
2018-09-25 17:57         ` Palmer Dabbelt
2018-09-27 18:51 Palmer Dabbelt
2018-09-27 18:51 ` Palmer Dabbelt
2018-09-27 18:51 ` Palmer Dabbelt
2018-09-28 16:54 ` Greg KH
2018-09-28 16:54   ` Greg KH
2018-09-28 16:54   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925173212.GA21414@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.