All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: sehro rautenkranz <sehro@sehro.org>
Cc: Lidza Louina <lidza.louina@gmail.com>,
	Mark Hounschell <markh@compro.net>,
	driverdev-devel@linuxdriverproject.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
Date: Tue, 25 Sep 2018 20:46:23 +0200	[thread overview]
Message-ID: <20180925184623.GA16455@kroah.com> (raw)
In-Reply-To: <20180925162225.19227-1-sehro@sehro.org>

On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote:
> Replace Kconfig help header and text to match other modules. Issue found
> my checkpatch.
> 
> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
> reported by rdunlap@infradead.org. (try 2)

The "try 2" needs go to below the --- line.

Also, you need to properly version your patches so that I have a clue
as to which is the "latest" one.

> Signed-off-by: sehro rautenkranz <sehro@sehro.org>

You forgot Randy's Reported-by.

Also, properly Capitalize your name.

v3?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: sehro rautenkranz <sehro@sehro.org>
Cc: Mark Hounschell <markh@compro.net>,
	Lidza Louina <lidza.louina@gmail.com>,
	driverdev-devel@linuxdriverproject.org,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: dgnc: Fix Kconfig help header and text
Date: Tue, 25 Sep 2018 20:46:23 +0200	[thread overview]
Message-ID: <20180925184623.GA16455@kroah.com> (raw)
In-Reply-To: <20180925162225.19227-1-sehro@sehro.org>

On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote:
> Replace Kconfig help header and text to match other modules. Issue found
> my checkpatch.
> 
> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
> reported by rdunlap@infradead.org. (try 2)

The "try 2" needs go to below the --- line.

Also, you need to properly version your patches so that I have a clue
as to which is the "latest" one.

> Signed-off-by: sehro rautenkranz <sehro@sehro.org>

You forgot Randy's Reported-by.

Also, properly Capitalize your name.

v3?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-09-25 18:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25  6:20 [PATCH] staging: dgnc: Fix Kconfig help header and text sehro rautenkranz
2018-09-25  6:20 ` sehro rautenkranz
2018-09-25 15:34 ` Randy Dunlap
2018-09-25 15:34   ` Randy Dunlap
2018-09-25 15:53   ` sehro rautenkranz
2018-09-25 15:53     ` sehro rautenkranz
2018-09-25 16:00     ` Randy Dunlap
2018-09-25 16:00       ` Randy Dunlap
2018-09-25 16:22       ` sehro rautenkranz
2018-09-25 16:22         ` sehro rautenkranz
2018-09-25 18:46         ` Greg Kroah-Hartman [this message]
2018-09-25 18:46           ` Greg Kroah-Hartman
2018-09-25 19:49           ` Randy Dunlap
2018-09-25 19:49             ` Randy Dunlap
2018-09-25 23:41             ` [PATCH v3] " Sehro Rautenkranz
2018-09-25 23:41               ` Sehro Rautenkranz
2018-09-28 19:59               ` Lidza Louina
2018-10-01 12:09                 ` Mark Hounschell
2018-10-01 16:49                   ` Lidza Louina
2018-10-01 17:38                     ` Mark Hounschell
2018-10-02 22:09                     ` Greg Kroah-Hartman
2018-10-02 22:09                       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180925184623.GA16455@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=lidza.louina@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=sehro@sehro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.