* [PATCH i-g-t] lib: Unexport gem_gtt_type()
@ 2018-09-26 13:13 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-09-26 13:13 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Nobody uses the function directly, instead using the various helpers to
determine if ppgtt is present.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
lib/ioctl_wrappers.c | 5 ++---
lib/ioctl_wrappers.h | 1 -
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index d992e015b..0929c43fe 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -954,12 +954,11 @@ bool gem_bo_busy(int fd, uint32_t handle)
* Feature test macro to check what type of gtt is being used by the kernel:
* 0 - global gtt
* 1 - aliasing ppgtt
- * 2 - full ppgtt, limited to 32bit address space
- * 3 - full ppgtt, 64bit address space
+ * 2 - full ppgtt
*
* Returns: Type of gtt being used.
*/
-int gem_gtt_type(int fd)
+static int gem_gtt_type(int fd)
{
struct drm_i915_getparam gp;
int val = 0;
diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
index 872e30563..c4e1956c5 100644
--- a/lib/ioctl_wrappers.h
+++ b/lib/ioctl_wrappers.h
@@ -147,7 +147,6 @@ bool gem_has_bsd(int fd);
bool gem_has_blt(int fd);
bool gem_has_vebox(int fd);
bool gem_has_bsd2(int fd);
-int gem_gtt_type(int fd);
bool gem_uses_ppgtt(int fd);
bool gem_uses_full_ppgtt(int fd);
int gem_gpu_reset_type(int fd);
--
2.19.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH i-g-t] lib: Unexport gem_gtt_type()
@ 2018-09-26 13:13 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-09-26 13:13 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Nobody uses the function directly, instead using the various helpers to
determine if ppgtt is present.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
lib/ioctl_wrappers.c | 5 ++---
lib/ioctl_wrappers.h | 1 -
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index d992e015b..0929c43fe 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -954,12 +954,11 @@ bool gem_bo_busy(int fd, uint32_t handle)
* Feature test macro to check what type of gtt is being used by the kernel:
* 0 - global gtt
* 1 - aliasing ppgtt
- * 2 - full ppgtt, limited to 32bit address space
- * 3 - full ppgtt, 64bit address space
+ * 2 - full ppgtt
*
* Returns: Type of gtt being used.
*/
-int gem_gtt_type(int fd)
+static int gem_gtt_type(int fd)
{
struct drm_i915_getparam gp;
int val = 0;
diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
index 872e30563..c4e1956c5 100644
--- a/lib/ioctl_wrappers.h
+++ b/lib/ioctl_wrappers.h
@@ -147,7 +147,6 @@ bool gem_has_bsd(int fd);
bool gem_has_blt(int fd);
bool gem_has_vebox(int fd);
bool gem_has_bsd2(int fd);
-int gem_gtt_type(int fd);
bool gem_uses_ppgtt(int fd);
bool gem_uses_full_ppgtt(int fd);
int gem_gpu_reset_type(int fd);
--
2.19.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] lib: Unexport gem_gtt_type()
2018-09-26 13:13 ` [Intel-gfx] " Chris Wilson
@ 2018-09-26 14:54 ` Joonas Lahtinen
-1 siblings, 0 replies; 6+ messages in thread
From: Joonas Lahtinen @ 2018-09-26 14:54 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
Quoting Chris Wilson (2018-09-26 16:13:53)
> Nobody uses the function directly, instead using the various helpers to
> determine if ppgtt is present.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] lib: Unexport gem_gtt_type()
@ 2018-09-26 14:54 ` Joonas Lahtinen
0 siblings, 0 replies; 6+ messages in thread
From: Joonas Lahtinen @ 2018-09-26 14:54 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
Quoting Chris Wilson (2018-09-26 16:13:53)
> Nobody uses the function directly, instead using the various helpers to
> determine if ppgtt is present.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib: Unexport gem_gtt_type()
2018-09-26 13:13 ` [Intel-gfx] " Chris Wilson
(?)
(?)
@ 2018-09-26 16:10 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-09-26 16:10 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib: Unexport gem_gtt_type()
URL : https://patchwork.freedesktop.org/series/50213/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4874 -> IGTPW_1874 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50213/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1874 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-bdw-samus: PASS -> INCOMPLETE (fdo#107773)
igt@kms_flip@basic-flip-vs-modeset:
fi-skl-6700hq: NOTRUN -> DMESG-WARN (fdo#105998) +1
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cfl-8109u: INCOMPLETE (fdo#106070) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
== Participating hosts (48 -> 42) ==
Additional (1): fi-skl-6700hq
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-bdw-gvtdvm fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* IGT: IGT_4649 -> IGTPW_1874
CI_DRM_4874: 7bb42432ef1cc63b4a6a223e19455f6c4f9a1538 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1874: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1874/
IGT_4649: 19b0c74d20d9b53d4c82be14af0909a3b6846010 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1874/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for lib: Unexport gem_gtt_type()
2018-09-26 13:13 ` [Intel-gfx] " Chris Wilson
` (2 preceding siblings ...)
(?)
@ 2018-09-26 22:16 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-09-26 22:16 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: lib: Unexport gem_gtt_type()
URL : https://patchwork.freedesktop.org/series/50213/
State : failure
== Summary ==
= CI Bug Log - changes from IGT_4649_full -> IGTPW_1874_full =
== Summary - FAILURE ==
Serious unknown changes coming with IGTPW_1874_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1874_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50213/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1874_full:
=== IGT changes ===
==== Possible regressions ====
igt@kms_draw_crc@draw-method-xrgb8888-mmap-wc-xtiled:
shard-glk: PASS -> FAIL
== Known issues ==
Here are the changes found in IGTPW_1874_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_big:
shard-hsw: PASS -> TIMEOUT (fdo#107937)
igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
shard-hsw: PASS -> FAIL (fdo#105767)
igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
shard-hsw: PASS -> FAIL (fdo#103355)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-render:
shard-glk: PASS -> FAIL (fdo#103167)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-a-wait-busy:
shard-glk: PASS -> DMESG-WARN (fdo#105763, fdo#106538) +2
==== Possible fixes ====
igt@kms_busy@extended-pageflip-hang-newfb-render-a:
shard-apl: DMESG-WARN (fdo#107956) -> PASS
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@kms_cursor_legacy@pipe-c-forked-move:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
shard-kbl: DMESG-WARN (fdo#105602, fdo#103558) -> PASS +14
==== Warnings ====
igt@kms_busy@extended-modeset-hang-newfb-render-c:
shard-glk: DMESG-WARN (fdo#107956) -> INCOMPLETE (fdo#103359, k.org#198133)
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4649 -> IGTPW_1874
* Linux: CI_DRM_4859 -> CI_DRM_4874
CI_DRM_4859: 841654aee134e50b21bf8f2aab17da8d0afd14c4 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4874: 7bb42432ef1cc63b4a6a223e19455f6c4f9a1538 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1874: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1874/
IGT_4649: 19b0c74d20d9b53d4c82be14af0909a3b6846010 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1874/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-26 22:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 13:13 [PATCH i-g-t] lib: Unexport gem_gtt_type() Chris Wilson
2018-09-26 13:13 ` [Intel-gfx] " Chris Wilson
2018-09-26 14:54 ` Joonas Lahtinen
2018-09-26 14:54 ` [Intel-gfx] " Joonas Lahtinen
2018-09-26 16:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-09-26 22:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.