From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Aristeu Rozanski <aris@redhat.com>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
linux-edac@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: [4/5] EDAC, dsm_edac: Wrap ACPI DSM methods for address translation
Date: Wed, 26 Sep 2018 11:22:25 -0700 [thread overview]
Message-ID: <20180926182225.GA1664@agluck-desk> (raw)
On Wed, Sep 26, 2018 at 07:33:14PM +0200, Borislav Petkov wrote:
> + Rafael.
>
> On Mon, Sep 24, 2018 at 01:16:12PM -0700, Tony Luck wrote:
> > From: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> >
> > Some machines provide BIOS ACPI DSM (Device Specific Method)
> > to translate memory system address to DRAM address (socket, memory
> > controller, channel, rank, bank, row, column). This patch wraps
> > the DSM methods, and registers them to EDAC core.
>
> Why?
>
> Why isn't this part of the ACPI core and why isn't it exporting
> proper interfaces for EDAC to use?
This isn't part of ACPI spec. Just a device specific method available
to the OS. Someday, after we clean up the rough edges found by using it,
we might submit it for inclusion in the ACPI spec. But we are a long way
from that point.
> This looks like a bunch of ACPI code outside of ACPI. And it is grafted
> on the EDAC core with an ops reg/dereg thing. Ewww.
We can put it someplace else if you have a better suggestion.
> Can we please design this properly instead of just slapping it where it
> sticks?
Sure. I should have posted it as [RFC] rather than [PATCH].
The plan going forward is that EDAC drivers can be much smaller. They
just need to discover memory controller and DIMM topology and register
a handler on the mce_decode_chain. All the work in turning system
addresses into DIMM addresses can be handled by a call to the BIOS
(which knows how to do this, and the people writing it have resources
to validate on way more configurations than I can).
-Tony
next reply other threads:[~2018-09-26 18:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 18:22 Luck, Tony [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-09 18:33 [4/5] EDAC, dsm_edac: Wrap ACPI DSM methods for address translation Luck, Tony
2018-10-09 18:29 Luck, Tony
2018-10-09 16:17 Borislav Petkov
2018-10-09 15:29 Rafael J. Wysocki
2018-10-09 15:25 Rafael J. Wysocki
2018-10-09 15:22 Luck, Tony
2018-10-09 15:14 Borislav Petkov
2018-10-09 11:43 Qiuxu Zhuo
2018-10-09 10:28 Rafael J. Wysocki
2018-10-08 16:57 Luck, Tony
2018-10-06 20:44 Borislav Petkov
2018-10-05 22:25 Luck, Tony
2018-10-04 9:31 Borislav Petkov
2018-10-03 17:58 Luck, Tony
2018-09-26 17:33 Borislav Petkov
2018-09-24 20:16 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926182225.GA1664@agluck-desk \
--to=tony.luck@intel.com \
--cc=aris@redhat.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=qiuxu.zhuo@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.