* [igt-dev] [PATCH i-g-t 1/1] runner: Plug an fd leak
@ 2018-09-27 9:30 Petri Latvala
2018-09-27 10:22 ` Arkadiusz Hiler
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Petri Latvala @ 2018-09-27 9:30 UTC (permalink / raw)
To: igt-dev
Make sure comparefd gets closed in dump_dmesg(). Otherwise we run out
of descriptors after a bit over 1000 tests executed...
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
runner/executor.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/runner/executor.c b/runner/executor.c
index fd262eb4..d0539aa1 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -249,15 +249,19 @@ static void dump_dmesg(int kmsgfd, int outfd)
return;
lseek(comparefd, 0, SEEK_END);
- if (fcntl(kmsgfd, F_SETFL, O_NONBLOCK))
+ if (fcntl(kmsgfd, F_SETFL, O_NONBLOCK)) {
+ close(comparefd);
return;
+ }
while (1) {
if (comparefd >= 0) {
r = read(comparefd, buf, sizeof(buf) - 1);
if (r < 0) {
- if (errno != EAGAIN && errno != EPIPE)
+ if (errno != EAGAIN && errno != EPIPE) {
+ close(comparefd);
return;
+ }
} else {
buf[r] = '\0';
if (sscanf(buf, "%u,%llu,%llu,%c;",
@@ -278,6 +282,7 @@ static void dump_dmesg(int kmsgfd, int outfd)
* If EAGAIN, we're done. If some other error,
* we can't do anything anyway.
*/
+ close(comparefd);
return;
}
--
2.18.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/1] runner: Plug an fd leak
2018-09-27 9:30 [igt-dev] [PATCH i-g-t 1/1] runner: Plug an fd leak Petri Latvala
@ 2018-09-27 10:22 ` Arkadiusz Hiler
2018-09-27 14:43 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2018-09-28 0:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Arkadiusz Hiler @ 2018-09-27 10:22 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
On Thu, Sep 27, 2018 at 12:30:56PM +0300, Petri Latvala wrote:
> Make sure comparefd gets closed in dump_dmesg(). Otherwise we run out
> of descriptors after a bit over 1000 tests executed...
>
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] runner: Plug an fd leak
2018-09-27 9:30 [igt-dev] [PATCH i-g-t 1/1] runner: Plug an fd leak Petri Latvala
2018-09-27 10:22 ` Arkadiusz Hiler
@ 2018-09-27 14:43 ` Patchwork
2018-09-28 0:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-09-27 14:43 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] runner: Plug an fd leak
URL : https://patchwork.freedesktop.org/series/50266/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4899 -> IGTPW_1877 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50266/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1877 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-bdw-samus: NOTRUN -> INCOMPLETE (fdo#107773)
igt@kms_psr@primary_page_flip:
fi-skl-6700hq: NOTRUN -> FAIL (fdo#107336)
igt@pm_rpm@module-reload:
fi-skl-6600u: PASS -> INCOMPLETE (fdo#107807)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s4-devices:
fi-bdw-samus: INCOMPLETE (fdo#107773) -> PASS
igt@kms_psr@primary_page_flip:
fi-whl-u: FAIL (fdo#107336) -> PASS
fi-kbl-r: FAIL (fdo#107336) -> PASS
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
== Participating hosts (45 -> 38) ==
Additional (1): fi-skl-6700hq
Missing (8): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-ctg-p8600 fi-cfl-8109u fi-pnv-d510 fi-icl-u
== Build changes ==
* IGT: IGT_4654 -> IGTPW_1877
CI_DRM_4899: fd4ca44f6b056b12a76ebea32b09bac8501dc9a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1877: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1877/
IGT_4654: 036b60a388685dcd38c33dc4b7ba55130a2d200d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1877/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/1] runner: Plug an fd leak
2018-09-27 9:30 [igt-dev] [PATCH i-g-t 1/1] runner: Plug an fd leak Petri Latvala
2018-09-27 10:22 ` Arkadiusz Hiler
2018-09-27 14:43 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
@ 2018-09-28 0:01 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-09-28 0:01 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/1] runner: Plug an fd leak
URL : https://patchwork.freedesktop.org/series/50266/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4654_full -> IGTPW_1877_full =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50266/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1877_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-snb: PASS -> INCOMPLETE (fdo#106886, fdo#105411)
igt@kms_available_modes_crc@available_mode_test_crc:
shard-snb: NOTRUN -> FAIL (fdo#106641)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-snb: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763) +1
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt:
shard-glk: FAIL (fdo#103167) -> PASS +1
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
igt@pm_rps@reset:
shard-glk: FAIL (fdo#102250) -> PASS
fdo#102250 https://bugs.freedesktop.org/show_bug.cgi?id=102250
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4654 -> IGTPW_1877
* Linux: CI_DRM_4897 -> CI_DRM_4899
CI_DRM_4897: e9c4ad6fd03bd0e28e4534b841d62407ac6003af @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4899: fd4ca44f6b056b12a76ebea32b09bac8501dc9a2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1877: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1877/
IGT_4654: 036b60a388685dcd38c33dc4b7ba55130a2d200d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1877/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-28 0:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 9:30 [igt-dev] [PATCH i-g-t 1/1] runner: Plug an fd leak Petri Latvala
2018-09-27 10:22 ` Arkadiusz Hiler
2018-09-27 14:43 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2018-09-28 0:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.