From: Jagan Teki <jagan@amarulasolutions.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Icenowy Zheng <icenowy@aosc.io>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Cc: Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH 06/12] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation
Date: Thu, 27 Sep 2018 17:18:44 +0530 [thread overview]
Message-ID: <20180927114850.24565-7-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20180927114850.24565-1-jagan@amarulasolutions.com>
According to horizontal and vertical timings are defined
per the diagram from include/drm/drm_modes.h
Back porch = [hv]total - [hv]sync_end
So, update SUN6I_DSI_BASIC_SIZE0_VBP calculation as
mode->vtotal - mode->vsync_end
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
index 1c7e42015645..599284971ab6 100644
--- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
+++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
@@ -526,8 +526,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,
regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE0_REG,
SUN6I_DSI_BASIC_SIZE0_VSA(mode->vsync_end -
mode->vsync_start) |
- SUN6I_DSI_BASIC_SIZE0_VBP(mode->vsync_start -
- mode->vdisplay));
+ SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal -
+ mode->vsync_end));
regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE1_REG,
SUN6I_DSI_BASIC_SIZE1_VACT(mode->vdisplay) |
--
2.18.0.321.gffc6fa0e3
WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>,
Jernej Skrabec <jernej.skrabec-gGgVlfcn5nU@public.gmane.org>,
Vasily Khoruzhick
<anarsoul-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
David Airlie <airlied-cv59FeDIM0c@public.gmane.org>,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
Michael Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Michael Trimarchi
<michael-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Cc: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Subject: [PATCH 06/12] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation
Date: Thu, 27 Sep 2018 17:18:44 +0530 [thread overview]
Message-ID: <20180927114850.24565-7-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20180927114850.24565-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
According to horizontal and vertical timings are defined
per the diagram from include/drm/drm_modes.h
Back porch = [hv]total - [hv]sync_end
So, update SUN6I_DSI_BASIC_SIZE0_VBP calculation as
mode->vtotal - mode->vsync_end
Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
---
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
index 1c7e42015645..599284971ab6 100644
--- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
+++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
@@ -526,8 +526,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,
regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE0_REG,
SUN6I_DSI_BASIC_SIZE0_VSA(mode->vsync_end -
mode->vsync_start) |
- SUN6I_DSI_BASIC_SIZE0_VBP(mode->vsync_start -
- mode->vdisplay));
+ SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal -
+ mode->vsync_end));
regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE1_REG,
SUN6I_DSI_BASIC_SIZE1_VACT(mode->vdisplay) |
--
2.18.0.321.gffc6fa0e3
WARNING: multiple messages have this Message-ID (diff)
From: jagan@amarulasolutions.com (Jagan Teki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/12] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation
Date: Thu, 27 Sep 2018 17:18:44 +0530 [thread overview]
Message-ID: <20180927114850.24565-7-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20180927114850.24565-1-jagan@amarulasolutions.com>
According to horizontal and vertical timings are defined
per the diagram from include/drm/drm_modes.h
Back porch = [hv]total - [hv]sync_end
So, update SUN6I_DSI_BASIC_SIZE0_VBP calculation as
mode->vtotal - mode->vsync_end
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
index 1c7e42015645..599284971ab6 100644
--- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
+++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
@@ -526,8 +526,8 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi,
regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE0_REG,
SUN6I_DSI_BASIC_SIZE0_VSA(mode->vsync_end -
mode->vsync_start) |
- SUN6I_DSI_BASIC_SIZE0_VBP(mode->vsync_start -
- mode->vdisplay));
+ SUN6I_DSI_BASIC_SIZE0_VBP(mode->vtotal -
+ mode->vsync_end));
regmap_write(dsi->regs, SUN6I_DSI_BASIC_SIZE1_REG,
SUN6I_DSI_BASIC_SIZE1_VACT(mode->vdisplay) |
--
2.18.0.321.gffc6fa0e3
next prev parent reply other threads:[~2018-09-27 11:49 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 11:48 [PATCH 00/12] drm/sun4i: Allwinner A64 MIPI-DSI support Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` [PATCH 01/12] clk: sunxi-ng: a64: Fix gate bit of DSI DPHY Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` [PATCH 02/12] drm/sun4i: sun6i_mipi_dsi: Add Allwinner A64 MIPI DSI support Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` [PATCH 03/12] dt-bindings: sun6i-dsi: Add compatible for A64 MIPI DSI Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-10-15 18:24 ` Rob Herring
2018-10-15 18:24 ` Rob Herring
2018-10-15 18:24 ` Rob Herring
2018-09-27 11:48 ` [PATCH 04/12] drm/sun4i: sun6i_mipi_dsi: Enable missing DSI bus clock Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 12:42 ` Chen-Yu Tsai
2018-09-27 12:42 ` Chen-Yu Tsai
2018-09-27 12:42 ` Chen-Yu Tsai
2018-09-27 13:44 ` Jagan Teki
2018-09-27 13:44 ` Jagan Teki
2018-09-27 13:44 ` Jagan Teki
2018-09-27 14:16 ` [linux-sunxi] " Chen-Yu Tsai
2018-09-27 14:16 ` Chen-Yu Tsai
2018-09-27 14:16 ` Chen-Yu Tsai
2018-09-27 16:26 ` [linux-sunxi] " Jagan Teki
2018-09-27 16:26 ` Jagan Teki
2018-09-27 16:26 ` Jagan Teki
2018-09-27 16:33 ` [linux-sunxi] " Chen-Yu Tsai
2018-09-27 16:33 ` Chen-Yu Tsai
2018-09-27 16:33 ` Chen-Yu Tsai
2018-09-27 11:48 ` [PATCH 05/12] drm/sun4i: sun6i_mipi_dsi: Add DSI Generic short write 2 param transfer Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 17:18 ` Maxime Ripard
2018-09-27 17:18 ` Maxime Ripard
2018-09-27 17:18 ` Maxime Ripard
2018-09-27 17:18 ` Maxime Ripard
2018-09-27 17:36 ` Jagan Teki
2018-09-27 17:36 ` Jagan Teki
2018-09-29 13:47 ` Maxime Ripard
2018-09-29 13:47 ` Maxime Ripard
2018-09-29 13:47 ` Maxime Ripard
2018-09-27 11:48 ` Jagan Teki [this message]
2018-09-27 11:48 ` [PATCH 06/12] drm/sun4i: sun6i_mipi_dsi: Fix VBP size calculation Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 15:21 ` Maxime Ripard
2018-09-27 15:21 ` Maxime Ripard
2018-09-27 15:21 ` Maxime Ripard
2018-09-27 16:20 ` Jagan Teki
2018-09-27 16:20 ` Jagan Teki
2018-09-27 16:20 ` Jagan Teki
2018-09-29 13:53 ` Maxime Ripard
2018-09-29 13:53 ` Maxime Ripard
2018-09-29 13:53 ` Maxime Ripard
2018-10-01 8:09 ` [linux-sunxi] " Jagan Teki
2018-10-01 8:09 ` Jagan Teki
2018-10-08 15:05 ` Maxime Ripard
2018-10-08 15:05 ` Maxime Ripard
2018-10-08 15:05 ` Maxime Ripard
2018-09-27 11:48 ` [PATCH 07/12] drm/sun4i: sun6i_mipi_dsi: Fix TCON DRQ set bits Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 16:58 ` Maxime Ripard
2018-09-27 16:58 ` Maxime Ripard
2018-09-27 16:58 ` Maxime Ripard
2018-09-27 16:58 ` Maxime Ripard
2018-09-27 17:45 ` Jagan Teki
2018-09-27 17:45 ` Jagan Teki
2018-09-27 17:45 ` Jagan Teki
2018-10-02 13:20 ` Maxime Ripard
2018-10-02 13:20 ` Maxime Ripard
2018-10-02 13:20 ` Maxime Ripard
2018-10-03 3:22 ` [linux-sunxi] " Jagan Teki
2018-10-03 3:22 ` Jagan Teki
2018-10-03 3:22 ` Jagan Teki
2018-10-08 15:05 ` [linux-sunxi] " Maxime Ripard
2018-10-08 15:05 ` Maxime Ripard
2018-10-08 15:05 ` Maxime Ripard
2018-09-27 11:48 ` [PATCH 08/12] drm/sun4i: sun6i_mipi_dsi: Refactor vertical video start delay Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 17:14 ` Maxime Ripard
2018-09-27 17:14 ` Maxime Ripard
2018-09-27 17:14 ` Maxime Ripard
2018-09-27 17:33 ` Jagan Teki
2018-09-27 17:33 ` Jagan Teki
2018-09-27 17:33 ` Jagan Teki
2018-09-29 15:27 ` Maxime Ripard
2018-09-29 15:27 ` Maxime Ripard
2018-09-29 15:27 ` Maxime Ripard
2018-10-01 7:55 ` [linux-sunxi] " Jagan Teki
2018-10-01 7:55 ` Jagan Teki
2018-10-01 7:55 ` Jagan Teki
2018-10-02 13:29 ` [linux-sunxi] " Maxime Ripard
2018-10-02 13:29 ` Maxime Ripard
2018-10-02 13:29 ` Maxime Ripard
2018-09-27 11:48 ` [PATCH 09/12] dt-bindings: panel: Add Bananapi S070WV20-CT16 MIPI-DSI panel bindings Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-10-15 18:24 ` Rob Herring
2018-10-15 18:24 ` Rob Herring
2018-10-15 18:24 ` Rob Herring
2018-10-22 10:22 ` Chen-Yu Tsai
2018-10-22 10:22 ` Chen-Yu Tsai
2018-10-22 10:22 ` Chen-Yu Tsai
2018-10-23 15:11 ` Rob Herring
2018-10-23 15:11 ` Rob Herring
2018-10-23 15:11 ` Rob Herring
2018-10-24 20:22 ` Chen-Yu Tsai
2018-10-24 20:22 ` Chen-Yu Tsai
2018-09-27 11:48 ` [PATCH 10/12] drm/panel: Add Bananapi S070WV20-CT16 MIPI-DSI panel driver Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-28 4:32 ` Chen-Yu Tsai
2018-09-28 4:32 ` Chen-Yu Tsai
2018-09-28 4:32 ` Chen-Yu Tsai
2018-10-04 16:06 ` Jagan Teki
2018-10-04 16:06 ` Jagan Teki
2018-10-04 16:06 ` Jagan Teki
2018-09-27 11:48 ` [PATCH 11/12] arm64: dts: allwinner: a64: Add DSI pipeline Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 17:16 ` Maxime Ripard
2018-09-27 17:16 ` Maxime Ripard
2018-09-27 17:16 ` Maxime Ripard
2018-09-27 17:16 ` Maxime Ripard
2018-09-27 11:48 ` [PATCH 12/12] arm64: dts: allwinner: bananapi-m64: Bananapi S070WV20-CT16 DSI panel Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 11:48 ` Jagan Teki
2018-09-27 17:17 ` Maxime Ripard
2018-09-27 17:17 ` Maxime Ripard
2018-09-27 17:17 ` Maxime Ripard
2018-09-27 17:17 ` Maxime Ripard
2018-10-04 16:03 ` Jagan Teki
2018-10-04 16:03 ` Jagan Teki
2018-10-04 16:03 ` Jagan Teki
2018-10-05 15:31 ` Maxime Ripard
2018-10-05 15:31 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927114850.24565-7-jagan@amarulasolutions.com \
--to=jagan@amarulasolutions.com \
--cc=airlied@linux.ie \
--cc=anarsoul@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=michael@amarulasolutions.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.