* [Buildroot] [PATCH 0/2] perl-sys-cpu fixes
@ 2018-09-27 14:46 Christopher McCrory
2018-09-27 14:46 ` [Buildroot] [PATCH 1/2] perl-sys-cpu: disable static builds Christopher McCrory
2018-09-27 14:46 ` [Buildroot] [PATCH 2/2] perl-sys-cpu: remove extraneous include Christopher McCrory
0 siblings, 2 replies; 5+ messages in thread
From: Christopher McCrory @ 2018-09-27 14:46 UTC (permalink / raw)
To: buildroot
The second patch has
- #include <sys/unistd.h>
because it is redundant with glibc, and doesn't exist with musl and
uclib. Does anyone know if it is needed on other platforms?
Christopher McCrory (2):
perl-sys-cpu: disable static builds
perl-sys-cpu: remove extraneous include
package/perl-sys-cpu/0001-remove-extraneous-include.patch | 10 ++++++++++
package/perl-sys-cpu/Config.in | 4 ++++
2 files changed, 14 insertions(+)
create mode 100644 package/perl-sys-cpu/0001-remove-extraneous-include.patch
--
2.14.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] perl-sys-cpu: disable static builds
2018-09-27 14:46 [Buildroot] [PATCH 0/2] perl-sys-cpu fixes Christopher McCrory
@ 2018-09-27 14:46 ` Christopher McCrory
2018-10-08 19:56 ` Thomas Petazzoni
2018-09-27 14:46 ` [Buildroot] [PATCH 2/2] perl-sys-cpu: remove extraneous include Christopher McCrory
1 sibling, 1 reply; 5+ messages in thread
From: Christopher McCrory @ 2018-09-27 14:46 UTC (permalink / raw)
To: buildroot
Disable static builds like other perl modules
fixes autobuild failures
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
package/perl-sys-cpu/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/perl-sys-cpu/Config.in b/package/perl-sys-cpu/Config.in
index a604945740..8306b371dc 100644
--- a/package/perl-sys-cpu/Config.in
+++ b/package/perl-sys-cpu/Config.in
@@ -1,5 +1,9 @@
config BR2_PACKAGE_PERL_SYS_CPU
bool "perl-sys-cpu"
+ depends on !BR2_STATIC_LIBS
help
Perl module for getting information about the system CPU
(Sys::CPU).
+
+comment "perl-sys-cpu needs a toolchain w/ dynamic library"
+ depends on BR2_STATIC_LIBS
--
2.14.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] perl-sys-cpu: remove extraneous include
2018-09-27 14:46 [Buildroot] [PATCH 0/2] perl-sys-cpu fixes Christopher McCrory
2018-09-27 14:46 ` [Buildroot] [PATCH 1/2] perl-sys-cpu: disable static builds Christopher McCrory
@ 2018-09-27 14:46 ` Christopher McCrory
2018-10-08 19:57 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Christopher McCrory @ 2018-09-27 14:46 UTC (permalink / raw)
To: buildroot
remove extraneous include <sys/unistd.h>
in glibc this points back to include unistd.h
neither musl, nor uclib have it.
Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
---
| 10 ++++++++++
1 file changed, 10 insertions(+)
create mode 100644 package/perl-sys-cpu/0001-remove-extraneous-include.patch
--git a/package/perl-sys-cpu/0001-remove-extraneous-include.patch b/package/perl-sys-cpu/0001-remove-extraneous-include.patch
new file mode 100644
index 0000000000..2ef11a0226
--- /dev/null
+++ b/package/perl-sys-cpu/0001-remove-extraneous-include.patch
@@ -0,0 +1,10 @@
+--- perl-sys-cpu-0.52/CPU.xs.orig 2018-09-18 10:23:48.473223024 -0700
++++ perl-sys-cpu-0.52/CPU.xs 2018-09-18 10:24:40.973670159 -0700
+@@ -24,7 +24,6 @@
+ #include <winreg.h>
+ #else /* other (try unix) */
+ #include <unistd.h>
+- #include <sys/unistd.h>
+ #endif
+ #if defined(__sun) || defined(__sun__)
+ #include <sys/processor.h>
--
2.14.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] perl-sys-cpu: disable static builds
2018-09-27 14:46 ` [Buildroot] [PATCH 1/2] perl-sys-cpu: disable static builds Christopher McCrory
@ 2018-10-08 19:56 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-10-08 19:56 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 27 Sep 2018 07:46:45 -0700, Christopher McCrory wrote:
> Disable static builds like other perl modules
> fixes autobuild failures
>
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
> package/perl-sys-cpu/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
Your commit log was missing a reference to the autobuilder failure
being fixed. I've added that and applied.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] perl-sys-cpu: remove extraneous include
2018-09-27 14:46 ` [Buildroot] [PATCH 2/2] perl-sys-cpu: remove extraneous include Christopher McCrory
@ 2018-10-08 19:57 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-10-08 19:57 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 27 Sep 2018 07:46:46 -0700, Christopher McCrory wrote:
> remove extraneous include <sys/unistd.h>
> in glibc this points back to include unistd.h
> neither musl, nor uclib have it.
>
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
The patch below was missing a description, and the commit log was
lacking a reference to the autobuilder failure being fixed. I've fixed
both issues, and applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-08 19:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 14:46 [Buildroot] [PATCH 0/2] perl-sys-cpu fixes Christopher McCrory
2018-09-27 14:46 ` [Buildroot] [PATCH 1/2] perl-sys-cpu: disable static builds Christopher McCrory
2018-10-08 19:56 ` Thomas Petazzoni
2018-09-27 14:46 ` [Buildroot] [PATCH 2/2] perl-sys-cpu: remove extraneous include Christopher McCrory
2018-10-08 19:57 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.