From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux-foundation.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/5] dma-direct: refine dma_direct_alloc zone selection
Date: Thu, 27 Sep 2018 17:41:17 +0200 [thread overview]
Message-ID: <20180927154117.GA10956@lst.de> (raw)
In-Reply-To: <2b98d7b2-bf74-ccc9-881a-a91e2c9949c3@arm.com>
On Thu, Sep 27, 2018 at 04:38:31PM +0100, Robin Murphy wrote:
> On 27/09/18 16:30, Christoph Hellwig wrote:
>> On Thu, Sep 27, 2018 at 03:30:20PM +0100, Robin Murphy wrote:
>>>> +static gfp_t __dma_direct_optimal_gfp_mask(struct device *dev, u64
>>>> dma_mask,
>>>> + u64 *phys_mask)
>>>> +{
>>>> + if (force_dma_unencrypted())
>>>> + *phys_mask = __dma_to_phys(dev, dma_mask);
>>>> + else
>>>> + *phys_mask = dma_to_phys(dev, dma_mask);
>>>
>>> Maybe make phys_to_dma_direct() take u64 instead of phys_addr_t so we can
>>> reuse it here?
>>
>> This is a dma_to_phys and not a phys_to_dma.
>
> Ugh, clearly it's time to stop reviewing patches for today... sorry :(
I actually made the same mistake when writing it..
ALthough I'd really like to see some feedback from you on the arm64
swiotlb series once you had more cofee ;-)
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: Benjamin Herrenschmidt
<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH 3/5] dma-direct: refine dma_direct_alloc zone selection
Date: Thu, 27 Sep 2018 17:41:17 +0200 [thread overview]
Message-ID: <20180927154117.GA10956@lst.de> (raw)
In-Reply-To: <2b98d7b2-bf74-ccc9-881a-a91e2c9949c3-5wv7dgnIgG8@public.gmane.org>
On Thu, Sep 27, 2018 at 04:38:31PM +0100, Robin Murphy wrote:
> On 27/09/18 16:30, Christoph Hellwig wrote:
>> On Thu, Sep 27, 2018 at 03:30:20PM +0100, Robin Murphy wrote:
>>>> +static gfp_t __dma_direct_optimal_gfp_mask(struct device *dev, u64
>>>> dma_mask,
>>>> + u64 *phys_mask)
>>>> +{
>>>> + if (force_dma_unencrypted())
>>>> + *phys_mask = __dma_to_phys(dev, dma_mask);
>>>> + else
>>>> + *phys_mask = dma_to_phys(dev, dma_mask);
>>>
>>> Maybe make phys_to_dma_direct() take u64 instead of phys_addr_t so we can
>>> reuse it here?
>>
>> This is a dma_to_phys and not a phys_to_dma.
>
> Ugh, clearly it's time to stop reviewing patches for today... sorry :(
I actually made the same mistake when writing it..
ALthough I'd really like to see some feedback from you on the arm64
swiotlb series once you had more cofee ;-)
next prev parent reply other threads:[~2018-09-27 15:41 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 18:52 dma mask related fixups (including full bus_dma_mask support) Christoph Hellwig
2018-09-20 18:52 ` [PATCH 1/5] dma-mapping: make the get_required_mask method available unconditionally Christoph Hellwig
2018-09-27 1:28 ` Benjamin Herrenschmidt
2018-09-27 1:28 ` Benjamin Herrenschmidt
2018-09-20 18:52 ` [PATCH 2/5] dma-direct: add an explicit dma_direct_get_required_mask Christoph Hellwig
2018-09-27 1:31 ` Benjamin Herrenschmidt
2018-09-27 1:31 ` Benjamin Herrenschmidt
2018-09-27 14:12 ` Robin Murphy
2018-09-27 15:28 ` Christoph Hellwig
2018-09-27 15:35 ` Robin Murphy
2018-09-27 15:35 ` Robin Murphy
2018-09-20 18:52 ` [PATCH 3/5] dma-direct: refine dma_direct_alloc zone selection Christoph Hellwig
2018-09-27 1:45 ` Benjamin Herrenschmidt
2018-09-27 1:45 ` Benjamin Herrenschmidt
2018-09-27 13:49 ` Christoph Hellwig
2018-09-27 13:49 ` Christoph Hellwig
2018-09-28 0:06 ` Benjamin Herrenschmidt
2018-09-28 0:06 ` Benjamin Herrenschmidt
2018-09-28 0:06 ` Benjamin Herrenschmidt
2018-09-28 15:46 ` Christoph Hellwig
2018-09-28 15:46 ` Christoph Hellwig
2018-09-27 14:30 ` Robin Murphy
2018-09-27 15:30 ` Christoph Hellwig
2018-09-27 15:38 ` Robin Murphy
2018-09-27 15:38 ` Robin Murphy
2018-09-27 15:41 ` Christoph Hellwig [this message]
2018-09-27 15:41 ` Christoph Hellwig
2018-09-20 18:52 ` [PATCH 4/5] dma-direct: implement complete bus_dma_mask handling Christoph Hellwig
2018-09-27 14:58 ` Robin Murphy
2018-09-27 14:58 ` Robin Murphy
2018-09-27 15:32 ` Christoph Hellwig
2018-09-27 16:14 ` Robin Murphy
2018-09-27 16:14 ` Robin Murphy
2018-09-27 16:27 ` Christoph Hellwig
2018-09-27 16:27 ` Christoph Hellwig
2018-09-27 16:27 ` Christoph Hellwig
2018-09-27 16:41 ` Robin Murphy
2018-09-27 16:41 ` Robin Murphy
2018-09-27 16:41 ` Robin Murphy
2018-09-20 18:52 ` [PATCH 5/5] dma-direct: always allow dma mask <= physiscal memory size Christoph Hellwig
2018-09-27 1:50 ` Benjamin Herrenschmidt
2018-09-27 1:50 ` Benjamin Herrenschmidt
2018-09-27 13:49 ` Christoph Hellwig
2018-09-27 15:07 ` Robin Murphy
2018-09-27 22:35 dma mask related fixups (including full bus_dma_mask support) v2 Christoph Hellwig
2018-09-27 22:35 ` [PATCH 3/5] dma-direct: refine dma_direct_alloc zone selection Christoph Hellwig
2018-09-27 22:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927154117.GA10956@lst.de \
--to=hch@lst.de \
--cc=benh@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.