From: Rob Herring <robh@kernel.org> To: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> Cc: linux-mtd@lists.infradead.org, boris.brezillon@bootlin.com, marek.vasut@gmail.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, computersforpeace@gmail.com, frieder.schrempf@exceet.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/5] dt-bindings: spi: add binding file for NXP FlexSPI controller Date: Thu, 27 Sep 2018 14:10:00 -0500 [thread overview] Message-ID: <20180927191000.GA18549@bogus> (raw) In-Reply-To: <1537525323-20730-3-git-send-email-yogeshnarayan.gaur@nxp.com> On Fri, Sep 21, 2018 at 03:52:00PM +0530, Yogesh Gaur wrote: > Add binding file for NXP FlexSPI controller > > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> > --- > Changes for v3: > - None > Changes for v2: > - Incorporated Rob review comments. > > .../devicetree/bindings/spi/spi-nxp-fspi.txt | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > new file mode 100644 > index 0000000..94b5203 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > @@ -0,0 +1,42 @@ > +* NXP Flex Serial Peripheral Interface (FSPI) > + > +Required properties: > + - compatible : Should be "nxp,lx2160a-fspi" > + - reg : First contains the register location and length, > + Second contains the memory mapping address and length > + - reg-names : Should contain the resource reg names: > + - fspi_base: configuration register address space > + - fspi_mmap: memory mapped address space > + - interrupts : Should contain the interrupt for the device > + > +Optional properties: > + - big-endian : See common-properties.txt. > + > +Required SPI slave node properties: > + - reg : There are two buses (A and B) with two chip selects each. > + This encodes to which bus and CS the flash is connected: > + - <0>: Bus A, CS 0 > + - <1>: Bus A, CS 1 > + - <2>: Bus B, CS 0 > + - <3>: Bus B, CS 1 > + > +Example showing the usage of two SPI NOR slave devices on bus A: > + > +fspi@0: flexspi@20c0000 { Use standard node names. spi@... > + compatible = "nxp,lx2160a-fspi"; > + reg = <0x0 0x20c0000 0x0 0x10000>, <0x0 0x20000000 0x0 0x10000000>; > + reg-names = "fspi_base", "fspi_mmap"; > + interrupts = <0 25 0x4>; /* Level high type */ > + clocks = <&clockgen 4 3>, <&clockgen 4 3>; > + clock-names = "fspi_en", "fspi"; > + > + flash@0: mt35xu512aba@0 { You've got the label and node name reversed. Drop the '@' in the label. That should be reserved for node names. > + reg = <0>; > + .... > + }; > + > + flash@1: mt35xu512aba@1 { > + reg = <1>; > + .... > + }; > +}; > -- > 2.7.4 >
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/5] dt-bindings: spi: add binding file for NXP FlexSPI controller Date: Thu, 27 Sep 2018 14:10:00 -0500 [thread overview] Message-ID: <20180927191000.GA18549@bogus> (raw) In-Reply-To: <1537525323-20730-3-git-send-email-yogeshnarayan.gaur@nxp.com> On Fri, Sep 21, 2018 at 03:52:00PM +0530, Yogesh Gaur wrote: > Add binding file for NXP FlexSPI controller > > Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur@nxp.com> > --- > Changes for v3: > - None > Changes for v2: > - Incorporated Rob review comments. > > .../devicetree/bindings/spi/spi-nxp-fspi.txt | 42 ++++++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > > diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > new file mode 100644 > index 0000000..94b5203 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > @@ -0,0 +1,42 @@ > +* NXP Flex Serial Peripheral Interface (FSPI) > + > +Required properties: > + - compatible : Should be "nxp,lx2160a-fspi" > + - reg : First contains the register location and length, > + Second contains the memory mapping address and length > + - reg-names : Should contain the resource reg names: > + - fspi_base: configuration register address space > + - fspi_mmap: memory mapped address space > + - interrupts : Should contain the interrupt for the device > + > +Optional properties: > + - big-endian : See common-properties.txt. > + > +Required SPI slave node properties: > + - reg : There are two buses (A and B) with two chip selects each. > + This encodes to which bus and CS the flash is connected: > + - <0>: Bus A, CS 0 > + - <1>: Bus A, CS 1 > + - <2>: Bus B, CS 0 > + - <3>: Bus B, CS 1 > + > +Example showing the usage of two SPI NOR slave devices on bus A: > + > +fspi at 0: flexspi at 20c0000 { Use standard node names. spi at ... > + compatible = "nxp,lx2160a-fspi"; > + reg = <0x0 0x20c0000 0x0 0x10000>, <0x0 0x20000000 0x0 0x10000000>; > + reg-names = "fspi_base", "fspi_mmap"; > + interrupts = <0 25 0x4>; /* Level high type */ > + clocks = <&clockgen 4 3>, <&clockgen 4 3>; > + clock-names = "fspi_en", "fspi"; > + > + flash at 0: mt35xu512aba at 0 { You've got the label and node name reversed. Drop the '@' in the label. That should be reserved for node names. > + reg = <0>; > + .... > + }; > + > + flash at 1: mt35xu512aba at 1 { > + reg = <1>; > + .... > + }; > +}; > -- > 2.7.4 >
next prev parent reply other threads:[~2018-09-27 19:10 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-21 10:21 [PATCH v3 0/5] spi: spi-mem: Add driver for NXP FlexSPI controller Yogesh Gaur 2018-09-21 10:21 ` Yogesh Gaur 2018-09-21 10:21 ` [PATCH v3 1/5] " Yogesh Gaur 2018-09-21 10:21 ` Yogesh Gaur 2018-09-29 15:40 ` Boris Brezillon 2018-09-29 15:40 ` Boris Brezillon 2018-10-01 6:18 ` Frieder Schrempf 2018-10-01 6:18 ` Frieder Schrempf 2018-10-01 6:18 ` Frieder Schrempf 2018-10-01 9:02 ` Yogesh Narayan Gaur 2018-10-01 9:02 ` Yogesh Narayan Gaur 2018-10-01 9:02 ` Yogesh Narayan Gaur 2018-10-01 9:09 ` Boris Brezillon 2018-10-01 9:09 ` Boris Brezillon 2018-10-01 9:09 ` Boris Brezillon 2018-10-08 11:21 ` Yogesh Narayan Gaur 2018-10-08 11:21 ` Yogesh Narayan Gaur 2018-10-08 11:21 ` Yogesh Narayan Gaur 2018-10-08 12:32 ` Boris Brezillon 2018-10-08 12:32 ` Boris Brezillon 2018-10-08 12:32 ` Boris Brezillon 2018-09-21 10:22 ` [PATCH v3 2/5] dt-bindings: spi: add binding file " Yogesh Gaur 2018-09-21 10:22 ` Yogesh Gaur 2018-09-27 19:10 ` Rob Herring [this message] 2018-09-27 19:10 ` Rob Herring 2018-09-21 10:22 ` [PATCH v3 3/5] arm64: dts: lx2160a: add FlexSPI node property Yogesh Gaur 2018-09-21 10:22 ` Yogesh Gaur 2018-09-21 10:22 ` [PATCH v3 4/5] arm64: defconfig: enable NXP FlexSPI driver Yogesh Gaur 2018-09-21 10:22 ` Yogesh Gaur 2018-09-21 10:22 ` [PATCH v3 5/5] MAINTAINERS: add maintainers for the " Yogesh Gaur 2018-09-21 10:22 ` Yogesh Gaur
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180927191000.GA18549@bogus \ --to=robh@kernel.org \ --cc=boris.brezillon@bootlin.com \ --cc=computersforpeace@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=frieder.schrempf@exceet.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=shawnguo@kernel.org \ --cc=yogeshnarayan.gaur@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.