[PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev driver

[PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev driver

[Lukasz Majewski]

With this commit the DSPI driver on the BK4 board can be used for SPI
transmission managed from user space (via /dev/spidev0.0).

Example usage/testing:
insmod ./spi-fsl-dspi.ko
./spidev_test -D /dev/spidev0.0 -s 3000000 -v -H -b 8 -p "\xCC\x11\x22\x74"

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index cda10719d1d1..07f4d05563ea 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -669,6 +669,7 @@ static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "lineartechnology,ltc2488" },
 	{ .compatible = "ge,achc" },
 	{ .compatible = "semtech,sx1301" },
+	{ .compatible = "lwn,bk4" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, spidev_dt_ids);
-- 
2.11.0

Re: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev driver

[Jan Kundrát]

On pátek 28. září 2018 0:31:52 CEST, Lukasz Majewski wrote:
> With this commit the DSPI driver on the BK4 board can be used for SPI
> transmission managed from user space (via /dev/spidev0.0).

Hi Lukasz,
I tried submitting a similar patch for another devicem but got no reaction 
[1]. In the meanwhile, there has been another proposal [2] which moves 
handling of this into userspace via udev. You might want to take a look at 
that mechanism instead (and perhaps send your Tested-by tag). It has worked 
well for me.

[1] https://patchwork.kernel.org/patch/10558889/
[2] 
https://patchwork.kernel.org/project/spi-devel-general/list/?series=21295

Cheers,
Jan

Re: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

On Mon, Oct 01, 2018 at 04:20:32PM +0200, Jan Kundrát wrote:

> Hi Lukasz,
> I tried submitting a similar patch for another devicem but got no reaction
> [1]. In the meanwhile, there has been another proposal [2] which moves

As documented in SubmittingPatches please send patches to the 
maintainers for the code you would like to change.  The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev driver

[Lukasz Majewski]

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

Hi Jan,

> On Mon, Oct 01, 2018 at 04:20:32PM +0200, Jan Kundrát wrote:
> 
> > Hi Lukasz,
> > I tried submitting a similar patch for another devicem but got no
> > reaction [1]. In the meanwhile, there has been another proposal [2]
> > which moves  
> 
> As documented in SubmittingPatches please send patches to the 
> maintainers for the code you would like to change. 

I'm using the ./scripts/get_maintainer.py script to obtain list of
relevant people.

Moreover, you may want to look for gitk -- <patch to your modified
file> and add developers, who did some remarkable work in that file.

Also git-blame helps.

And another issue - maitainers are very often very busy (as
maintaining/reviewing is not their main occupation).
We would like to have a prompt response/review, but it is acceptable to
wait week or two for reply.... 


Please also document in the ./Documentation/devicetree the introduced
compatible -> there are some examples (ge,ahca) in the misc directory.

> The normal kernel
> workflow is that people apply patches from their inboxes, if they
> aren't copied they are likely to not see the patch at all and it is
> much more difficult to apply patches.




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev driver

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Tue, Oct 02, 2018 at 10:11:20AM +0200, Lukasz Majewski wrote:

> > As documented in SubmittingPatches please send patches to the 
> > maintainers for the code you would like to change. 

> I'm using the ./scripts/get_maintainer.py script to obtain list of
> relevant people.

Your patch went to the right place (and I applied it yesterday), that
was directed at Jan - the reason his patch got missed is that he didn't
send it to me.

> Please also document in the ./Documentation/devicetree the introduced
> compatible -> there are some examples (ge,ahca) in the misc directory.

Good point.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Applied "spidev: Enable the Liebherr's BK4 board to work with spidev driver" to the spi tree

[Mark Brown]

The patch

   spidev: Enable the Liebherr's BK4 board to work with spidev driver

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 5e9feb3544a72321553d17fcfa0c7e88435ea7ad Mon Sep 17 00:00:00 2001
From: Lukasz Majewski <lukma@denx.de>
Date: Fri, 28 Sep 2018 00:31:52 +0200
Subject: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev
 driver

With this commit the DSPI driver on the BK4 board can be used for SPI
transmission managed from user space (via /dev/spidev0.0).

Example usage/testing:
insmod ./spi-fsl-dspi.ko
./spidev_test -D /dev/spidev0.0 -s 3000000 -v -H -b 8 -p "\xCC\x11\x22\x74"

Signed-off-by: Lukasz Majewski <lukma@denx.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index cda10719d1d1..07f4d05563ea 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -669,6 +669,7 @@ static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "lineartechnology,ltc2488" },
 	{ .compatible = "ge,achc" },
 	{ .compatible = "semtech,sx1301" },
+	{ .compatible = "lwn,bk4" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, spidev_dt_ids);
-- 
2.19.0.rc2

Applied "spidev: Enable the Liebherr's BK4 board to work with spidev driver" to the spi tree

[Mark Brown]

The patch

   spidev: Enable the Liebherr's BK4 board to work with spidev driver

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 5e9feb3544a72321553d17fcfa0c7e88435ea7ad Mon Sep 17 00:00:00 2001
From: Lukasz Majewski <lukma@denx.de>
Date: Fri, 28 Sep 2018 00:31:52 +0200
Subject: [PATCH] spidev: Enable the Liebherr's BK4 board to work with spidev
 driver

With this commit the DSPI driver on the BK4 board can be used for SPI
transmission managed from user space (via /dev/spidev0.0).

Example usage/testing:
insmod ./spi-fsl-dspi.ko
./spidev_test -D /dev/spidev0.0 -s 3000000 -v -H -b 8 -p "\xCC\x11\x22\x74"

Signed-off-by: Lukasz Majewski <lukma@denx.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index cda10719d1d1..07f4d05563ea 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -669,6 +669,7 @@ static const struct of_device_id spidev_dt_ids[] = {
 	{ .compatible = "lineartechnology,ltc2488" },
 	{ .compatible = "ge,achc" },
 	{ .compatible = "semtech,sx1301" },
+	{ .compatible = "lwn,bk4" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, spidev_dt_ids);
-- 
2.19.0.rc2