All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: catalin.marinas@arm.com, will.deacon@arm.com,
	dhowells@redhat.com, vgoyal@redhat.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	dyoung@redhat.com, bhe@redhat.com, arnd@arndb.de,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Cc: prudo@linux.ibm.com, ard.biesheuvel@linaro.org,
	james.morse@arm.com, bhsharma@redhat.com,
	kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	AKASHI Takahiro <takahiro.akashi@linaro.org>
Subject: [PATCH v15 14/16] include: pe.h: remove message[] from mz header definition
Date: Fri, 28 Sep 2018 15:48:39 +0900	[thread overview]
Message-ID: <20180928064841.14117-15-takahiro.akashi@linaro.org> (raw)
In-Reply-To: <20180928064841.14117-1-takahiro.akashi@linaro.org>

message[] field won't be part of the definition of mz header.

This change is crucial for enabling kexec_file_load on arm64 because
arm64's "Image" binary, as in PE format, doesn't have any data for it and
accordingly the following check in pefile_parse_binary() will fail:

	chkaddr(cursor, mz->peaddr, sizeof(*pe));

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
---
 include/linux/pe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pe.h b/include/linux/pe.h
index 143ce75be5f0..3482b18a48b5 100644
--- a/include/linux/pe.h
+++ b/include/linux/pe.h
@@ -166,7 +166,7 @@ struct mz_hdr {
 	uint16_t oem_info;	/* oem specific */
 	uint16_t reserved1[10];	/* reserved */
 	uint32_t peaddr;	/* address of pe header */
-	char     message[64];	/* message to print */
+	char     message[];	/* message to print */
 };
 
 struct mz_reloc {
-- 
2.19.0


WARNING: multiple messages have this Message-ID (diff)
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v15 14/16] include: pe.h: remove message[] from mz header definition
Date: Fri, 28 Sep 2018 15:48:39 +0900	[thread overview]
Message-ID: <20180928064841.14117-15-takahiro.akashi@linaro.org> (raw)
In-Reply-To: <20180928064841.14117-1-takahiro.akashi@linaro.org>

message[] field won't be part of the definition of mz header.

This change is crucial for enabling kexec_file_load on arm64 because
arm64's "Image" binary, as in PE format, doesn't have any data for it and
accordingly the following check in pefile_parse_binary() will fail:

	chkaddr(cursor, mz->peaddr, sizeof(*pe));

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
---
 include/linux/pe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pe.h b/include/linux/pe.h
index 143ce75be5f0..3482b18a48b5 100644
--- a/include/linux/pe.h
+++ b/include/linux/pe.h
@@ -166,7 +166,7 @@ struct mz_hdr {
 	uint16_t oem_info;	/* oem specific */
 	uint16_t reserved1[10];	/* reserved */
 	uint32_t peaddr;	/* address of pe header */
-	char     message[64];	/* message to print */
+	char     message[];	/* message to print */
 };
 
 struct mz_reloc {
-- 
2.19.0

WARNING: multiple messages have this Message-ID (diff)
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: catalin.marinas@arm.com, will.deacon@arm.com,
	dhowells@redhat.com, vgoyal@redhat.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	dyoung@redhat.com, bhe@redhat.com, arnd@arndb.de,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com
Cc: ard.biesheuvel@linaro.org, bhsharma@redhat.com,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	prudo@linux.ibm.com, AKASHI Takahiro <takahiro.akashi@linaro.org>,
	james.morse@arm.com, linux-arm-kernel@lists.infradead.org
Subject: [PATCH v15 14/16] include: pe.h: remove message[] from mz header definition
Date: Fri, 28 Sep 2018 15:48:39 +0900	[thread overview]
Message-ID: <20180928064841.14117-15-takahiro.akashi@linaro.org> (raw)
In-Reply-To: <20180928064841.14117-1-takahiro.akashi@linaro.org>

message[] field won't be part of the definition of mz header.

This change is crucial for enabling kexec_file_load on arm64 because
arm64's "Image" binary, as in PE format, doesn't have any data for it and
accordingly the following check in pefile_parse_binary() will fail:

	chkaddr(cursor, mz->peaddr, sizeof(*pe));

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David S. Miller <davem@davemloft.net>
---
 include/linux/pe.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/pe.h b/include/linux/pe.h
index 143ce75be5f0..3482b18a48b5 100644
--- a/include/linux/pe.h
+++ b/include/linux/pe.h
@@ -166,7 +166,7 @@ struct mz_hdr {
 	uint16_t oem_info;	/* oem specific */
 	uint16_t reserved1[10];	/* reserved */
 	uint32_t peaddr;	/* address of pe header */
-	char     message[64];	/* message to print */
+	char     message[];	/* message to print */
 };
 
 struct mz_reloc {
-- 
2.19.0


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2018-09-28  6:49 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28  6:48 [PATCH v15 00/16] arm64: kexec: add kexec_file_load() support AKASHI Takahiro
2018-09-28  6:48 ` AKASHI Takahiro
2018-09-28  6:48 ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 01/16] asm-generic: add kexec_file_load system call to unistd.h AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 02/16] kexec_file: make kexec_image_post_load_cleanup_default() global AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 03/16] s390, kexec_file: drop arch_kexec_mem_walk() AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 04/16] powerpc, kexec_file: factor out memblock-based arch_kexec_walk_mem() AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-30 10:08   ` Dave Young
2018-09-30 10:08     ` Dave Young
2018-09-30 10:08     ` Dave Young
2018-10-02  6:20     ` AKASHI Takahiro
2018-10-02  6:20       ` AKASHI Takahiro
2018-10-02  6:20       ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 05/16] kexec_file: kexec_walk_memblock() only walks a dedicated region at kdump AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-30 10:10   ` Dave Young
2018-09-30 10:10     ` Dave Young
2018-09-30 10:10     ` Dave Young
2018-09-28  6:48 ` [PATCH v15 06/16] of/fdt: add helper functions for handling properties AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  9:04   ` kbuild test robot
2018-09-28  9:04     ` kbuild test robot
2018-09-28  9:04     ` kbuild test robot
2018-09-28  9:04     ` kbuild test robot
2018-09-28 13:44   ` Rob Herring
2018-09-28 13:44     ` Rob Herring
2018-09-28 13:44     ` Rob Herring
2018-09-28 13:44     ` Rob Herring
2018-09-28 21:13     ` Frank Rowand
2018-09-28 21:13       ` Frank Rowand
2018-09-28 21:13       ` Frank Rowand
2018-09-28 21:13       ` Frank Rowand
2018-10-05  5:06       ` AKASHI, Takahiro
2018-10-05  5:06         ` AKASHI, Takahiro
2018-10-05  5:06         ` AKASHI, Takahiro
2018-10-05  5:06         ` AKASHI, Takahiro
2018-10-05  5:09         ` David Gibson
2018-10-05  5:09           ` David Gibson
2018-10-05  5:09           ` David Gibson
2018-10-05  5:09           ` David Gibson
2018-10-09 18:02         ` Frank Rowand
2018-10-09 18:02           ` Frank Rowand
2018-10-09 18:02           ` Frank Rowand
2018-10-09 18:02           ` Frank Rowand
2018-10-10  0:30           ` David Gibson
2018-10-10  0:30             ` David Gibson
2018-10-10  0:30             ` David Gibson
2018-10-10  0:30             ` David Gibson
2018-10-10  1:04           ` AKASHI, Takahiro
2018-10-10  1:04             ` AKASHI, Takahiro
2018-10-10  1:04             ` AKASHI, Takahiro
2018-10-10  1:04             ` AKASHI, Takahiro
2018-10-02  4:47     ` David Gibson
2018-10-02  4:47       ` David Gibson
2018-10-02  4:47       ` David Gibson
2018-10-02  4:47       ` David Gibson
2018-10-02  9:04       ` AKASHI, Takahiro
2018-10-02  9:04         ` AKASHI, Takahiro
2018-10-02  9:04         ` AKASHI, Takahiro
2018-10-02  9:04         ` AKASHI, Takahiro
2018-10-05  3:08     ` AKASHI, Takahiro
2018-10-05  3:08       ` AKASHI, Takahiro
2018-10-05  3:08       ` AKASHI, Takahiro
2018-10-05 13:23       ` Rob Herring
2018-10-05 13:23         ` Rob Herring
2018-10-05 13:23         ` Rob Herring
2018-10-05 13:23         ` Rob Herring
2018-10-09  0:37         ` AKASHI, Takahiro
2018-10-09  0:37           ` AKASHI, Takahiro
2018-10-09  0:37           ` AKASHI, Takahiro
2018-10-09  0:37           ` AKASHI, Takahiro
2018-10-09 17:47           ` Frank Rowand
2018-10-09 17:47             ` Frank Rowand
2018-10-09 17:47             ` Frank Rowand
2018-10-09 17:47             ` Frank Rowand
2018-10-10  1:14             ` AKASHI, Takahiro
2018-10-10  1:14               ` AKASHI, Takahiro
2018-10-10  1:14               ` AKASHI, Takahiro
2018-10-10  1:14               ` AKASHI, Takahiro
2018-10-10  2:44               ` Frank Rowand
2018-10-10  2:44                 ` Frank Rowand
2018-10-10  2:44                 ` Frank Rowand
2018-10-10  2:44                 ` Frank Rowand
2018-09-28  6:48 ` [PATCH v15 07/16] arm64: add image head flag definitions AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-10-01 12:52   ` Mark Rutland
2018-10-01 12:52     ` Mark Rutland
2018-10-01 12:52     ` Mark Rutland
2018-10-02  7:59     ` AKASHI Takahiro
2018-10-02  7:59       ` AKASHI Takahiro
2018-10-02  7:59       ` AKASHI Takahiro
2018-10-09 15:04       ` Mark Rutland
2018-10-09 15:04         ` Mark Rutland
2018-10-09 15:04         ` Mark Rutland
2018-10-10  1:59         ` AKASHI Takahiro
2018-10-10  1:59           ` AKASHI Takahiro
2018-10-10  1:59           ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 08/16] arm64: cpufeature: add MMFR0 helper functions AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 09/16] arm64: enable KEXEC_FILE config AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 10/16] arm64: kexec_file: load initrd and device-tree AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 11/16] arm64: kexec_file: allow for loading Image-format kernel AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-10-09 15:28   ` Mark Rutland
2018-10-09 15:28     ` Mark Rutland
2018-10-09 15:28     ` Mark Rutland
2018-10-10  6:52     ` AKASHI Takahiro
2018-10-10  6:52       ` AKASHI Takahiro
2018-10-10  6:52       ` AKASHI Takahiro
2018-10-10  9:47       ` Mark Rutland
2018-10-10  9:47         ` Mark Rutland
2018-10-10  9:47         ` Mark Rutland
2018-09-28  6:48 ` [PATCH v15 12/16] arm64: kexec_file: add crash dump support AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 13/16] arm64: kexec_file: invoke the kernel without purgatory AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` AKASHI Takahiro [this message]
2018-09-28  6:48   ` [PATCH v15 14/16] include: pe.h: remove message[] from mz header definition AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 15/16] arm64: kexec_file: add kernel signature verification support AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48 ` [PATCH v15 16/16] arm64: kexec_file: add kaslr support AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro
2018-09-28  6:48   ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928064841.14117-15-takahiro.akashi@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bhe@redhat.com \
    --cc=bhsharma@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=james.morse@arm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prudo@linux.ibm.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=vgoyal@redhat.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.