All of lore.kernel.org
 help / color / mirror / Atom feed
From: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: [PATCH 3/7] drm/i915/icl: Implement Display WA_1405510057
Date: Fri, 28 Sep 2018 09:47:34 -0700	[thread overview]
Message-ID: <20180928164738.9756-3-radhakrishna.sripada@intel.com> (raw)
In-Reply-To: <20180928164738.9756-1-radhakrishna.sripada@intel.com>

Display WA_1405510057 asks to not enable YUV 420 HDMI
10bpc when horizontal blank size mod 8 reminder is 2.

Cc: James Ausmus <james.ausmus@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index a2dab0b6bde6..569583232d0b 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -1597,6 +1597,8 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
 	struct drm_atomic_state *state = crtc_state->base.state;
 	struct drm_connector_state *connector_state;
 	struct drm_connector *connector;
+	const struct drm_display_mode *adjusted_mode =
+		&crtc_state->base.adjusted_mode;
 	int i;
 
 	if (HAS_GMCH_DISPLAY(dev_priv))
@@ -1645,7 +1647,13 @@ static bool hdmi_deep_color_possible(const struct intel_crtc_state *crtc_state,
 
 	/* Display WA #1139: glk */
 	if (bpc == 12 && IS_GLK_REVID(dev_priv, 0, GLK_REVID_A1) &&
-	    crtc_state->base.adjusted_mode.htotal > 5460)
+	    adjusted_mode->htotal > 5460)
+		return false;
+
+	/* Display Wa_1405510057:icl */
+	if (crtc_state->ycbcr420 && bpc == 10 && IS_ICELAKE(dev_priv) &&
+	    (adjusted_mode->crtc_hblank_end -
+	     adjusted_mode->crtc_hblank_start) % 8 == 2)
 		return false;
 
 	return true;
-- 
2.9.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-09-28 16:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 16:47 [PATCH 1/7] drm/i915/icl: Add WaEnable32PlaneMode Radhakrishna Sripada
2018-09-28 16:47 ` [PATCH 2/7] drm/i915/icl: apply Display WA #1178 to fix type C dongles Radhakrishna Sripada
2018-09-28 16:47 ` Radhakrishna Sripada [this message]
2018-09-28 16:47 ` [PATCH 4/7] drm/i915/icl: WaSendPushConstantsFromMMIO Radhakrishna Sripada
2018-09-28 16:53   ` Chris Wilson
2018-10-01 10:40     ` Mika Kuoppala
2018-10-01 10:48   ` Joonas Lahtinen
2018-09-28 16:47 ` [PATCH 5/7] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken2 Radhakrishna Sripada
2018-09-28 16:53   ` Chris Wilson
2018-09-28 16:47 ` [PATCH 6/7] drm/i915/icl: WaAllowUMDToModifyHalfSliceChicken7 Radhakrishna Sripada
2018-09-28 16:47 ` [PATCH 7/7] drm/i915/icl: Add Wa_1406609255 Radhakrishna Sripada
2018-09-28 22:19   ` Anuj Phogat
2018-10-01 10:36   ` Mika Kuoppala
2018-10-01 11:05   ` Mika Kuoppala
2018-09-28 16:51 ` [PATCH 1/7] drm/i915/icl: Add WaEnable32PlaneMode Chris Wilson
2018-10-01 11:52 ` ✓ Fi.CI.BAT: success for series starting with [1/7] " Patchwork
2018-10-01 13:15 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928164738.9756-3-radhakrishna.sripada@intel.com \
    --to=radhakrishna.sripada@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.