All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] gpio: omap: Remove set but not used variable 'dev'
@ 2018-09-28  2:17 YueHaibing
  2018-09-28 16:50 ` Tony Lindgren
  2018-10-01 11:25 ` Linus Walleij
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-09-28  2:17 UTC (permalink / raw)
  To: kernel-janitors

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpio/gpio-omap.c: In function 'gpio_omap_cpu_notifier':
drivers/gpio/gpio-omap.c:1327:17: warning:
 variable 'dev' set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpio/gpio-omap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index c0d7ae7..e67d612 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1324,11 +1324,9 @@ static int gpio_omap_cpu_notifier(struct notifier_block *nb,
 				  unsigned long cmd, void *v)
 {
 	struct gpio_bank *bank;
-	struct device *dev;
 	unsigned long flags;
 
 	bank = container_of(nb, struct gpio_bank, nb);
-	dev = bank->chip.parent;
 
 	raw_spin_lock_irqsave(&bank->lock, flags);
 	switch (cmd) {

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] gpio: omap: Remove set but not used variable 'dev'
  2018-09-28  2:17 [PATCH -next] gpio: omap: Remove set but not used variable 'dev' YueHaibing
@ 2018-09-28 16:50 ` Tony Lindgren
  2018-10-01 11:25 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2018-09-28 16:50 UTC (permalink / raw)
  To: kernel-janitors

* YueHaibing <yuehaibing@huawei.com> [180928 02:13]:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/gpio/gpio-omap.c: In function 'gpio_omap_cpu_notifier':
> drivers/gpio/gpio-omap.c:1327:17: warning:
>  variable 'dev' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thanks for noticing this:

Acked-by: Tony Lindgren <tony@atomide.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] gpio: omap: Remove set but not used variable 'dev'
  2018-09-28  2:17 [PATCH -next] gpio: omap: Remove set but not used variable 'dev' YueHaibing
  2018-09-28 16:50 ` Tony Lindgren
@ 2018-10-01 11:25 ` Linus Walleij
  1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2018-10-01 11:25 UTC (permalink / raw)
  To: kernel-janitors

On Fri, Sep 28, 2018 at 4:08 AM YueHaibing <yuehaibing@huawei.com> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpio/gpio-omap.c: In function 'gpio_omap_cpu_notifier':
> drivers/gpio/gpio-omap.c:1327:17: warning:
>  variable 'dev' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Patch applied with Tony's ACK.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-01 11:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28  2:17 [PATCH -next] gpio: omap: Remove set but not used variable 'dev' YueHaibing
2018-09-28 16:50 ` Tony Lindgren
2018-10-01 11:25 ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.