[PATCH 0/4] Add RZ/G1C and RZ/G1N I2C related support

[PATCH 0/4] Add RZ/G1C and RZ/G1N I2C related support

[Fabrizio Castro]

Dear All,

this series documents the I2C controllers found in the RZ/G1C and
RZ/G1N, and also adds I2C4 support to the RZ/G1C SoC specific dtsi.

Thanks,
Fab

Biju Das (2):
  dt-bindings: i2c: rcar: Document r8a7744 support
  dt-bindings: i2c: sh_mobile: Document r8a7744 support

Fabrizio Castro (2):
  dt-bindings: i2c: rcar: Add r8a77470 support
  ARM: dts: r8a77470: Add I2C4 support

 Documentation/devicetree/bindings/i2c/i2c-rcar.txt      |  2 ++
 Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt |  1 +
 arch/arm/boot/dts/r8a77470.dtsi                         | 14 ++++++++++++++
 3 files changed, 17 insertions(+)

-- 
2.7.4

[PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support

[Fabrizio Castro]

Although the I2C IP found in the RZ/G1C is not exactly the same
as the one found in the R-Car Gen2 family or R-Car Gen3 family,
it can still be considered as compatible with R-Car Gen2 from
a software perpective.
This patch therefore documents the SoC specific compatible string,
and the compatibility with Gen2 fallback is retained.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
index 39cd21d..671e2a1 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
@@ -4,6 +4,7 @@ Required properties:
 - compatible:
 	"renesas,i2c-r8a7743" if the device is a part of a R8A7743 SoC.
 	"renesas,i2c-r8a7745" if the device is a part of a R8A7745 SoC.
+	"renesas,i2c-r8a77470" if the device is a part of a R8A77470 SoC.
 	"renesas,i2c-r8a774a1" if the device is a part of a R8A774A1 SoC.
 	"renesas,i2c-r8a7778" if the device is a part of a R8A7778 SoC.
 	"renesas,i2c-r8a7779" if the device is a part of a R8A7779 SoC.
-- 
2.7.4

[PATCH 2/4] dt-bindings: i2c: rcar: Document r8a7744 support

[Fabrizio Castro]

From: Biju Das <biju.das@bp.renesas.com>

Document i2c Device Tree support for RZ/G1N (R8A7744) SoC, which is
compatible with R-Car Gen2 SoC family.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
index 671e2a1..30c0485 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
@@ -3,6 +3,7 @@ I2C for R-Car platforms
 Required properties:
 - compatible:
 	"renesas,i2c-r8a7743" if the device is a part of a R8A7743 SoC.
+	"renesas,i2c-r8a7744" if the device is a part of a R8A7744 SoC.
 	"renesas,i2c-r8a7745" if the device is a part of a R8A7745 SoC.
 	"renesas,i2c-r8a77470" if the device is a part of a R8A77470 SoC.
 	"renesas,i2c-r8a774a1" if the device is a part of a R8A774A1 SoC.
-- 
2.7.4

[PATCH 3/4] dt-bindings: i2c: sh_mobile: Document r8a7744 support

[Fabrizio Castro]

From: Biju Das <biju.das@bp.renesas.com>

Document i2c Device Tree support for RZ/G1N (R8A7744) SoC, which is
compatible with R-Car Gen2 SoC family.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
index 872673a..d81b626 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
@@ -5,6 +5,7 @@ Required properties:
 			- "renesas,iic-r8a73a4" (R-Mobile APE6)
 			- "renesas,iic-r8a7740" (R-Mobile A1)
 			- "renesas,iic-r8a7743" (RZ/G1M)
+			- "renesas,iic-r8a7744" (RZ/G1N)
 			- "renesas,iic-r8a7745" (RZ/G1E)
 			- "renesas,iic-r8a774a1" (RZ/G2M)
 			- "renesas,iic-r8a7790" (R-Car H2)
-- 
2.7.4

[PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

[Fabrizio Castro]

Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
device tree.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm/boot/dts/r8a77470.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 9e7f86d..9ec78d3 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -237,6 +237,20 @@
 			reg = <0 0xe6300000 0 0x20000>;
 		};
 
+		i2c4: i2c@e6520000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			compatible = "renesas,i2c-r8a77470",
+				     "renesas,rcar-gen2-i2c";
+			reg = <0 0xe6520000 0 0x40>;
+			interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 927>;
+			power-domains = <&sysc R8A77470_PD_ALWAYS_ON>;
+			resets = <&cpg 927>;
+			i2c-scl-internal-delay-ns = <6>;
+			status = "disabled";
+		};
+
 		dmac0: dma-controller@e6700000 {
 			compatible = "renesas,dmac-r8a77470",
 				     "renesas,rcar-dmac";
-- 
2.7.4

Re: [PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

On Fri, Sep 21, 2018 at 06:37:01PM +0100, Fabrizio Castro wrote:
> Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> device tree.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Looks sane to me

Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/4] dt-bindings: i2c: rcar: Document r8a7744 support

[Simon Horman]

On Fri, Sep 21, 2018 at 06:36:59PM +0100, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
> 
> Document i2c Device Tree support for RZ/G1N (R8A7744) SoC, which is
> compatible with R-Car Gen2 SoC family.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> index 671e2a1..30c0485 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> @@ -3,6 +3,7 @@ I2C for R-Car platforms
>  Required properties:
>  - compatible:
>  	"renesas,i2c-r8a7743" if the device is a part of a R8A7743 SoC.
> +	"renesas,i2c-r8a7744" if the device is a part of a R8A7744 SoC.
>  	"renesas,i2c-r8a7745" if the device is a part of a R8A7745 SoC.
>  	"renesas,i2c-r8a77470" if the device is a part of a R8A77470 SoC.
>  	"renesas,i2c-r8a774a1" if the device is a part of a R8A774A1 SoC.
> -- 
> 2.7.4
> 

Re: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support

[Simon Horman]

On Fri, Sep 21, 2018 at 06:36:58PM +0100, Fabrizio Castro wrote:
> Although the I2C IP found in the RZ/G1C is not exactly the same
> as the one found in the R-Car Gen2 family or R-Car Gen3 family,
> it can still be considered as compatible with R-Car Gen2 from
> a software perpective.
> This patch therefore documents the SoC specific compatible string,
> and the compatibility with Gen2 fallback is retained.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> index 39cd21d..671e2a1 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> @@ -4,6 +4,7 @@ Required properties:
>  - compatible:
>  	"renesas,i2c-r8a7743" if the device is a part of a R8A7743 SoC.
>  	"renesas,i2c-r8a7745" if the device is a part of a R8A7745 SoC.
> +	"renesas,i2c-r8a77470" if the device is a part of a R8A77470 SoC.

It seems to me that the RZ/G1C has some extra registers described for
I2C when compared with both other RZ/G1 and R-Car Gen2 SoCs.

Am I correct in assuming that operation is correct for the RZ/G1C
when using the fallback compat string for RZ/G1 and R-Car Gen2 SoCs?

And that, speculating wildly, in future it may be possible for
the driver to use these extra resgisters, f.e. by via a match on
the renesas,i2c-r8a77470 compat string?

>  	"renesas,i2c-r8a774a1" if the device is a part of a R8A774A1 SoC.
>  	"renesas,i2c-r8a7778" if the device is a part of a R8A7778 SoC.
>  	"renesas,i2c-r8a7779" if the device is a part of a R8A7779 SoC.
> -- 
> 2.7.4
> 

Re: [PATCH 3/4] dt-bindings: i2c: sh_mobile: Document r8a7744 support

[Simon Horman]

On Fri, Sep 21, 2018 at 06:37:00PM +0100, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
> 
> Document i2c Device Tree support for RZ/G1N (R8A7744) SoC, which is
> compatible with R-Car Gen2 SoC family.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> index 872673a..d81b626 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt
> @@ -5,6 +5,7 @@ Required properties:
>  			- "renesas,iic-r8a73a4" (R-Mobile APE6)
>  			- "renesas,iic-r8a7740" (R-Mobile A1)
>  			- "renesas,iic-r8a7743" (RZ/G1M)
> +			- "renesas,iic-r8a7744" (RZ/G1N)
>  			- "renesas,iic-r8a7745" (RZ/G1E)
>  			- "renesas,iic-r8a774a1" (RZ/G2M)
>  			- "renesas,iic-r8a7790" (R-Car H2)
> -- 
> 2.7.4
> 

Re: [PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

[Simon Horman]

On Sat, Sep 22, 2018 at 08:39:29PM +0200, Wolfram Sang wrote:
> On Fri, Sep 21, 2018 at 06:37:01PM +0100, Fabrizio Castro wrote:
> > Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> > device tree.
> > 
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> 
> Looks sane to me
> 
> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Likewise, but I'd like some feedback on my comment on patch 1/4
before applying this.

RE: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support

[Fabrizio Castro]

Hello Simon,

Thank you for the feedback.

> Subject: Re: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support
>
> On Fri, Sep 21, 2018 at 06:36:58PM +0100, Fabrizio Castro wrote:
> > Although the I2C IP found in the RZ/G1C is not exactly the same
> > as the one found in the R-Car Gen2 family or R-Car Gen3 family,
> > it can still be considered as compatible with R-Car Gen2 from
> > a software perpective.
> > This patch therefore documents the SoC specific compatible string,
> > and the compatibility with Gen2 fallback is retained.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> > index 39cd21d..671e2a1 100644
> > --- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> > +++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> > @@ -4,6 +4,7 @@ Required properties:
> >  - compatible:
> >  "renesas,i2c-r8a7743" if the device is a part of a R8A7743 SoC.
> >  "renesas,i2c-r8a7745" if the device is a part of a R8A7745 SoC.
> > +"renesas,i2c-r8a77470" if the device is a part of a R8A77470 SoC.
>
> It seems to me that the RZ/G1C has some extra registers described for
> I2C when compared with both other RZ/G1 and R-Car Gen2 SoCs.

Exactly. The extra registers found with the RZ/G1C I2C controller are also found in R-Car Gen3,
but the driver doesn't handle them. R-Car Gen3 has more registers on top of those found
with the RZ/G1C.

>
> Am I correct in assuming that operation is correct for the RZ/G1C
> when using the fallback compat string for RZ/G1 and R-Car Gen2 SoCs?

Since the driver is not using ICCCR2, ICMPR, ICHPR, and ICLPR, what's left is compatible
with R-Car Gen2.
I have tested I2C4 on its own and with the HDMI transmitter found on the iwg23s, and
so far so good.

>
> And that, speculating wildly, in future it may be possible for
> the driver to use these extra resgisters, f.e. by via a match on
> the renesas,i2c-r8a77470 compat string?

Exactly. If anybody ever looks into supporting the missing functionality the SoC
specific string could be used to pick up better driver support (although Gen2
support would probably still be alright).

I hope this clarifies things a little bit better.

Thanks,
Fab

>
> >  "renesas,i2c-r8a774a1" if the device is a part of a R8A774A1 SoC.
> >  "renesas,i2c-r8a7778" if the device is a part of a R8A7778 SoC.
> >  "renesas,i2c-r8a7779" if the device is a part of a R8A7779 SoC.
> > --
> > 2.7.4
> >



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 2/4] dt-bindings: i2c: rcar: Document r8a7744 support

[Geert Uytterhoeven]

On Fri, Sep 21, 2018 at 7:37 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Document i2c Device Tree support for RZ/G1N (R8A7744) SoC, which is
> compatible with R-Car Gen2 SoC family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/4] dt-bindings: i2c: sh_mobile: Document r8a7744 support

[Geert Uytterhoeven]

On Fri, Sep 21, 2018 at 7:37 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> From: Biju Das <biju.das@bp.renesas.com>
>
> Document i2c Device Tree support for RZ/G1N (R8A7744) SoC, which is
> compatible with R-Car Gen2 SoC family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

[Geert Uytterhoeven]

On Fri, Sep 21, 2018 at 7:37 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> device tree.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support

[Simon Horman]

On Mon, Sep 24, 2018 at 09:10:53AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Thank you for the feedback.
> 
> > Subject: Re: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support
> >
> > On Fri, Sep 21, 2018 at 06:36:58PM +0100, Fabrizio Castro wrote:
> > > Although the I2C IP found in the RZ/G1C is not exactly the same
> > > as the one found in the R-Car Gen2 family or R-Car Gen3 family,
> > > it can still be considered as compatible with R-Car Gen2 from
> > > a software perpective.
> > > This patch therefore documents the SoC specific compatible string,
> > > and the compatibility with Gen2 fallback is retained.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > > ---
> > >  Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> > > index 39cd21d..671e2a1 100644
> > > --- a/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> > > +++ b/Documentation/devicetree/bindings/i2c/i2c-rcar.txt
> > > @@ -4,6 +4,7 @@ Required properties:
> > >  - compatible:
> > >  "renesas,i2c-r8a7743" if the device is a part of a R8A7743 SoC.
> > >  "renesas,i2c-r8a7745" if the device is a part of a R8A7745 SoC.
> > > +"renesas,i2c-r8a77470" if the device is a part of a R8A77470 SoC.
> >
> > It seems to me that the RZ/G1C has some extra registers described for
> > I2C when compared with both other RZ/G1 and R-Car Gen2 SoCs.
> 
> Exactly. The extra registers found with the RZ/G1C I2C controller are also found in R-Car Gen3,
> but the driver doesn't handle them. R-Car Gen3 has more registers on top of those found
> with the RZ/G1C.
> 
> >
> > Am I correct in assuming that operation is correct for the RZ/G1C
> > when using the fallback compat string for RZ/G1 and R-Car Gen2 SoCs?
> 
> Since the driver is not using ICCCR2, ICMPR, ICHPR, and ICLPR, what's left is compatible
> with R-Car Gen2.
> I have tested I2C4 on its own and with the HDMI transmitter found on the iwg23s, and
> so far so good.
> 
> >
> > And that, speculating wildly, in future it may be possible for
> > the driver to use these extra resgisters, f.e. by via a match on
> > the renesas,i2c-r8a77470 compat string?
> 
> Exactly. If anybody ever looks into supporting the missing functionality the SoC
> specific string could be used to pick up better driver support (although Gen2
> support would probably still be alright).
> 
> I hope this clarifies things a little bit better.

Thanks, it helps a lot.

Re: [PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

[Simon Horman]

On Mon, Sep 24, 2018 at 11:04:39AM +0200, Simon Horman wrote:
> On Sat, Sep 22, 2018 at 08:39:29PM +0200, Wolfram Sang wrote:
> > On Fri, Sep 21, 2018 at 06:37:01PM +0100, Fabrizio Castro wrote:
> > > Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> > > device tree.
> > > 
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > 
> > Looks sane to me
> > 
> > Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Likewise, but I'd like some feedback on my comment on patch 1/4
> before applying this.

Thanks for the feedback on patch 1/4.
I have queued this patch up for v4.20.

On Mon, Sep 24, 2018 at 11:58:15AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 21, 2018 at 7:37 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> > device tree.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Re: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]


> > It seems to me that the RZ/G1C has some extra registers described
> > for I2C when compared with both other RZ/G1 and R-Car Gen2 SoCs.
> 
> Exactly. The extra registers found with the RZ/G1C I2C controller are
> also found in R-Car Gen3, but the driver doesn't handle them. R-Car
> Gen3 has more registers on top of those found with the RZ/G1C.

I don't have he RZ documentation yet, could you name which ones are Gen3
only?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support

[Geert Uytterhoeven]

Hi Wolfram,

On Mon, Sep 24, 2018 at 5:52 PM Wolfram Sang <wsa@the-dreams.de> wrote:
> > > It seems to me that the RZ/G1C has some extra registers described
> > > for I2C when compared with both other RZ/G1 and R-Car Gen2 SoCs.
> >
> > Exactly. The extra registers found with the RZ/G1C I2C controller are
> > also found in R-Car Gen3, but the driver doesn't handle them. R-Car
> > Gen3 has more registers on top of those found with the RZ/G1C.
>
> I don't have he RZ documentation yet, could you name which ones are Gen3
> only?

https://www.renesas.com/eu/en/search/keyword-search.html#q=RZ%2FG1

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support

[Fabrizio Castro]

Hello Wolfram,

> Subject: Re: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support
>
>
> > > It seems to me that the RZ/G1C has some extra registers described
> > > for I2C when compared with both other RZ/G1 and R-Car Gen2 SoCs.
> >
> > Exactly. The extra registers found with the RZ/G1C I2C controller are
> > also found in R-Car Gen3, but the driver doesn't handle them. R-Car
> > Gen3 has more registers on top of those found with the RZ/G1C.
>
> I don't have he RZ documentation yet, could you name which ones are Gen3
> only?

ICDMAER and ICFBSCR are the registers found in R-Car Gen3 but not in RZ/G1C.

Thanks,
Fab




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 1/4] dt-bindings: i2c: rcar: Add r8a77470 support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

On Fri, Sep 21, 2018 at 06:36:58PM +0100, Fabrizio Castro wrote:
> Although the I2C IP found in the RZ/G1C is not exactly the same
> as the one found in the R-Car Gen2 family or R-Car Gen3 family,
> it can still be considered as compatible with R-Car Gen2 from
> a software perpective.
> This patch therefore documents the SoC specific compatible string,
> and the compatibility with Gen2 fallback is retained.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/4] dt-bindings: i2c: rcar: Document r8a7744 support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

On Fri, Sep 21, 2018 at 06:36:59PM +0100, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
> 
> Document i2c Device Tree support for RZ/G1N (R8A7744) SoC, which is
> compatible with R-Car Gen2 SoC family.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 3/4] dt-bindings: i2c: sh_mobile: Document r8a7744 support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

On Fri, Sep 21, 2018 at 06:37:00PM +0100, Fabrizio Castro wrote:
> From: Biju Das <biju.das@bp.renesas.com>
> 
> Document i2c Device Tree support for RZ/G1N (R8A7744) SoC, which is
> compatible with R-Car Gen2 SoC family.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]