From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: jun qian <hangdianqj@163.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Barry song <21cnbao@gmail.com>, Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr
Date: Mon, 1 Oct 2018 10:52:12 +0200 [thread overview]
Message-ID: <20181001085212.wu7eba4eh7koy5jx@pengutronix.de> (raw)
In-Reply-To: <20180827144904.17226-1-hangdianqj@163.com>
Hello,
On Mon, Aug 27, 2018 at 07:49:04AM -0700, jun qian wrote:
> Before the program enters the uart ISR, the local interrupt has been
> disabled by the system, so it's not appropriate to use spin_lock_irqsave
> interface in the ISR.
"not appropriate" is a bit strong. It's not as optimal as it could be
though, yes.
The change is fine,
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-10-01 8:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 14:49 [PATCH] tty:serial:imx: use spin_lock instead of spin_lock_irqsave in isr jun qian
2018-08-28 8:36 ` Barry Song
2018-10-01 8:52 ` Uwe Kleine-König [this message]
[not found] ` <5205c4b4.20a1.166326bb238.Coremail.hangdianqj@163.com>
2018-10-02 20:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001085212.wu7eba4eh7koy5jx@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=21cnbao@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hangdianqj@163.com \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.