* [PATCH] arm64: remove unused asm/compiler.h header file
@ 2018-09-27 13:07 Ard Biesheuvel
2018-10-01 9:48 ` Will Deacon
2018-10-01 10:58 ` Catalin Marinas
0 siblings, 2 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-09-27 13:07 UTC (permalink / raw)
To: linux-arm-kernel
arm64 does not define CONFIG_HAVE_ARCH_COMPILER_H, nor does it keep
anything useful in its copy of asm/compiler.h, so let's remove it
before anybody starts using it.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
arch/arm64/include/asm/compiler.h | 30 ------------------------------
arch/arm64/include/asm/sysreg.h | 1 -
arch/arm64/include/asm/uaccess.h | 1 -
arch/arm64/kernel/psci.c | 1 -
4 files changed, 33 deletions(-)
delete mode 100644 arch/arm64/include/asm/compiler.h
diff --git a/arch/arm64/include/asm/compiler.h b/arch/arm64/include/asm/compiler.h
deleted file mode 100644
index ee35fd0f2236..000000000000
--- a/arch/arm64/include/asm/compiler.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Based on arch/arm/include/asm/compiler.h
- *
- * Copyright (C) 2012 ARM Ltd.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see <http://www.gnu.org/licenses/>.
- */
-#ifndef __ASM_COMPILER_H
-#define __ASM_COMPILER_H
-
-/*
- * This is used to ensure the compiler did actually allocate the register we
- * asked it for some inline assembly sequences. Apparently we can't trust the
- * compiler from one version to another so a bit of paranoia won't hurt. This
- * string is meant to be concatenated with the inline asm string and will
- * cause compilation to stop on mismatch. (for details, see gcc PR 15089)
- */
-#define __asmeq(x, y) ".ifnc " x "," y " ; .err ; .endif\n\t"
-
-#endif /* __ASM_COMPILER_H */
diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h
index c1470931b897..6d307212bf7c 100644
--- a/arch/arm64/include/asm/sysreg.h
+++ b/arch/arm64/include/asm/sysreg.h
@@ -20,7 +20,6 @@
#ifndef __ASM_SYSREG_H
#define __ASM_SYSREG_H
-#include <asm/compiler.h>
#include <linux/stringify.h>
/*
diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h
index e66b0fca99c2..07c34087bd5e 100644
--- a/arch/arm64/include/asm/uaccess.h
+++ b/arch/arm64/include/asm/uaccess.h
@@ -32,7 +32,6 @@
#include <asm/cpufeature.h>
#include <asm/ptrace.h>
#include <asm/memory.h>
-#include <asm/compiler.h>
#include <asm/extable.h>
#define get_ds() (KERNEL_DS)
diff --git a/arch/arm64/kernel/psci.c b/arch/arm64/kernel/psci.c
index e8edbf13302a..8cdaf25e99cd 100644
--- a/arch/arm64/kernel/psci.c
+++ b/arch/arm64/kernel/psci.c
@@ -24,7 +24,6 @@
#include <uapi/linux/psci.h>
-#include <asm/compiler.h>
#include <asm/cpu_ops.h>
#include <asm/errno.h>
#include <asm/smp_plat.h>
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] arm64: remove unused asm/compiler.h header file
2018-09-27 13:07 [PATCH] arm64: remove unused asm/compiler.h header file Ard Biesheuvel
@ 2018-10-01 9:48 ` Will Deacon
2018-10-01 10:58 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2018-10-01 9:48 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 27, 2018 at 03:07:37PM +0200, Ard Biesheuvel wrote:
> arm64 does not define CONFIG_HAVE_ARCH_COMPILER_H, nor does it keep
> anything useful in its copy of asm/compiler.h, so let's remove it
> before anybody starts using it.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm64/include/asm/compiler.h | 30 ------------------------------
> arch/arm64/include/asm/sysreg.h | 1 -
> arch/arm64/include/asm/uaccess.h | 1 -
> arch/arm64/kernel/psci.c | 1 -
> 4 files changed, 33 deletions(-)
> delete mode 100644 arch/arm64/include/asm/compiler.h
Acked-by: Will Deacon <will.deacon@arm.com>
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] arm64: remove unused asm/compiler.h header file
2018-09-27 13:07 [PATCH] arm64: remove unused asm/compiler.h header file Ard Biesheuvel
2018-10-01 9:48 ` Will Deacon
@ 2018-10-01 10:58 ` Catalin Marinas
1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2018-10-01 10:58 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 27, 2018 at 03:07:37PM +0200, Ard Biesheuvel wrote:
> arm64 does not define CONFIG_HAVE_ARCH_COMPILER_H, nor does it keep
> anything useful in its copy of asm/compiler.h, so let's remove it
> before anybody starts using it.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Queued for 4.20. Thanks.
--
Catalin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-01 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 13:07 [PATCH] arm64: remove unused asm/compiler.h header file Ard Biesheuvel
2018-10-01 9:48 ` Will Deacon
2018-10-01 10:58 ` Catalin Marinas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.