[U-Boot] [PATCH v12 1/8] dm: drop unused helper in MTD header

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v12 1/8] dm: drop unused helper in MTD header
Date: Mon, 1 Oct 2018 15:40:44 +0200	[thread overview]
Message-ID: <20181001154044.3dcb3680@xps13> (raw)
In-Reply-To: <CAMty3ZBYSgCUxd_SVCtqe3fzJxoi8nxCwKAqPjqRkazn3a1xmg@mail.gmail.com>

Hi Jagan,

Jagan Teki <jagan@amarulasolutions.com> wrote on Mon, 1 Oct 2018
17:08:30 +0530:

> On Mon, Oct 1, 2018 at 3:32 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Jagan,
> >
> > Jagan Teki <jagan@amarulasolutions.com> wrote on Mon, 1 Oct 2018
> > 15:23:46 +0530:
> >  
> > > On Sat, Sep 29, 2018 at 4:29 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:  
> > > >
> > > > include/mtd.h might be included by files even if CONFIG_DM is not
> > > > enabled. In this case, the call to dev_get_uclass_priv() would trigger
> > > > a build error. Because this helper has no user, let's drop it off.  
> > >
> > > Why would they use DM include file w/o using it? we need to fix in those places.  
> >
> > There was no user of include/mtd.h not using CONFIG_DM.
> >
> > But now I am creating cmd/mtd.c which should work with both CONFIG_DM
> > and no CONFIG_DM support. So include/mtd.h has reasons to be included.  
> 
> Then use ifdef CONFIG_MTD on the same file so it can arrange dm and
> non-dm include at one place.

The helper is not used, why do we keep it?

Simon Glass and Tom Rini are trying to reduce as much as possible the
number of pre-processor conditionals to have as much test coverage as
they can. What you ask clearly goes into the opposite direction.

Anyway, I want this work merged so I dropped the patch, enclosed the
definitions from include/mtd.h into a #if defined(CONFIG_DM) block and
wrote dummy helpers for them. These changes are done when
include/mtd.h gets included from cmd/mtd.c which is the file that can
be compiled with and without DM support, see patch

    cmd: mtd: add 'mtd' command

I will resend the seven remaining patches. The whole branch has
already been tested by Travis (it is based on your amarula/wip-spi-nand
branch) so please send a PR ASAP so that this work can be finally merged
(cc me so I'll be aware of it).

To be sure there are not regressions I started a Travis job on
this branch [1]. If there are any, I will fix them for -rc2.

[1] https://travis-ci.org/miquelraynal/u-boot/builds/435575048

Thanks,
MiquÃ¨l