From: Jagan Teki <jagan@openedev.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v12 1/8] dm: drop unused helper in MTD header
Date: Mon, 1 Oct 2018 21:45:45 +0530 [thread overview]
Message-ID: <5180aa18-2366-b4fb-8478-7412fd1a9422@openedev.com> (raw)
In-Reply-To: <20181001154044.3dcb3680@xps13>
On Monday 01 October 2018 07:10 PM, Miquel Raynal wrote:
> Hi Jagan,
>
> Jagan Teki <jagan@amarulasolutions.com> wrote on Mon, 1 Oct 2018
> 17:08:30 +0530:
>
>> On Mon, Oct 1, 2018 at 3:32 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>>>
>>> Hi Jagan,
>>>
>>> Jagan Teki <jagan@amarulasolutions.com> wrote on Mon, 1 Oct 2018
>>> 15:23:46 +0530:
>>>
>>>> On Sat, Sep 29, 2018 at 4:29 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>>>>>
>>>>> include/mtd.h might be included by files even if CONFIG_DM is not
>>>>> enabled. In this case, the call to dev_get_uclass_priv() would trigger
>>>>> a build error. Because this helper has no user, let's drop it off.
>>>>
>>>> Why would they use DM include file w/o using it? we need to fix in those places.
>>>
>>> There was no user of include/mtd.h not using CONFIG_DM.
>>>
>>> But now I am creating cmd/mtd.c which should work with both CONFIG_DM
>>> and no CONFIG_DM support. So include/mtd.h has reasons to be included.
>>
>> Then use ifdef CONFIG_MTD on the same file so it can arrange dm and
>> non-dm include at one place.
>
> The helper is not used, why do we keep it?
The whole point of placing ifdef is to support dm and non-dm at one include.
next prev parent reply other threads:[~2018-10-01 16:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 10:58 [U-Boot] [PATCH v12 0/8] SPI-NAND support (third batch) Miquel Raynal
2018-09-29 10:58 ` [U-Boot] [PATCH v12 1/8] dm: drop unused helper in MTD header Miquel Raynal
2018-10-01 9:53 ` Jagan Teki
2018-10-01 10:02 ` Miquel Raynal
2018-10-01 11:38 ` Jagan Teki
2018-10-01 13:40 ` Miquel Raynal
2018-10-01 16:15 ` Jagan Teki [this message]
2018-09-29 10:58 ` [U-Boot] [PATCH v12 2/8] mtd: uclass: add probe function Miquel Raynal
2018-09-29 10:58 ` [U-Boot] [PATCH v12 3/8] mtd: mtdpart: add a generic mtdparts-like parser Miquel Raynal
2018-09-29 10:58 ` [U-Boot] [PATCH v12 4/8] mtd: uboot: search for an equivalent MTD name with the mtdids Miquel Raynal
2018-09-29 10:58 ` [U-Boot] [PATCH v12 5/8] mtd: mtdpart: implement proper partition handling Miquel Raynal
2018-09-29 10:58 ` [U-Boot] [PATCH v12 6/8] cmd: mtd: add 'mtd' command Miquel Raynal
2018-09-29 10:58 ` [U-Boot] [PATCH v12 7/8] cmd: ubi: clean the partition handling Miquel Raynal
2018-09-29 10:58 ` [U-Boot] [PATCH v12 8/8] cmd: mtdparts: describe as legacy Miquel Raynal
2018-10-02 17:00 ` [U-Boot] [PATCH v12 0/8] SPI-NAND support (third batch) Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5180aa18-2366-b4fb-8478-7412fd1a9422@openedev.com \
--to=jagan@openedev.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.