From: Michal Hocko <mhocko@kernel.org> To: Jan Kara <jack@suse.cz> Cc: linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: Problems with VM_MIXEDMAP removal from /proc/<pid>/smaps Date: Tue, 2 Oct 2018 12:50:58 +0200 [thread overview] Message-ID: <20181002105058.GE18342@dhcp22.suse.cz> (raw) In-Reply-To: <20181002100531.GC4135@quack2.suse.cz> On Tue 02-10-18 12:05:31, Jan Kara wrote: > Hello, > > commit e1fb4a086495 "dax: remove VM_MIXEDMAP for fsdax and device dax" has > removed VM_MIXEDMAP flag from DAX VMAs. Now our testing shows that in the > mean time certain customer of ours started poking into /proc/<pid>/smaps > and looks at VMA flags there and if VM_MIXEDMAP is missing among the VMA > flags, the application just fails to start complaining that DAX support is > missing in the kernel. The question now is how do we go about this? Do they need to check for a general DAX support or do they need a per mapping granularity? > Strictly speaking, this is a userspace visible regression (as much as I > think that application poking into VMA flags at this level is just too > bold). Is there any precedens in handling similar issues with smaps which > really exposes a lot of information that is dependent on kernel > implementation details? Yeah, exposing all the vma flags was just a terrible idea. We have had a similar issue recently [1] for other flag that is no longer set while the implementation of the feature is still in place. I guess we really want to document that those flags are for debugging only and no stable and long term API should rely on it. Considering how new the thing really is (does anybody do anything production like out there?) I would tend to try a better interface rather than chasing after random vma flags. E.g. what prevents a completely unrelated usage of VM_MIXEDMAP? -- Michal Hocko SUSE Labs _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Jan Kara <jack@suse.cz> Cc: Dan Williams <dan.j.williams@intel.com>, Dave Jiang <dave.jiang@intel.com>, linux-nvdimm@lists.01.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, jthumshirn@suse.de Subject: Re: Problems with VM_MIXEDMAP removal from /proc/<pid>/smaps Date: Tue, 2 Oct 2018 12:50:58 +0200 [thread overview] Message-ID: <20181002105058.GE18342@dhcp22.suse.cz> (raw) In-Reply-To: <20181002100531.GC4135@quack2.suse.cz> On Tue 02-10-18 12:05:31, Jan Kara wrote: > Hello, > > commit e1fb4a086495 "dax: remove VM_MIXEDMAP for fsdax and device dax" has > removed VM_MIXEDMAP flag from DAX VMAs. Now our testing shows that in the > mean time certain customer of ours started poking into /proc/<pid>/smaps > and looks at VMA flags there and if VM_MIXEDMAP is missing among the VMA > flags, the application just fails to start complaining that DAX support is > missing in the kernel. The question now is how do we go about this? Do they need to check for a general DAX support or do they need a per mapping granularity? > Strictly speaking, this is a userspace visible regression (as much as I > think that application poking into VMA flags at this level is just too > bold). Is there any precedens in handling similar issues with smaps which > really exposes a lot of information that is dependent on kernel > implementation details? Yeah, exposing all the vma flags was just a terrible idea. We have had a similar issue recently [1] for other flag that is no longer set while the implementation of the feature is still in place. I guess we really want to document that those flags are for debugging only and no stable and long term API should rely on it. Considering how new the thing really is (does anybody do anything production like out there?) I would tend to try a better interface rather than chasing after random vma flags. E.g. what prevents a completely unrelated usage of VM_MIXEDMAP? -- Michal Hocko SUSE Labs
next prev parent reply other threads:[~2018-10-02 10:51 UTC|newest] Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-02 10:05 Problems with VM_MIXEDMAP removal from /proc/<pid>/smaps Jan Kara 2018-10-02 10:05 ` Jan Kara 2018-10-02 10:05 ` Jan Kara 2018-10-02 10:50 ` Michal Hocko [this message] 2018-10-02 10:50 ` Michal Hocko 2018-10-02 13:32 ` Jan Kara 2018-10-02 13:32 ` Jan Kara 2018-10-02 12:10 ` Johannes Thumshirn 2018-10-02 12:10 ` Johannes Thumshirn 2018-10-02 12:10 ` Johannes Thumshirn 2018-10-02 14:20 ` Johannes Thumshirn 2018-10-02 14:20 ` Johannes Thumshirn 2018-10-02 14:20 ` Johannes Thumshirn 2018-10-02 14:45 ` Christoph Hellwig 2018-10-02 14:45 ` Christoph Hellwig 2018-10-02 15:01 ` Johannes Thumshirn 2018-10-02 15:01 ` Johannes Thumshirn 2018-10-02 15:01 ` Johannes Thumshirn 2018-10-02 15:06 ` Christoph Hellwig 2018-10-02 15:06 ` Christoph Hellwig 2018-10-04 10:09 ` Johannes Thumshirn 2018-10-04 10:09 ` Johannes Thumshirn 2018-10-04 10:09 ` Johannes Thumshirn 2018-10-05 6:25 ` Christoph Hellwig 2018-10-05 6:25 ` Christoph Hellwig 2018-10-05 6:35 ` Johannes Thumshirn 2018-10-05 6:35 ` Johannes Thumshirn 2018-10-05 6:35 ` Johannes Thumshirn 2018-10-06 1:17 ` Dan Williams 2018-10-06 1:17 ` Dan Williams 2018-10-14 15:47 ` Dan Williams 2018-10-14 15:47 ` Dan Williams 2018-10-17 20:01 ` Dan Williams 2018-10-18 17:43 ` Jan Kara 2018-10-18 17:43 ` Jan Kara 2018-10-18 19:10 ` Dan Williams 2018-10-18 19:10 ` Dan Williams 2018-10-19 3:01 ` Dave Chinner 2018-10-19 3:01 ` Dave Chinner 2018-10-02 14:29 ` Jan Kara 2018-10-02 14:29 ` Jan Kara 2018-10-02 14:29 ` Jan Kara 2018-10-02 14:37 ` Christoph Hellwig 2018-10-02 14:37 ` Christoph Hellwig 2018-10-02 14:37 ` Christoph Hellwig 2018-10-02 14:44 ` Johannes Thumshirn 2018-10-02 14:44 ` Johannes Thumshirn 2018-10-02 14:44 ` Johannes Thumshirn 2018-10-02 14:44 ` Johannes Thumshirn 2018-10-02 14:44 ` Johannes Thumshirn 2018-10-02 14:52 ` Christoph Hellwig 2018-10-02 14:52 ` Christoph Hellwig 2018-10-02 14:52 ` Christoph Hellwig 2018-10-02 15:31 ` Jan Kara 2018-10-02 15:31 ` Jan Kara 2018-10-02 15:31 ` Jan Kara 2018-10-02 20:18 ` Dan Williams 2018-10-02 20:18 ` Dan Williams 2018-10-03 12:50 ` Jan Kara 2018-10-03 12:50 ` Jan Kara 2018-10-03 12:50 ` Jan Kara 2018-10-03 14:38 ` Dan Williams 2018-10-03 14:38 ` Dan Williams 2018-10-03 15:06 ` Jan Kara 2018-10-03 15:06 ` Jan Kara 2018-10-03 15:06 ` Jan Kara 2018-10-03 15:13 ` Dan Williams 2018-10-03 15:13 ` Dan Williams 2018-10-03 15:13 ` Dan Williams 2018-10-03 16:44 ` Jan Kara 2018-10-03 16:44 ` Jan Kara 2018-10-03 16:44 ` Jan Kara 2018-10-03 21:13 ` Dan Williams 2018-10-03 21:13 ` Dan Williams 2018-10-03 21:13 ` Dan Williams 2018-10-04 10:04 ` Johannes Thumshirn 2018-10-04 10:04 ` Johannes Thumshirn 2018-10-04 10:04 ` Johannes Thumshirn 2018-10-04 10:04 ` Johannes Thumshirn 2018-10-04 10:04 ` Johannes Thumshirn 2018-10-02 15:07 ` Jan Kara 2018-10-02 15:07 ` Jan Kara 2018-10-02 15:07 ` Jan Kara 2018-10-17 20:23 ` Jeff Moyer 2018-10-17 20:23 ` Jeff Moyer 2018-10-17 20:23 ` Jeff Moyer 2018-10-17 20:23 ` Jeff Moyer 2018-10-18 0:25 ` Dave Chinner 2018-10-18 0:25 ` Dave Chinner 2018-10-18 0:25 ` Dave Chinner 2018-10-18 14:55 ` Jan Kara 2018-10-18 14:55 ` Jan Kara 2018-10-19 0:43 ` Dave Chinner 2018-10-19 0:43 ` Dave Chinner 2018-10-19 0:43 ` Dave Chinner 2018-10-30 6:30 ` Dan Williams 2018-10-30 6:30 ` Dan Williams 2018-10-30 6:30 ` Dan Williams 2018-10-30 22:49 ` Dave Chinner 2018-10-30 22:49 ` Dave Chinner 2018-10-30 22:49 ` Dave Chinner 2018-10-30 22:59 ` Dan Williams 2018-10-30 22:59 ` Dan Williams 2018-10-30 22:59 ` Dan Williams 2018-10-31 5:59 ` y-goto 2018-10-31 5:59 ` y-goto-LMvhtfratI1BDgjK7y7TUQ 2018-10-31 5:59 ` y-goto 2018-11-01 23:00 ` Dave Chinner 2018-11-01 23:00 ` Dave Chinner 2018-11-01 23:00 ` Dave Chinner 2018-11-02 1:43 ` y-goto 2018-11-02 1:43 ` y-goto-LMvhtfratI1BDgjK7y7TUQ 2018-11-02 1:43 ` y-goto 2018-10-18 21:05 ` Jeff Moyer 2018-10-18 21:05 ` Jeff Moyer 2018-10-18 21:05 ` Jeff Moyer 2018-10-18 21:05 ` Jeff Moyer 2018-10-09 19:43 ` Jeff Moyer 2018-10-09 19:43 ` Jeff Moyer 2018-10-09 19:43 ` Jeff Moyer 2018-10-16 8:25 ` Jan Kara 2018-10-16 8:25 ` Jan Kara 2018-10-16 12:35 ` Jeff Moyer 2018-10-16 12:35 ` Jeff Moyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181002105058.GE18342@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=jack@suse.cz \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nvdimm@lists.01.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.