* [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable
@ 2018-10-02 21:10 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2018-10-02 21:10 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Arnd Bergmann, Joachim Eastwood, Greg Kroah-Hartman,
Bartosz Golaszewski, Masahiro Yamada, Randy Dunlap,
linux-arm-kernel, linux-kernel
drivers/nvmem/lpc18xx_eeprom.c: In function 'lpc18xx_eeprom_remove':
drivers/nvmem/lpc18xx_eeprom.c:258:6: error: unused variable 'ret' [-Werror=unused-variable]
Fixes: 226014d13fa5 ("nvmem: lpc18xx_eeprom: use devm_nvmem_register()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/nvmem/lpc18xx_eeprom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
index b42dbaddb419..66cff1e2147a 100644
--- a/drivers/nvmem/lpc18xx_eeprom.c
+++ b/drivers/nvmem/lpc18xx_eeprom.c
@@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
static int lpc18xx_eeprom_remove(struct platform_device *pdev)
{
struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
- int ret;
clk_disable_unprepare(eeprom->clk);
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable
@ 2018-10-02 21:10 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2018-10-02 21:10 UTC (permalink / raw)
To: linux-arm-kernel
drivers/nvmem/lpc18xx_eeprom.c: In function 'lpc18xx_eeprom_remove':
drivers/nvmem/lpc18xx_eeprom.c:258:6: error: unused variable 'ret' [-Werror=unused-variable]
Fixes: 226014d13fa5 ("nvmem: lpc18xx_eeprom: use devm_nvmem_register()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/nvmem/lpc18xx_eeprom.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
index b42dbaddb419..66cff1e2147a 100644
--- a/drivers/nvmem/lpc18xx_eeprom.c
+++ b/drivers/nvmem/lpc18xx_eeprom.c
@@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
static int lpc18xx_eeprom_remove(struct platform_device *pdev)
{
struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
- int ret;
clk_disable_unprepare(eeprom->clk);
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable
2018-10-02 21:10 ` Arnd Bergmann
@ 2018-10-02 21:22 ` Bartosz Golaszewski
-1 siblings, 0 replies; 6+ messages in thread
From: Bartosz Golaszewski @ 2018-10-02 21:22 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Srinivas Kandagatla, Joachim Eastwood, Greg Kroah-Hartman,
Bartosz Golaszewski, Masahiro Yamada, rdunlap, Linux ARM,
Linux Kernel Mailing List
wt., 2 paź 2018 o 23:10 Arnd Bergmann <arnd@arndb.de> napisał(a):
>
> drivers/nvmem/lpc18xx_eeprom.c: In function 'lpc18xx_eeprom_remove':
> drivers/nvmem/lpc18xx_eeprom.c:258:6: error: unused variable 'ret' [-Werror=unused-variable]
>
> Fixes: 226014d13fa5 ("nvmem: lpc18xx_eeprom: use devm_nvmem_register()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/nvmem/lpc18xx_eeprom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
> index b42dbaddb419..66cff1e2147a 100644
> --- a/drivers/nvmem/lpc18xx_eeprom.c
> +++ b/drivers/nvmem/lpc18xx_eeprom.c
> @@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
> static int lpc18xx_eeprom_remove(struct platform_device *pdev)
> {
> struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
> - int ret;
>
> clk_disable_unprepare(eeprom->clk);
>
> --
> 2.18.0
>
Hi Arnd,
I had already sent a fix for that with you in Cc:
https://lkml.org/lkml/2018/10/2/439
Best regards,
Bartosz
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable
@ 2018-10-02 21:22 ` Bartosz Golaszewski
0 siblings, 0 replies; 6+ messages in thread
From: Bartosz Golaszewski @ 2018-10-02 21:22 UTC (permalink / raw)
To: linux-arm-kernel
wt., 2 pa? 2018 o 23:10 Arnd Bergmann <arnd@arndb.de> napisa?(a):
>
> drivers/nvmem/lpc18xx_eeprom.c: In function 'lpc18xx_eeprom_remove':
> drivers/nvmem/lpc18xx_eeprom.c:258:6: error: unused variable 'ret' [-Werror=unused-variable]
>
> Fixes: 226014d13fa5 ("nvmem: lpc18xx_eeprom: use devm_nvmem_register()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/nvmem/lpc18xx_eeprom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvmem/lpc18xx_eeprom.c b/drivers/nvmem/lpc18xx_eeprom.c
> index b42dbaddb419..66cff1e2147a 100644
> --- a/drivers/nvmem/lpc18xx_eeprom.c
> +++ b/drivers/nvmem/lpc18xx_eeprom.c
> @@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
> static int lpc18xx_eeprom_remove(struct platform_device *pdev)
> {
> struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
> - int ret;
>
> clk_disable_unprepare(eeprom->clk);
>
> --
> 2.18.0
>
Hi Arnd,
I had already sent a fix for that with you in Cc:
https://lkml.org/lkml/2018/10/2/439
Best regards,
Bartosz
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable
2018-10-02 21:22 ` Bartosz Golaszewski
@ 2018-10-02 21:26 ` Arnd Bergmann
-1 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2018-10-02 21:26 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Srinivas Kandagatla, Joachim Eastwood, gregkh,
Bartosz Golaszewski, Masahiro Yamada, Randy Dunlap, Linux ARM,
Linux Kernel Mailing List
On Tue, Oct 2, 2018 at 11:22 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> wt., 2 paź 2018 o 23:10 Arnd Bergmann <arnd@arndb.de> napisał(a):
> Hi Arnd,
>
> I had already sent a fix for that with you in Cc:
> https://lkml.org/lkml/2018/10/2/439
Ah, good. I had some vague memory of that, but couldn't find it in
my mailbox when I sent out the other fixes for today's
linux-next build regressions, so I included this as well.
Please ignore my patch.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable
@ 2018-10-02 21:26 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2018-10-02 21:26 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 2, 2018 at 11:22 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> wt., 2 pa? 2018 o 23:10 Arnd Bergmann <arnd@arndb.de> napisa?(a):
> Hi Arnd,
>
> I had already sent a fix for that with you in Cc:
> https://lkml.org/lkml/2018/10/2/439
Ah, good. I had some vague memory of that, but couldn't find it in
my mailbox when I sent out the other fixes for today's
linux-next build regressions, so I included this as well.
Please ignore my patch.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-02 21:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-02 21:10 [PATCH] nvmem: lpc18xx_eeprom: remove an unused variable Arnd Bergmann
2018-10-02 21:10 ` Arnd Bergmann
2018-10-02 21:22 ` Bartosz Golaszewski
2018-10-02 21:22 ` Bartosz Golaszewski
2018-10-02 21:26 ` Arnd Bergmann
2018-10-02 21:26 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.