* [PATCH] video: fbdev: arcfb: mark expected switch fall-through
@ 2018-10-03 11:50 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-03 11:50 UTC (permalink / raw)
To: Jaya Kumar, Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 115017 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/video/fbdev/arcfb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
index 7e87d0d..a48741a 100644
--- a/drivers/video/fbdev/arcfb.c
+++ b/drivers/video/fbdev/arcfb.c
@@ -419,6 +419,8 @@ static int arcfb_ioctl(struct fb_info *info,
schedule();
finish_wait(&arcfb_waitq, &wait);
}
+ /* fall through */
+
case FBIO_GETCONTROL2:
{
unsigned char ctl2;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] video: fbdev: arcfb: mark expected switch fall-through
@ 2018-10-03 11:50 ` Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-03 11:50 UTC (permalink / raw)
To: Jaya Kumar, Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 115017 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/video/fbdev/arcfb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
index 7e87d0d..a48741a 100644
--- a/drivers/video/fbdev/arcfb.c
+++ b/drivers/video/fbdev/arcfb.c
@@ -419,6 +419,8 @@ static int arcfb_ioctl(struct fb_info *info,
schedule();
finish_wait(&arcfb_waitq, &wait);
}
+ /* fall through */
+
case FBIO_GETCONTROL2:
{
unsigned char ctl2;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: arcfb: mark expected switch fall-through
2018-10-03 11:50 ` Gustavo A. R. Silva
(?)
@ 2018-10-08 10:54 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-10-08 10:54 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Jaya Kumar, dri-devel, linux-fbdev, linux-kernel
On 10/03/2018 01:50 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 115017 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Patch queued for 4.20, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: arcfb: mark expected switch fall-through
@ 2018-10-08 10:54 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-10-08 10:54 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-fbdev, linux-kernel, dri-devel, Jaya Kumar
On 10/03/2018 01:50 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 115017 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Patch queued for 4.20, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] video: fbdev: arcfb: mark expected switch fall-through
@ 2018-10-08 10:54 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-10-08 10:54 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: linux-fbdev, linux-kernel, dri-devel, Jaya Kumar
On 10/03/2018 01:50 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 115017 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Patch queued for 4.20, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-08 10:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20181003115120epcas1p1e0cbeaddf6b54f8db18abf2b089e13e0@epcas1p1.samsung.com>
2018-10-03 11:50 ` [PATCH] video: fbdev: arcfb: mark expected switch fall-through Gustavo A. R. Silva
2018-10-03 11:50 ` Gustavo A. R. Silva
2018-10-08 10:54 ` Bartlomiej Zolnierkiewicz
2018-10-08 10:54 ` Bartlomiej Zolnierkiewicz
2018-10-08 10:54 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.