From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>
Cc: Vignesh R <vigneshr@ti.com>, Marek Vasut <marek.vasut@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Brian Norris <computersforpeace@gmail.com>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"juliensu@mxic.com.tw" <juliensu@mxic.com.tw>,
"zhengxunli@mxic.com.tw" <zhengxunli@mxic.com.tw>,
"masonccyang@mxic.com.tw" <masonccyang@mxic.com.tw>
Subject: Re: [PATCH 1/3] mtd: spi-nor: Add Octal mode support for mt35xu512aba
Date: Thu, 4 Oct 2018 09:39:25 +0200 [thread overview]
Message-ID: <20181004093925.2961d881@bbrezillon> (raw)
In-Reply-To: <VI1PR04MB1038C20CA97E453FC4C9CEAE99EA0@VI1PR04MB1038.eurprd04.prod.outlook.com>
+Julien, Zhengxunli and Mason from Macronix
Hi Yogesh,
On Thu, 4 Oct 2018 06:51:41 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
> Hi Vignesh,
>
> > -----Original Message-----
> > From: Vignesh R [mailto:vigneshr@ti.com]
> > Sent: Wednesday, October 3, 2018 10:26 PM
> > To: Boris Brezillon <boris.brezillon@bootlin.com>; Marek Vasut
> > <marek.vasut@gmail.com>; Rob Herring <robh+dt@kernel.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>; Yogesh Narayan Gaur
> > <yogeshnarayan.gaur@nxp.com>; Linux ARM Mailing List <linux-arm-
> > kernel@lists.infradead.org>; linux-mtd@lists.infradead.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Vignesh R
> > <vigneshr@ti.com>
> > Subject: [PATCH 1/3] mtd: spi-nor: Add Octal mode support for mt35xu512aba
> >
> > Micron's mt35xu512aba flash is an Octal flash that has x8 IO lines. It supports
> > read/write over 8 IO lines simulatenously. Add support for Octal read mode for
> > Micron mt35xu512aba.
> > Unfortunately, this flash is only complaint to SFDP JESD216B and does not seem
> > to support newer JESD216C standard that provides auto detection of Octal
> > mode capabilities and opcodes. Therefore, this capability is manually added
> > using new SPI_NOR_OCTAL_READ flag.
> >
>
> Thanks for sending the patch-set of adding octal support.
> If possible, can you share the MT35x datasheet?
>
> I also have the patch ready in which I have added support for Read (1-1-8 and 1-8-8) protocol and Write (1-1-8 and 1-8-8).
> Also have added support of Octal in driver/spi/spi.c framework.
>
> IMO, we would collaborate our patches.
Looks like we are of stepping on each others toes here (see this branch
[1]). I guess it's not a problem if we agree on who is working on what.
Yogesh, you already sent "spi: add flags for octal I/O data
transfer" [3] which is only adding the new OCTAL flags but is not
patching spi.c and spi-mem.c to take those new flags into account. Here
is my version of this patch [2] (it's still missing an update of
SPI_MEM_MAX_BUSWIDTH). Let me know what you want to do (rework your
version to address the problem or take mine).
Regarding other patches in [2], they're mainly here to add support for
X-X-X and DTR modes and get the m25p80 logic integrated in spi-nor.c so
that we can really check which NOR operations are supported by the SPI
controller.
Regards,
Boris
[1]https://github.com/bbrezillon/linux/commits/spi-nor/octo
[2]https://github.com/bbrezillon/linux/commit/9854a8fdd23f64e79859fd07a71d4a1c57b812f2
[3]https://patchwork.ozlabs.org/patch/894916/
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@bootlin.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] mtd: spi-nor: Add Octal mode support for mt35xu512aba
Date: Thu, 4 Oct 2018 09:39:25 +0200 [thread overview]
Message-ID: <20181004093925.2961d881@bbrezillon> (raw)
In-Reply-To: <VI1PR04MB1038C20CA97E453FC4C9CEAE99EA0@VI1PR04MB1038.eurprd04.prod.outlook.com>
+Julien, Zhengxunli and Mason from Macronix
Hi Yogesh,
On Thu, 4 Oct 2018 06:51:41 +0000
Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote:
> Hi Vignesh,
>
> > -----Original Message-----
> > From: Vignesh R [mailto:vigneshr at ti.com]
> > Sent: Wednesday, October 3, 2018 10:26 PM
> > To: Boris Brezillon <boris.brezillon@bootlin.com>; Marek Vasut
> > <marek.vasut@gmail.com>; Rob Herring <robh+dt@kernel.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>; Yogesh Narayan Gaur
> > <yogeshnarayan.gaur@nxp.com>; Linux ARM Mailing List <linux-arm-
> > kernel at lists.infradead.org>; linux-mtd at lists.infradead.org;
> > devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; Vignesh R
> > <vigneshr@ti.com>
> > Subject: [PATCH 1/3] mtd: spi-nor: Add Octal mode support for mt35xu512aba
> >
> > Micron's mt35xu512aba flash is an Octal flash that has x8 IO lines. It supports
> > read/write over 8 IO lines simulatenously. Add support for Octal read mode for
> > Micron mt35xu512aba.
> > Unfortunately, this flash is only complaint to SFDP JESD216B and does not seem
> > to support newer JESD216C standard that provides auto detection of Octal
> > mode capabilities and opcodes. Therefore, this capability is manually added
> > using new SPI_NOR_OCTAL_READ flag.
> >
>
> Thanks for sending the patch-set of adding octal support.
> If possible, can you share the MT35x datasheet?
>
> I also have the patch ready in which I have added support for Read (1-1-8 and 1-8-8) protocol and Write (1-1-8 and 1-8-8).
> Also have added support of Octal in driver/spi/spi.c framework.
>
> IMO, we would collaborate our patches.
Looks like we are of stepping on each others toes here (see this branch
[1]). I guess it's not a problem if we agree on who is working on what.
Yogesh, you already sent "spi: add flags for octal I/O data
transfer" [3] which is only adding the new OCTAL flags but is not
patching spi.c and spi-mem.c to take those new flags into account. Here
is my version of this patch [2] (it's still missing an update of
SPI_MEM_MAX_BUSWIDTH). Let me know what you want to do (rework your
version to address the problem or take mine).
Regarding other patches in [2], they're mainly here to add support for
X-X-X and DTR modes and get the m25p80 logic integrated in spi-nor.c so
that we can really check which NOR operations are supported by the SPI
controller.
Regards,
Boris
[1]https://github.com/bbrezillon/linux/commits/spi-nor/octo
[2]https://github.com/bbrezillon/linux/commit/9854a8fdd23f64e79859fd07a71d4a1c57b812f2
[3]https://patchwork.ozlabs.org/patch/894916/
next prev parent reply other threads:[~2018-10-04 7:39 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 16:56 [PATCH 0/3] spi-nor: Add Octal SPI support Vignesh R
2018-10-03 16:56 ` Vignesh R
2018-10-03 16:56 ` Vignesh R
2018-10-03 16:56 ` [PATCH 1/3] mtd: spi-nor: Add Octal mode support for mt35xu512aba Vignesh R
2018-10-03 16:56 ` Vignesh R
2018-10-03 16:56 ` Vignesh R
2018-10-04 6:51 ` Yogesh Narayan Gaur
2018-10-04 6:51 ` Yogesh Narayan Gaur
2018-10-04 7:39 ` Boris Brezillon [this message]
2018-10-04 7:39 ` Boris Brezillon
2018-10-04 8:47 ` Yogesh Narayan Gaur
2018-10-04 8:47 ` Yogesh Narayan Gaur
2018-10-04 9:10 ` Boris Brezillon
2018-10-04 9:10 ` Boris Brezillon
2018-10-04 9:10 ` Boris Brezillon
2018-10-04 10:38 ` Vignesh R
2018-10-04 10:38 ` Vignesh R
2018-10-04 10:38 ` Vignesh R
2018-10-04 9:45 ` Boris Brezillon
2018-10-04 9:45 ` Boris Brezillon
2018-10-04 9:45 ` Boris Brezillon
2018-10-04 11:12 ` Vignesh R
2018-10-04 11:12 ` Vignesh R
2018-10-04 11:12 ` Vignesh R
2018-10-04 11:27 ` Boris Brezillon
2018-10-04 11:27 ` Boris Brezillon
2018-10-04 11:27 ` Boris Brezillon
2018-10-03 16:56 ` [PATCH 2/3] dt-bindings: cadence-quadspi: Add new compatible for AM654 SoC Vignesh R
2018-10-03 16:56 ` Vignesh R
2018-10-03 16:56 ` Vignesh R
2018-10-15 19:11 ` Rob Herring
2018-10-15 19:11 ` Rob Herring
2018-10-15 19:11 ` Rob Herring
2018-10-03 16:56 ` [PATCH 3/3] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Vignesh R
2018-10-03 16:56 ` Vignesh R
2018-10-03 16:56 ` Vignesh R
2018-12-10 8:45 ` Boris Brezillon
2018-12-10 8:45 ` Boris Brezillon
2018-12-10 8:45 ` Boris Brezillon
2018-12-10 11:19 ` Vignesh R
2018-12-10 11:19 ` Vignesh R
2018-12-10 11:19 ` Vignesh R
2018-12-10 11:28 ` Boris Brezillon
2018-12-10 11:28 ` Boris Brezillon
2018-12-10 11:28 ` Boris Brezillon
2018-10-03 19:20 ` [PATCH 0/3] spi-nor: Add Octal SPI support Boris Brezillon
2018-10-03 19:20 ` Boris Brezillon
2018-10-04 10:35 ` Vignesh R
2018-10-04 10:35 ` Vignesh R
2018-10-04 10:35 ` Vignesh R
2018-10-04 11:17 ` Boris Brezillon
2018-10-04 11:17 ` Boris Brezillon
2018-10-04 11:17 ` Boris Brezillon
2018-10-08 15:36 ` Vignesh R
2018-10-08 15:36 ` Vignesh R
2018-10-12 8:52 ` Boris Brezillon
2018-10-12 8:52 ` Boris Brezillon
2018-12-09 8:47 ` Vignesh R
2018-12-09 8:47 ` Vignesh R
2018-12-09 8:47 ` Vignesh R
2018-12-10 8:45 ` Boris Brezillon
2018-12-10 8:45 ` Boris Brezillon
2018-12-10 8:45 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004093925.2961d881@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=juliensu@mxic.com.tw \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=masonccyang@mxic.com.tw \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=yogeshnarayan.gaur@nxp.com \
--cc=zhengxunli@mxic.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.