* [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver
@ 2018-09-30 6:54 Laurent Pinchart
2018-09-30 9:30 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 9+ messages in thread
From: Laurent Pinchart @ 2018-09-30 6:54 UTC (permalink / raw)
To: linux-media; +Cc: Joe Perches, Eugen Hristev, Josh Wu, Ludovic Desroches
include/media/atmel-isi got removed three years ago without the
MAINTAINERS file being updated. Remove the stale entry.
Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data")
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9989925f658d..1f5da095aff7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2497,7 +2497,6 @@ M: Ludovic Desroches <ludovic.desroches@microchip.com>
L: linux-media@vger.kernel.org
S: Supported
F: drivers/media/platform/atmel/atmel-isi.c
-F: include/media/atmel-isi.h
ATMEL LCDFB DRIVER
M: Nicolas Ferre <nicolas.ferre@microchip.com>
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver 2018-09-30 6:54 [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver Laurent Pinchart @ 2018-09-30 9:30 ` Mauro Carvalho Chehab 2018-09-30 9:40 ` Joe Perches 0 siblings, 1 reply; 9+ messages in thread From: Mauro Carvalho Chehab @ 2018-09-30 9:30 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-media, Joe Perches, Eugen Hristev, Josh Wu, Ludovic Desroches Em Sun, 30 Sep 2018 09:54:48 +0300 Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > include/media/atmel-isi got removed three years ago without the > MAINTAINERS file being updated. Remove the stale entry. > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data") > Reported-by: Joe Perches <joe@perches.com> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9989925f658d..1f5da095aff7 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2497,7 +2497,6 @@ M: Ludovic Desroches <ludovic.desroches@microchip.com> > L: linux-media@vger.kernel.org > S: Supported > F: drivers/media/platform/atmel/atmel-isi.c > -F: include/media/atmel-isi.h I guess the right fix would be to replace it by: F: drivers/media/platform/atmel/atmel-isi.h > > ATMEL LCDFB DRIVER > M: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks, Mauro ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver 2018-09-30 9:30 ` Mauro Carvalho Chehab @ 2018-09-30 9:40 ` Joe Perches 2018-10-01 16:51 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 9+ messages in thread From: Joe Perches @ 2018-09-30 9:40 UTC (permalink / raw) To: Mauro Carvalho Chehab, Laurent Pinchart Cc: linux-media, Eugen Hristev, Josh Wu, Ludovic Desroches On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho Chehab wrote: > Em Sun, 30 Sep 2018 09:54:48 +0300 > Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > > > include/media/atmel-isi got removed three years ago without the > > MAINTAINERS file being updated. Remove the stale entry. > > > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data") > > Reported-by: Joe Perches <joe@perches.com> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > MAINTAINERS | 1 - > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS [] > > @@ -2497,7 +2497,6 @@ M: Ludovic Desroches <ludovic.desroches@microchip.com> > > L: linux-media@vger.kernel.org > > S: Supported > > F: drivers/media/platform/atmel/atmel-isi.c > > -F: include/media/atmel-isi.h > > I guess the right fix would be to replace it by: > > F: drivers/media/platform/atmel/atmel-isi.h Or replace both F entries with: F: drivers/media/platform/atmel/atmel-isi.* Or combine the 2 MICROCHIP sections into one MICROCHIP ISC DRIVER M: Eugen Hristev <eugen.hristev@microchip.com> L: linux-media@vger.kernel.org S: Supported F: drivers/media/platform/atmel/atmel-isc.c F: drivers/media/platform/atmel/atmel-isc-regs.h F: devicetree/bindings/media/atmel-isc.txt MICROCHIP ISI DRIVER M: Eugen Hristev <eugen.hristev@microchip.com> L: linux-media@vger.kernel.org S: Supported F: drivers/media/platform/atmel/atmel-isi.c F: include/media/atmel-isi.h and maybe use something like: MICROCHIP MEDIA DRIVERS M: Eugen Hristev <eugen.hristev@microchip.com> L: linux-media@vger.kernel.org S: Supported F: drivers/media/platform/atmel/ F: devicetree/bindings/media/atmel-isc.txt ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver 2018-09-30 9:40 ` Joe Perches @ 2018-10-01 16:51 ` Mauro Carvalho Chehab 2018-10-02 6:15 ` Eugen Hristev 2018-10-02 6:35 ` Ludovic Desroches 0 siblings, 2 replies; 9+ messages in thread From: Mauro Carvalho Chehab @ 2018-10-01 16:51 UTC (permalink / raw) To: Joe Perches, Eugen Hristev, Josh Wu, Ludovic Desroches Cc: Laurent Pinchart, linux-media Em Sun, 30 Sep 2018 02:40:35 -0700 Joe Perches <joe@perches.com> escreveu: > On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 30 Sep 2018 09:54:48 +0300 > > Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > > > > > include/media/atmel-isi got removed three years ago without the > > > MAINTAINERS file being updated. Remove the stale entry. > > > > > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data") > > > Reported-by: Joe Perches <joe@perches.com> > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > > MAINTAINERS | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > [] > > > @@ -2497,7 +2497,6 @@ M: Ludovic Desroches <ludovic.desroches@microchip.com> > > > L: linux-media@vger.kernel.org > > > S: Supported > > > F: drivers/media/platform/atmel/atmel-isi.c > > > -F: include/media/atmel-isi.h > > > > I guess the right fix would be to replace it by: > > > > F: drivers/media/platform/atmel/atmel-isi.h > > Or replace both F entries with: > > F: drivers/media/platform/atmel/atmel-isi.* > > Or combine the 2 MICROCHIP sections into one > > MICROCHIP ISC DRIVER > M: Eugen Hristev <eugen.hristev@microchip.com> > L: linux-media@vger.kernel.org > S: Supported > F: drivers/media/platform/atmel/atmel-isc.c > F: drivers/media/platform/atmel/atmel-isc-regs.h > F: devicetree/bindings/media/atmel-isc.txt > > MICROCHIP ISI DRIVER > M: Eugen Hristev <eugen.hristev@microchip.com> > L: linux-media@vger.kernel.org > S: Supported > F: drivers/media/platform/atmel/atmel-isi.c > F: include/media/atmel-isi.h > > and maybe use something like: > > MICROCHIP MEDIA DRIVERS > M: Eugen Hristev <eugen.hristev@microchip.com> > L: > linux-media@vger.kernel.org > S: Supported > F: drivers/media/platform/atmel/ > F: devicetree/bindings/media/atmel-isc.txt Yeah, combining both of them seems a good alternative to me. Eugen/Ludovic/Josh, Comments? Regards, Mauro > > Thanks, Mauro ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver 2018-10-01 16:51 ` Mauro Carvalho Chehab @ 2018-10-02 6:15 ` Eugen Hristev 2018-10-02 6:35 ` Ludovic Desroches 1 sibling, 0 replies; 9+ messages in thread From: Eugen Hristev @ 2018-10-02 6:15 UTC (permalink / raw) To: Mauro Carvalho Chehab, Joe Perches, Josh Wu, Ludovic Desroches Cc: Laurent Pinchart, linux-media, Nicolas Ferre On 01.10.2018 19:51, Mauro Carvalho Chehab wrote: > Em Sun, 30 Sep 2018 02:40:35 -0700 > Joe Perches <joe@perches.com> escreveu: > >> On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho Chehab wrote: >>> Em Sun, 30 Sep 2018 09:54:48 +0300 >>> Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: >>> >>>> include/media/atmel-isi got removed three years ago without the >>>> MAINTAINERS file being updated. Remove the stale entry. >>>> >>>> Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data") >>>> Reported-by: Joe Perches <joe@perches.com> >>>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>>> --- >>>> MAINTAINERS | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >> [] >>>> @@ -2497,7 +2497,6 @@ M: Ludovic Desroches <ludovic.desroches@microchip.com> >>>> L: linux-media@vger.kernel.org >>>> S: Supported >>>> F: drivers/media/platform/atmel/atmel-isi.c >>>> -F: include/media/atmel-isi.h >>> >>> I guess the right fix would be to replace it by: >>> >>> F: drivers/media/platform/atmel/atmel-isi.h >> >> Or replace both F entries with: >> >> F: drivers/media/platform/atmel/atmel-isi.* >> >> Or combine the 2 MICROCHIP sections into one >> >> MICROCHIP ISC DRIVER >> M: Eugen Hristev <eugen.hristev@microchip.com> >> L: linux-media@vger.kernel.org >> S: Supported >> F: drivers/media/platform/atmel/atmel-isc.c >> F: drivers/media/platform/atmel/atmel-isc-regs.h >> F: devicetree/bindings/media/atmel-isc.txt >> >> MICROCHIP ISI DRIVER >> M: Eugen Hristev <eugen.hristev@microchip.com> >> L: linux-media@vger.kernel.org >> S: Supported >> F: drivers/media/platform/atmel/atmel-isi.c >> F: include/media/atmel-isi.h >> >> and maybe use something like: >> >> MICROCHIP MEDIA DRIVERS >> M: Eugen Hristev <eugen.hristev@microchip.com> >> L: >> linux-media@vger.kernel.org >> S: Supported >> F: drivers/media/platform/atmel/ >> F: devicetree/bindings/media/atmel-isc.txt > > Yeah, combining both of them seems a good alternative to me. > > Eugen/Ludovic/Josh, > > Comments? I am OK with combining them. Thanks > > Regards, > Mauro > >> >> > > > > Thanks, > Mauro > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver 2018-10-01 16:51 ` Mauro Carvalho Chehab 2018-10-02 6:15 ` Eugen Hristev @ 2018-10-02 6:35 ` Ludovic Desroches 2018-10-04 18:45 ` Mauro Carvalho Chehab 1 sibling, 1 reply; 9+ messages in thread From: Ludovic Desroches @ 2018-10-02 6:35 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: Joe Perches, Eugen Hristev, Josh Wu, Laurent Pinchart, linux-media On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote: > Em Sun, 30 Sep 2018 02:40:35 -0700 > Joe Perches <joe@perches.com> escreveu: > > > On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho Chehab wrote: > > > Em Sun, 30 Sep 2018 09:54:48 +0300 > > > Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > > > > > > > include/media/atmel-isi got removed three years ago without the > > > > MAINTAINERS file being updated. Remove the stale entry. > > > > > > > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data") > > > > Reported-by: Joe Perches <joe@perches.com> > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > --- > > > > MAINTAINERS | 1 - > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > [] > > > > @@ -2497,7 +2497,6 @@ M: Ludovic Desroches <ludovic.desroches@microchip.com> > > > > L: linux-media@vger.kernel.org > > > > S: Supported > > > > F: drivers/media/platform/atmel/atmel-isi.c > > > > -F: include/media/atmel-isi.h > > > > > > I guess the right fix would be to replace it by: > > > > > > F: drivers/media/platform/atmel/atmel-isi.h > > > > Or replace both F entries with: > > > > F: drivers/media/platform/atmel/atmel-isi.* > > > > Or combine the 2 MICROCHIP sections into one > > > > MICROCHIP ISC DRIVER > > M: Eugen Hristev <eugen.hristev@microchip.com> > > L: linux-media@vger.kernel.org > > S: Supported > > F: drivers/media/platform/atmel/atmel-isc.c > > F: drivers/media/platform/atmel/atmel-isc-regs.h > > F: devicetree/bindings/media/atmel-isc.txt > > > > MICROCHIP ISI DRIVER > > M: Eugen Hristev <eugen.hristev@microchip.com> > > L: linux-media@vger.kernel.org > > S: Supported > > F: drivers/media/platform/atmel/atmel-isi.c > > F: include/media/atmel-isi.h > > > > and maybe use something like: > > > > MICROCHIP MEDIA DRIVERS > > M: Eugen Hristev <eugen.hristev@microchip.com> > > L: > > linux-media@vger.kernel.org > > S: Supported > > F: drivers/media/platform/atmel/ > > F: devicetree/bindings/media/atmel-isc.txt > > Yeah, combining both of them seems a good alternative to me. > > Eugen/Ludovic/Josh, > > Comments? I have no strong opinion about it. The devices are different but usually there is one person per topic so combining them makes sense. Regards Ludovic ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver 2018-10-02 6:35 ` Ludovic Desroches @ 2018-10-04 18:45 ` Mauro Carvalho Chehab 2018-10-04 20:06 ` Laurent Pinchart 0 siblings, 1 reply; 9+ messages in thread From: Mauro Carvalho Chehab @ 2018-10-04 18:45 UTC (permalink / raw) To: Ludovic Desroches Cc: Joe Perches, Eugen Hristev, Josh Wu, Laurent Pinchart, linux-media, Songjun Wu Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches <ludovic.desroches@microchip.com> escreveu: > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote: > > Em Sun, 30 Sep 2018 02:40:35 -0700 > > Joe Perches <joe@perches.com> escreveu: > > > > > On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho Chehab wrote: > > > > Em Sun, 30 Sep 2018 09:54:48 +0300 > > > > Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > > > > > > > > > include/media/atmel-isi got removed three years ago without the > > > > > MAINTAINERS file being updated. Remove the stale entry. > > > > > > > > > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data") > > > > > Reported-by: Joe Perches <joe@perches.com> > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > > > --- > > > > > MAINTAINERS | 1 - > > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > [] > > > > > @@ -2497,7 +2497,6 @@ M: Ludovic Desroches <ludovic.desroches@microchip.com> > > > > > L: linux-media@vger.kernel.org > > > > > S: Supported > > > > > F: drivers/media/platform/atmel/atmel-isi.c > > > > > -F: include/media/atmel-isi.h > > > > > > > > I guess the right fix would be to replace it by: > > > > > > > > F: drivers/media/platform/atmel/atmel-isi.h > > > > > > Or replace both F entries with: > > > > > > F: drivers/media/platform/atmel/atmel-isi.* > > > > > > Or combine the 2 MICROCHIP sections into one > > > > > > MICROCHIP ISC DRIVER > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > L: linux-media@vger.kernel.org > > > S: Supported > > > F: drivers/media/platform/atmel/atmel-isc.c > > > F: drivers/media/platform/atmel/atmel-isc-regs.h > > > F: devicetree/bindings/media/atmel-isc.txt > > > > > > MICROCHIP ISI DRIVER > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > L: linux-media@vger.kernel.org > > > S: Supported > > > F: drivers/media/platform/atmel/atmel-isi.c > > > F: include/media/atmel-isi.h > > > > > > and maybe use something like: > > > > > > MICROCHIP MEDIA DRIVERS > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > L: > > > linux-media@vger.kernel.org > > > S: Supported > > > F: drivers/media/platform/atmel/ > > > F: devicetree/bindings/media/atmel-isc.txt > > > > Yeah, combining both of them seems a good alternative to me. > > > > Eugen/Ludovic/Josh, > > > > Comments? > > I have no strong opinion about it. The devices are different but usually > there is one person per topic so combining them makes sense. Hmm... At media tree, currently, MAINTAINERS entry is different: MICROCHIP / ATMEL ISC DRIVER M: Songjun Wu <songjun.wu@microchip.com> L: linux-media@vger.kernel.org S: Supported F: drivers/media/platform/atmel/atmel-isc.c F: drivers/media/platform/atmel/atmel-isc-regs.h F: devicetree/bindings/media/atmel-isc.txt ATMEL ISI DRIVER M: Ludovic Desroches <ludovic.desroches@microchip.com> L: linux-media@vger.kernel.org S: Supported F: drivers/media/platform/atmel/atmel-isi.c F: include/media/atmel-isi.h Maybe some patch upstream did some recent changes on it via another tree. So, in order to avoid conflicts upstream, for now I would just correct the location for the ISI file. After the merge window, we may revisit and join both entries, if the maintainers are the same. Regards, Mauro - MAINTAINERS: fix location for atmel-isi.h file The location of this file got changed by changeset 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data"), but MAINTAINERS was not updated accordingly. Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data") Reported-by: Joe Perches <joe@perches.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> diff --git a/MAINTAINERS b/MAINTAINERS index 9989925f658d..385ebe9ca0a2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2496,8 +2496,7 @@ ATMEL ISI DRIVER M: Ludovic Desroches <ludovic.desroches@microchip.com> L: linux-media@vger.kernel.org S: Supported -F: drivers/media/platform/atmel/atmel-isi.c -F: include/media/atmel-isi.h +F: drivers/media/platform/atmel/atmel-isi.* ATMEL LCDFB DRIVER M: Nicolas Ferre <nicolas.ferre@microchip.com> ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver 2018-10-04 18:45 ` Mauro Carvalho Chehab @ 2018-10-04 20:06 ` Laurent Pinchart 2018-10-05 18:41 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 9+ messages in thread From: Laurent Pinchart @ 2018-10-04 20:06 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: Ludovic Desroches, Joe Perches, Eugen Hristev, Josh Wu, linux-media, Songjun Wu Hi Mauro, On Thursday, 4 October 2018 21:45:05 EEST Mauro Carvalho Chehab wrote: > Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches escreveu: > > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote: > > > Em Sun, 30 Sep 2018 02:40:35 -0700 Joe Perches escreveu: > > > > On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho Chehab wrote: > > > > > Em Sun, 30 Sep 2018 09:54:48 +0300 Laurent Pinchart escreveu: > > > > > > include/media/atmel-isi got removed three years ago without the > > > > > > MAINTAINERS file being updated. Remove the stale entry. > > > > > > > > > > > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for > > > > > > platform data") Reported-by: Joe Perches <joe@perches.com> > > > > > > Signed-off-by: Laurent Pinchart > > > > > > <laurent.pinchart@ideasonboard.com> > > > > > > --- > > > > > > > > > > > > MAINTAINERS | 1 - > > > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > > > > [] > > > > > > > > > > @@ -2497,7 +2497,6 @@ M: Ludovic Desroches > > > > > > <ludovic.desroches@microchip.com>> > > > > > > > > > > L: linux-media@vger.kernel.org > > > > > > S: Supported > > > > > > F: drivers/media/platform/atmel/atmel-isi.c > > > > > > > > > > > > -F: include/media/atmel-isi.h > > > > > > > > > > I guess the right fix would be to replace it by: > > > > > > > > > > F: drivers/media/platform/atmel/atmel-isi.h > > > > > > > > Or replace both F entries with: > > > > > > > > F: drivers/media/platform/atmel/atmel-isi.* > > > > > > > > Or combine the 2 MICROCHIP sections into one > > > > > > > > MICROCHIP ISC DRIVER > > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > > L: linux-media@vger.kernel.org > > > > S: Supported > > > > F: drivers/media/platform/atmel/atmel-isc.c > > > > F: drivers/media/platform/atmel/atmel-isc-regs.h > > > > F: devicetree/bindings/media/atmel-isc.txt > > > > > > > > MICROCHIP ISI DRIVER > > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > > L: linux-media@vger.kernel.org > > > > S: Supported > > > > F: drivers/media/platform/atmel/atmel-isi.c > > > > F: include/media/atmel-isi.h > > > > > > > > and maybe use something like: > > > > > > > > MICROCHIP MEDIA DRIVERS > > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > > L: > > > > linux-media@vger.kernel.org > > > > S: Supported > > > > F: drivers/media/platform/atmel/ > > > > F: devicetree/bindings/media/atmel-isc.txt > > > > > > Yeah, combining both of them seems a good alternative to me. > > > > > > Eugen/Ludovic/Josh, > > > > > > Comments? > > > > I have no strong opinion about it. The devices are different but usually > > there is one person per topic so combining them makes sense. > > Hmm... At media tree, currently, MAINTAINERS entry is different: > > MICROCHIP / ATMEL ISC DRIVER > M: Songjun Wu <songjun.wu@microchip.com> > L: linux-media@vger.kernel.org > S: Supported > F: drivers/media/platform/atmel/atmel-isc.c > F: drivers/media/platform/atmel/atmel-isc-regs.h > F: devicetree/bindings/media/atmel-isc.txt > > ATMEL ISI DRIVER > M: Ludovic Desroches <ludovic.desroches@microchip.com> > L: linux-media@vger.kernel.org > S: Supported > F: drivers/media/platform/atmel/atmel-isi.c > F: include/media/atmel-isi.h > > Maybe some patch upstream did some recent changes on it via another > tree. > > So, in order to avoid conflicts upstream, for now I would just correct > the location for the ISI file. > > After the merge window, we may revisit and join both entries, > if the maintainers are the same. Fine with me. > - > > MAINTAINERS: fix location for atmel-isi.h file > > The location of this file got changed by changeset 40a78f36fc92 > ("[media] v4l: atmel-isi: Remove support for platform data"), but > MAINTAINERS was not updated accordingly. > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform > data") Reported-by: Joe Perches <joe@perches.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> I don't care about patch count statistics, but the usual practice is to retain the authorship of the original submitter. This is especially important with patches submitted by new or less frequent contributors, as recognition of their work is sometimes the only thing they get (and it doesn't hurt with regular contributors either). > diff --git a/MAINTAINERS b/MAINTAINERS > index 9989925f658d..385ebe9ca0a2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2496,8 +2496,7 @@ ATMEL ISI DRIVER > M: Ludovic Desroches <ludovic.desroches@microchip.com> > L: linux-media@vger.kernel.org > S: Supported > -F: drivers/media/platform/atmel/atmel-isi.c > -F: include/media/atmel-isi.h > +F: drivers/media/platform/atmel/atmel-isi.* > > ATMEL LCDFB DRIVER > M: Nicolas Ferre <nicolas.ferre@microchip.com> -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver 2018-10-04 20:06 ` Laurent Pinchart @ 2018-10-05 18:41 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 9+ messages in thread From: Mauro Carvalho Chehab @ 2018-10-05 18:41 UTC (permalink / raw) To: Laurent Pinchart Cc: Ludovic Desroches, Joe Perches, Eugen Hristev, Josh Wu, linux-media, Songjun Wu Em Thu, 04 Oct 2018 23:06:02 +0300 Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > Hi Mauro, > > On Thursday, 4 October 2018 21:45:05 EEST Mauro Carvalho Chehab wrote: > > Em Tue, 2 Oct 2018 08:35:47 +0200 Ludovic Desroches escreveu: > > > On Mon, Oct 01, 2018 at 01:51:01PM -0300, Mauro Carvalho Chehab wrote: > > > > Em Sun, 30 Sep 2018 02:40:35 -0700 Joe Perches escreveu: > > > > > On Sun, 2018-09-30 at 06:30 -0300, Mauro Carvalho Chehab wrote: > > > > > > Em Sun, 30 Sep 2018 09:54:48 +0300 Laurent Pinchart escreveu: > > > > > > > include/media/atmel-isi got removed three years ago without the > > > > > > > MAINTAINERS file being updated. Remove the stale entry. > > > > > > > > > > > > > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for > > > > > > > platform data") Reported-by: Joe Perches <joe@perches.com> > > > > > > > Signed-off-by: Laurent Pinchart > > > > > > > <laurent.pinchart@ideasonboard.com> > > > > > > > --- > > > > > > > > > > > > > > MAINTAINERS | 1 - > > > > > > > 1 file changed, 1 deletion(-) > > > > > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > > > > > > [] > > > > > > > > > > > > @@ -2497,7 +2497,6 @@ M: Ludovic Desroches > > > > > > > <ludovic.desroches@microchip.com>> > > > > > > > > > > > L: linux-media@vger.kernel.org > > > > > > > S: Supported > > > > > > > F: drivers/media/platform/atmel/atmel-isi.c > > > > > > > > > > > > > > -F: include/media/atmel-isi.h > > > > > > > > > > > > I guess the right fix would be to replace it by: > > > > > > > > > > > > F: drivers/media/platform/atmel/atmel-isi.h > > > > > > > > > > Or replace both F entries with: > > > > > > > > > > F: drivers/media/platform/atmel/atmel-isi.* > > > > > > > > > > Or combine the 2 MICROCHIP sections into one > > > > > > > > > > MICROCHIP ISC DRIVER > > > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > > > L: linux-media@vger.kernel.org > > > > > S: Supported > > > > > F: drivers/media/platform/atmel/atmel-isc.c > > > > > F: drivers/media/platform/atmel/atmel-isc-regs.h > > > > > F: devicetree/bindings/media/atmel-isc.txt > > > > > > > > > > MICROCHIP ISI DRIVER > > > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > > > L: linux-media@vger.kernel.org > > > > > S: Supported > > > > > F: drivers/media/platform/atmel/atmel-isi.c > > > > > F: include/media/atmel-isi.h > > > > > > > > > > and maybe use something like: > > > > > > > > > > MICROCHIP MEDIA DRIVERS > > > > > M: Eugen Hristev <eugen.hristev@microchip.com> > > > > > L: > > > > > linux-media@vger.kernel.org > > > > > S: Supported > > > > > F: drivers/media/platform/atmel/ > > > > > F: devicetree/bindings/media/atmel-isc.txt > > > > > > > > Yeah, combining both of them seems a good alternative to me. > > > > > > > > Eugen/Ludovic/Josh, > > > > > > > > Comments? > > > > > > I have no strong opinion about it. The devices are different but usually > > > there is one person per topic so combining them makes sense. > > > > Hmm... At media tree, currently, MAINTAINERS entry is different: > > > > MICROCHIP / ATMEL ISC DRIVER > > M: Songjun Wu <songjun.wu@microchip.com> > > L: linux-media@vger.kernel.org > > S: Supported > > F: drivers/media/platform/atmel/atmel-isc.c > > F: drivers/media/platform/atmel/atmel-isc-regs.h > > F: devicetree/bindings/media/atmel-isc.txt > > > > ATMEL ISI DRIVER > > M: Ludovic Desroches <ludovic.desroches@microchip.com> > > L: linux-media@vger.kernel.org > > S: Supported > > F: drivers/media/platform/atmel/atmel-isi.c > > F: include/media/atmel-isi.h > > > > Maybe some patch upstream did some recent changes on it via another > > tree. > > > > So, in order to avoid conflicts upstream, for now I would just correct > > the location for the ISI file. > > > > After the merge window, we may revisit and join both entries, > > if the maintainers are the same. > > Fine with me. > > > - > > > > MAINTAINERS: fix location for atmel-isi.h file > > > > The location of this file got changed by changeset 40a78f36fc92 > > ("[media] v4l: atmel-isi: Remove support for platform data"), but > > MAINTAINERS was not updated accordingly. > > > > Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform > > data") Reported-by: Joe Perches <joe@perches.com> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > > I don't care about patch count statistics, but the usual practice is to retain > the authorship of the original submitter. Huh? Frankly, I don't care who will be accredited for this, provided that this gets fixed. Yet, I'm lost with your comment. Did I miss some other patch at the ML touching it? At patchwork, it seems that there are only two patches: https://patchwork.linuxtv.org/project/linux-media/list/?state=*&q=MAINTAINERS the one from you, that assumed that this file got removed and does: -F: include/media/atmel-isi.h And my alternative proposal, that changes it to reflect its current location: -F: drivers/media/platform/atmel/atmel-isi.c -F: include/media/atmel-isi.h +F: drivers/media/platform/atmel/atmel-isi.* Both are based on Joe's "Bad MAINTAINERS" report e-mail. My patch follows one of the two possible solutions proposed by Joe. He is already credited as reporter there: MAINTAINERS: fix location for atmel-isi.h file The location of this file got changed by changeset 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data"), but MAINTAINERS was not updated accordingly. Fixes: 40a78f36fc92 ("[media] v4l: atmel-isi: Remove support for platform data") Reported-by: Joe Perches <joe@perches.com> He could also have a "Suggested-by" there. I'm perfectly fine adding it. However, using his name as the author of the patch, without his permission, doesn't sound right. That's said, I'm perfectly fine to drop this patch and wait for Joe to send me the same change with him as the author of such change. Thanks, Mauro ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-10-06 1:41 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-09-30 6:54 [PATCH] MAINTAINERS: Remove stale file entry for the Atmel ISI driver Laurent Pinchart 2018-09-30 9:30 ` Mauro Carvalho Chehab 2018-09-30 9:40 ` Joe Perches 2018-10-01 16:51 ` Mauro Carvalho Chehab 2018-10-02 6:15 ` Eugen Hristev 2018-10-02 6:35 ` Ludovic Desroches 2018-10-04 18:45 ` Mauro Carvalho Chehab 2018-10-04 20:06 ` Laurent Pinchart 2018-10-05 18:41 ` Mauro Carvalho Chehab
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.