* [PATCH] media: dt-bindings: media: rcar_vin: add device tree support for r8a7744
@ 2018-10-04 15:58 Biju Das
2018-10-04 20:08 ` Niklas Söderlund
0 siblings, 1 reply; 3+ messages in thread
From: Biju Das @ 2018-10-04 15:58 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Rob Herring, Mark Rutland
Cc: Biju Das, Niklas Söderlund, linux-media, linux-renesas-soc,
devicetree, Simon Horman, Geert Uytterhoeven, Chris Paterson,
Fabrizio Castro
Add compatible strings for r8a7744. No driver change is needed as
"renesas,rcar-gen2-vin" will activate the right code.However, it is good
practice to document compatible strings for the specific SoC as this
allows SoC specific changes to the driver if needed, in addition to
document SoC support and therefore allow checkpatch.pl to validate
compatible string values.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
---
This patch is tested against linux-next next next-20181004 & media_tree
---
Documentation/devicetree/bindings/media/rcar_vin.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
index 2f42005..d329a4e 100644
--- a/Documentation/devicetree/bindings/media/rcar_vin.txt
+++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
@@ -11,6 +11,7 @@ on Gen3 platforms to a CSI-2 receiver.
- compatible: Must be one or more of the following
- "renesas,vin-r8a7743" for the R8A7743 device
+ - "renesas,vin-r8a7744" for the R8A7744 device
- "renesas,vin-r8a7745" for the R8A7745 device
- "renesas,vin-r8a7778" for the R8A7778 device
- "renesas,vin-r8a7779" for the R8A7779 device
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: dt-bindings: media: rcar_vin: add device tree support for r8a7744
2018-10-04 15:58 [PATCH] media: dt-bindings: media: rcar_vin: add device tree support for r8a7744 Biju Das
@ 2018-10-04 20:08 ` Niklas Söderlund
0 siblings, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2018-10-04 20:08 UTC (permalink / raw)
To: Biju Das
Cc: Mauro Carvalho Chehab, Rob Herring, Mark Rutland, linux-media,
linux-renesas-soc, devicetree, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Hi Biju-san,
Thanks for your patch.
On 2018-10-04 16:58:11 +0100, Biju Das wrote:
> Add compatible strings for r8a7744. No driver change is needed as
> "renesas,rcar-gen2-vin" will activate the right code.However, it is good
> practice to document compatible strings for the specific SoC as this
> allows SoC specific changes to the driver if needed, in addition to
> document SoC support and therefore allow checkpatch.pl to validate
> compatible string values.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
Acked-by: Niklas S�derlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> This patch is tested against linux-next next next-20181004 & media_tree
> ---
> Documentation/devicetree/bindings/media/rcar_vin.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 2f42005..d329a4e 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -11,6 +11,7 @@ on Gen3 platforms to a CSI-2 receiver.
>
> - compatible: Must be one or more of the following
> - "renesas,vin-r8a7743" for the R8A7743 device
> + - "renesas,vin-r8a7744" for the R8A7744 device
> - "renesas,vin-r8a7745" for the R8A7745 device
> - "renesas,vin-r8a7778" for the R8A7778 device
> - "renesas,vin-r8a7779" for the R8A7779 device
> --
> 2.7.4
>
--
Regards,
Niklas S�derlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: dt-bindings: media: rcar_vin: add device tree support for r8a7744
@ 2018-10-04 20:08 ` Niklas Söderlund
0 siblings, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2018-10-04 20:08 UTC (permalink / raw)
To: Biju Das
Cc: Mauro Carvalho Chehab, Rob Herring, Mark Rutland, linux-media,
linux-renesas-soc, devicetree, Simon Horman, Geert Uytterhoeven,
Chris Paterson, Fabrizio Castro
Hi Biju-san,
Thanks for your patch.
On 2018-10-04 16:58:11 +0100, Biju Das wrote:
> Add compatible strings for r8a7744. No driver change is needed as
> "renesas,rcar-gen2-vin" will activate the right code.However, it is good
> practice to document compatible strings for the specific SoC as this
> allows SoC specific changes to the driver if needed, in addition to
> document SoC support and therefore allow checkpatch.pl to validate
> compatible string values.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
Acked-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> This patch is tested against linux-next next next-20181004 & media_tree
> ---
> Documentation/devicetree/bindings/media/rcar_vin.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rcar_vin.txt b/Documentation/devicetree/bindings/media/rcar_vin.txt
> index 2f42005..d329a4e 100644
> --- a/Documentation/devicetree/bindings/media/rcar_vin.txt
> +++ b/Documentation/devicetree/bindings/media/rcar_vin.txt
> @@ -11,6 +11,7 @@ on Gen3 platforms to a CSI-2 receiver.
>
> - compatible: Must be one or more of the following
> - "renesas,vin-r8a7743" for the R8A7743 device
> + - "renesas,vin-r8a7744" for the R8A7744 device
> - "renesas,vin-r8a7745" for the R8A7745 device
> - "renesas,vin-r8a7778" for the R8A7778 device
> - "renesas,vin-r8a7779" for the R8A7779 device
> --
> 2.7.4
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-05 3:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-04 15:58 [PATCH] media: dt-bindings: media: rcar_vin: add device tree support for r8a7744 Biju Das
2018-10-04 20:08 ` Niklas Söderlund
2018-10-04 20:08 ` Niklas Söderlund
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.