[PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Chris Wilson]

When RECOVERABLE is set, the kernel will attempt to automatically recover
a context after a hang. But if it is unset, the kernel will ban the
guilty context on a hang, preventing subsequent execution.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_ctx_exec.c | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
index 908b59af..1cd3b20e 100644
--- a/tests/gem_ctx_exec.c
+++ b/tests/gem_ctx_exec.c
@@ -147,6 +147,41 @@ static void invalid_context(int fd, unsigned ring, uint32_t handle)
 	igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT);
 }
 
+static void norecovery(int i915)
+{
+	for (int pass = 1; pass >= 0; pass--) {
+		struct drm_i915_gem_context_param param = {
+			.ctx_id = gem_context_create(i915),
+			.param = 0x7,
+			.value = pass,
+		};
+		int expect = pass == 0 ? -EIO : 0;
+		igt_spin_t *spin;
+
+		if (pass)
+			igt_require(__gem_context_set_param(i915, &param) == 0);
+		else
+			gem_context_set_param(i915, &param);
+		gem_context_get_param(i915, &param);
+		igt_assert_eq(param.value, pass);
+
+		spin = __igt_spin_batch_new(i915,
+					    .ctx = param.ctx_id,
+					    .flags = IGT_SPIN_POLL_RUN);
+		igt_assert(spin->running);
+
+		while (!READ_ONCE(*spin->running))
+			;
+		igt_force_gpu_reset(i915);
+
+		igt_spin_batch_end(spin);
+		igt_assert_eq(__gem_execbuf(i915, &spin->execbuf), expect);
+		igt_spin_batch_free(i915, spin);
+
+		gem_context_destroy(i915, param.ctx_id);
+	}
+}
+
 igt_main
 {
 	const uint32_t batch[2] = { 0, MI_BATCH_BUFFER_END };
@@ -190,6 +225,9 @@ igt_main
 	igt_subtest("eviction")
 		big_exec(fd, handle, 0);
 
+	igt_subtest("norecovery")
+		norecovery(fd);
+
 	igt_subtest("reset-pin-leak") {
 		int i;
 
-- 
2.19.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Chris Wilson]

When RECOVERABLE is set, the kernel will attempt to automatically recover
a context after a hang. But if it is unset, the kernel will ban the
guilty context on a hang, preventing subsequent execution.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_ctx_exec.c | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
index 908b59af..1cd3b20e 100644
--- a/tests/gem_ctx_exec.c
+++ b/tests/gem_ctx_exec.c
@@ -147,6 +147,41 @@ static void invalid_context(int fd, unsigned ring, uint32_t handle)
 	igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT);
 }
 
+static void norecovery(int i915)
+{
+	for (int pass = 1; pass >= 0; pass--) {
+		struct drm_i915_gem_context_param param = {
+			.ctx_id = gem_context_create(i915),
+			.param = 0x7,
+			.value = pass,
+		};
+		int expect = pass == 0 ? -EIO : 0;
+		igt_spin_t *spin;
+
+		if (pass)
+			igt_require(__gem_context_set_param(i915, &param) == 0);
+		else
+			gem_context_set_param(i915, &param);
+		gem_context_get_param(i915, &param);
+		igt_assert_eq(param.value, pass);
+
+		spin = __igt_spin_batch_new(i915,
+					    .ctx = param.ctx_id,
+					    .flags = IGT_SPIN_POLL_RUN);
+		igt_assert(spin->running);
+
+		while (!READ_ONCE(*spin->running))
+			;
+		igt_force_gpu_reset(i915);
+
+		igt_spin_batch_end(spin);
+		igt_assert_eq(__gem_execbuf(i915, &spin->execbuf), expect);
+		igt_spin_batch_free(i915, spin);
+
+		gem_context_destroy(i915, param.ctx_id);
+	}
+}
+
 igt_main
 {
 	const uint32_t batch[2] = { 0, MI_BATCH_BUFFER_END };
@@ -190,6 +225,9 @@ igt_main
 	igt_subtest("eviction")
 		big_exec(fd, handle, 0);
 
+	igt_subtest("norecovery")
+		norecovery(fd);
+
 	igt_subtest("reset-pin-leak") {
 		int i;
 
-- 
2.19.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Patchwork]

== Series Details ==

Series: igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE
URL   : https://patchwork.freedesktop.org/series/50459/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4915 -> IGTPW_1894 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1894 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1894, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50459/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1894:

  === IGT changes ===

    ==== Warnings ====

    igt@drv_selftest@live_guc:
      fi-glk-j4005:       SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1894 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_evict:
      fi-bsw-kefka:       PASS -> DMESG-WARN (fdo#107709)

    igt@gem_exec_suspend@basic-s4-devices:
      fi-bdw-samus:       NOTRUN -> INCOMPLETE (fdo#107773)

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@read-crc-pipe-c:
      fi-skl-6700k2:      PASS -> FAIL (fdo#103191)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362) +2

    
    ==== Possible fixes ====

    igt@drv_selftest@live_coherency:
      fi-gdg-551:         DMESG-FAIL (fdo#107164) -> PASS

    igt@drv_selftest@live_execlists:
      fi-glk-j4005:       INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    igt@gem_exec_suspend@basic-s3:
      fi-bdw-samus:       INCOMPLETE (fdo#107773) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-skl-guc:         FAIL (fdo#103191) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107709 https://bugs.freedesktop.org/show_bug.cgi?id=107709
  fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (46 -> 42) ==

  Missing    (4): fi-bsw-cyan fi-byt-squawks fi-icl-u2 fi-skl-6260u 


== Build changes ==

    * IGT: IGT_4660 -> IGTPW_1894

  CI_DRM_4915: 26e7a7d954a9c28b97af8ca7813f430fd9117232 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1894: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1894/
  IGT_4660: d0975646c50568e66e65b44b81d28232d059b94e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@gem_ctx_exec@norecovery

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1894/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Patchwork]

== Series Details ==

Series: igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE
URL   : https://patchwork.freedesktop.org/series/50459/
State : failure

== Summary ==

= CI Bug Log - changes from IGT_4660_full -> IGTPW_1894_full =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1894_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1894_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50459/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1894_full:

  === IGT changes ===

    ==== Possible regressions ====

    igt@kms_color@pipe-a-legacy-gamma:
      shard-apl:          PASS -> FAIL +1

    {igt@kms_plane_alpha_blend@pipe-b-alpha-basic}:
      shard-apl:          SKIP -> FAIL +16

    {igt@kms_plane_alpha_blend@pipe-b-alpha-transparant-fb}:
      shard-kbl:          SKIP -> FAIL +16

    
    ==== Warnings ====

    {igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid}:
      shard-kbl:          SKIP -> PASS +8

    {igt@kms_plane_alpha_blend@pipe-b-constant-alpha-mid}:
      shard-apl:          SKIP -> PASS +9

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          PASS -> SKIP
      shard-snb:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1894_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_await@wide-contexts:
      shard-kbl:          PASS -> FAIL (fdo#106680)

    igt@gem_persistent_relocs@forked-interruptible-faulting-reloc:
      shard-snb:          NOTRUN -> INCOMPLETE (fdo#105411)

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
      shard-snb:          NOTRUN -> DMESG-WARN (fdo#107956) +1

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
      shard-kbl:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-apl:          PASS -> FAIL (fdo#103232, fdo#103191) +1

    igt@kms_cursor_crc@cursor-128x42-onscreen:
      shard-apl:          PASS -> FAIL (fdo#103232) +8

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
      shard-kbl:          NOTRUN -> FAIL (fdo#103167)

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
      shard-apl:          PASS -> FAIL (fdo#103167) +3

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-apl:          PASS -> FAIL (fdo#103166) +2

    igt@kms_setmode@basic:
      shard-kbl:          PASS -> FAIL (fdo#99912)

    igt@pm_rpm@system-suspend-modeset:
      shard-kbl:          PASS -> INCOMPLETE (fdo#107807, fdo#103665)

    
    ==== Possible fixes ====

    igt@gem_ctx_isolation@bcs0-s3:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS +1

    igt@gem_exec_big:
      shard-hsw:          TIMEOUT (fdo#107937) -> PASS

    igt@gem_exec_suspend@basic-s3:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#106023, fdo#103665) -> PASS

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-apl:          DMESG-WARN (fdo#107956) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
  fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
  fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (6 -> 4) ==

  Missing    (2): shard-skl shard-glk 


== Build changes ==

    * IGT: IGT_4660 -> IGTPW_1894
    * Linux: CI_DRM_4912 -> CI_DRM_4915

  CI_DRM_4912: fde5d8f7153abb900a378cce97a7a6b32576a3fa @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4915: 26e7a7d954a9c28b97af8ca7813f430fd9117232 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1894: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1894/
  IGT_4660: d0975646c50568e66e65b44b81d28232d059b94e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1894/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> When RECOVERABLE is set, the kernel will attempt to automatically recover
> a context after a hang. But if it is unset, the kernel will ban the
> guilty context on a hang, preventing subsequent execution.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/gem_ctx_exec.c | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
> index 908b59af..1cd3b20e 100644
> --- a/tests/gem_ctx_exec.c
> +++ b/tests/gem_ctx_exec.c
> @@ -147,6 +147,41 @@ static void invalid_context(int fd, unsigned ring, uint32_t handle)
>  	igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT);
>  }
>  
> +static void norecovery(int i915)
> +{
> +	for (int pass = 1; pass >= 0; pass--) {
> +		struct drm_i915_gem_context_param param = {
> +			.ctx_id = gem_context_create(i915),
> +			.param = 0x7,
> +			.value = pass,
> +		};
> +		int expect = pass == 0 ? -EIO : 0;
> +		igt_spin_t *spin;
> +
> +		if (pass)
> +			igt_require(__gem_context_set_param(i915, &param) == 0);
> +		else
> +			gem_context_set_param(i915, &param);

You are trying in here to make the asserts unique?

> +		gem_context_get_param(i915, &param);
> +		igt_assert_eq(param.value, pass);
> +
> +		spin = __igt_spin_batch_new(i915,
> +					    .ctx = param.ctx_id,
> +					    .flags = IGT_SPIN_POLL_RUN);
> +		igt_assert(spin->running);
> +
> +		while (!READ_ONCE(*spin->running))
> +			;

wait that it is running...

> +		igt_force_gpu_reset(i915);
> +

then reset.

> +		igt_spin_batch_end(spin);

> +		igt_assert_eq(__gem_execbuf(i915, &spin->execbuf), expect);

Hmm where do we sync with hang resolution. Is it the handoff in
the wedged debugfs entry?

-Mika

> +		igt_spin_batch_free(i915, spin);
> +
> +		gem_context_destroy(i915, param.ctx_id);
> +	}
> +}
> +
>  igt_main
>  {
>  	const uint32_t batch[2] = { 0, MI_BATCH_BUFFER_END };
> @@ -190,6 +225,9 @@ igt_main
>  	igt_subtest("eviction")
>  		big_exec(fd, handle, 0);
>  
> +	igt_subtest("norecovery")
> +		norecovery(fd);
> +
>  	igt_subtest("reset-pin-leak") {
>  		int i;
>  
> -- 
> 2.19.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> When RECOVERABLE is set, the kernel will attempt to automatically recover
> a context after a hang. But if it is unset, the kernel will ban the
> guilty context on a hang, preventing subsequent execution.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/gem_ctx_exec.c | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>
> diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
> index 908b59af..1cd3b20e 100644
> --- a/tests/gem_ctx_exec.c
> +++ b/tests/gem_ctx_exec.c
> @@ -147,6 +147,41 @@ static void invalid_context(int fd, unsigned ring, uint32_t handle)
>  	igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT);
>  }
>  
> +static void norecovery(int i915)
> +{
> +	for (int pass = 1; pass >= 0; pass--) {
> +		struct drm_i915_gem_context_param param = {
> +			.ctx_id = gem_context_create(i915),
> +			.param = 0x7,
> +			.value = pass,
> +		};
> +		int expect = pass == 0 ? -EIO : 0;
> +		igt_spin_t *spin;
> +
> +		if (pass)
> +			igt_require(__gem_context_set_param(i915, &param) == 0);
> +		else
> +			gem_context_set_param(i915, &param);

You are trying in here to make the asserts unique?

> +		gem_context_get_param(i915, &param);
> +		igt_assert_eq(param.value, pass);
> +
> +		spin = __igt_spin_batch_new(i915,
> +					    .ctx = param.ctx_id,
> +					    .flags = IGT_SPIN_POLL_RUN);
> +		igt_assert(spin->running);
> +
> +		while (!READ_ONCE(*spin->running))
> +			;

wait that it is running...

> +		igt_force_gpu_reset(i915);
> +

then reset.

> +		igt_spin_batch_end(spin);

> +		igt_assert_eq(__gem_execbuf(i915, &spin->execbuf), expect);

Hmm where do we sync with hang resolution. Is it the handoff in
the wedged debugfs entry?

-Mika

> +		igt_spin_batch_free(i915, spin);
> +
> +		gem_context_destroy(i915, param.ctx_id);
> +	}
> +}
> +
>  igt_main
>  {
>  	const uint32_t batch[2] = { 0, MI_BATCH_BUFFER_END };
> @@ -190,6 +225,9 @@ igt_main
>  	igt_subtest("eviction")
>  		big_exec(fd, handle, 0);
>  
> +	igt_subtest("norecovery")
> +		norecovery(fd);
> +
>  	igt_subtest("reset-pin-leak") {
>  		int i;
>  
> -- 
> 2.19.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Chris Wilson]

Quoting Mika Kuoppala (2018-10-04 14:26:16)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > When RECOVERABLE is set, the kernel will attempt to automatically recover
> > a context after a hang. But if it is unset, the kernel will ban the
> > guilty context on a hang, preventing subsequent execution.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  tests/gem_ctx_exec.c | 38 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >
> > diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
> > index 908b59af..1cd3b20e 100644
> > --- a/tests/gem_ctx_exec.c
> > +++ b/tests/gem_ctx_exec.c
> > @@ -147,6 +147,41 @@ static void invalid_context(int fd, unsigned ring, uint32_t handle)
> >       igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT);
> >  }
> >  
> > +static void norecovery(int i915)
> > +{
> > +     for (int pass = 1; pass >= 0; pass--) {
> > +             struct drm_i915_gem_context_param param = {
> > +                     .ctx_id = gem_context_create(i915),
> > +                     .param = 0x7,
> > +                     .value = pass,
> > +             };
> > +             int expect = pass == 0 ? -EIO : 0;
> > +             igt_spin_t *spin;
> > +
> > +             if (pass)
> > +                     igt_require(__gem_context_set_param(i915, &param) == 0);
> > +             else
> > +                     gem_context_set_param(i915, &param);
> 
> You are trying in here to make the asserts unique?

Nah, since pass=1 was meant to be standard procedure, this was just a
"has param check". So I was being lazy and not separating it out into
its own little helper.

> > +             gem_context_get_param(i915, &param);
> > +             igt_assert_eq(param.value, pass);
> > +
> > +             spin = __igt_spin_batch_new(i915,
> > +                                         .ctx = param.ctx_id,
> > +                                         .flags = IGT_SPIN_POLL_RUN);
> > +             igt_assert(spin->running);
> > +
> > +             while (!READ_ONCE(*spin->running))
> > +                     ;
> 
> wait that it is running...
> 
> > +             igt_force_gpu_reset(i915);
> > +
> 
> then reset.

Aye, that's our current MO for gpu resets.

> > +             igt_spin_batch_end(spin);
> 
> > +             igt_assert_eq(__gem_execbuf(i915, &spin->execbuf), expect);
> 
> Hmm where do we sync with hang resolution. Is it the handoff in
> the wedged debugfs entry?

Yes. The force-gpu reset is synchronous, you should be able to remember
the fun we had with that little race.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Chris Wilson]

Quoting Mika Kuoppala (2018-10-04 14:26:16)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
> 
> > When RECOVERABLE is set, the kernel will attempt to automatically recover
> > a context after a hang. But if it is unset, the kernel will ban the
> > guilty context on a hang, preventing subsequent execution.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >  tests/gem_ctx_exec.c | 38 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >
> > diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
> > index 908b59af..1cd3b20e 100644
> > --- a/tests/gem_ctx_exec.c
> > +++ b/tests/gem_ctx_exec.c
> > @@ -147,6 +147,41 @@ static void invalid_context(int fd, unsigned ring, uint32_t handle)
> >       igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT);
> >  }
> >  
> > +static void norecovery(int i915)
> > +{
> > +     for (int pass = 1; pass >= 0; pass--) {
> > +             struct drm_i915_gem_context_param param = {
> > +                     .ctx_id = gem_context_create(i915),
> > +                     .param = 0x7,
> > +                     .value = pass,
> > +             };
> > +             int expect = pass == 0 ? -EIO : 0;
> > +             igt_spin_t *spin;
> > +
> > +             if (pass)
> > +                     igt_require(__gem_context_set_param(i915, &param) == 0);
> > +             else
> > +                     gem_context_set_param(i915, &param);
> 
> You are trying in here to make the asserts unique?

Nah, since pass=1 was meant to be standard procedure, this was just a
"has param check". So I was being lazy and not separating it out into
its own little helper.

> > +             gem_context_get_param(i915, &param);
> > +             igt_assert_eq(param.value, pass);
> > +
> > +             spin = __igt_spin_batch_new(i915,
> > +                                         .ctx = param.ctx_id,
> > +                                         .flags = IGT_SPIN_POLL_RUN);
> > +             igt_assert(spin->running);
> > +
> > +             while (!READ_ONCE(*spin->running))
> > +                     ;
> 
> wait that it is running...
> 
> > +             igt_force_gpu_reset(i915);
> > +
> 
> then reset.

Aye, that's our current MO for gpu resets.

> > +             igt_spin_batch_end(spin);
> 
> > +             igt_assert_eq(__gem_execbuf(i915, &spin->execbuf), expect);
> 
> Hmm where do we sync with hang resolution. Is it the handoff in
> the wedged debugfs entry?

Yes. The force-gpu reset is synchronous, you should be able to remember
the fun we had with that little race.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[PATCH i-g-t v2] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Chris Wilson]

When RECOVERABLE is set, the kernel will attempt to automatically recover
a context after a hang. But if it is unset, the kernel will ban the
guilty context on a hang, preventing subsequent execution.

v2: Create a has_recoverable_param()

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@intel.com>
---
 tests/gem_ctx_exec.c | 48 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)

diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
index 908b59af..44e6ec2b 100644
--- a/tests/gem_ctx_exec.c
+++ b/tests/gem_ctx_exec.c
@@ -147,6 +147,51 @@ static void invalid_context(int fd, unsigned ring, uint32_t handle)
 	igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT);
 }
 
+static bool has_recoverable_param(int i915)
+{
+	struct drm_i915_gem_context_param param = {
+		.param = 0x7,
+	};
+
+	return __gem_context_get_param(i915, &param) == 0;
+}
+
+static void norecovery(int i915)
+{
+	igt_require(has_recoverable_param(i915));
+
+	for (int pass = 1; pass >= 0; pass--) {
+		struct drm_i915_gem_context_param param = {
+			.ctx_id = gem_context_create(i915),
+			.param = 0x7,
+			.value = pass,
+		};
+		int expect = pass == 0 ? -EIO : 0;
+		igt_spin_t *spin;
+
+		gem_context_set_param(i915, &param);
+
+		param.value = !pass;
+		gem_context_get_param(i915, &param);
+		igt_assert_eq(param.value, pass);
+
+		spin = __igt_spin_batch_new(i915,
+					    .ctx = param.ctx_id,
+					    .flags = IGT_SPIN_POLL_RUN);
+		igt_assert(spin->running);
+
+		while (!READ_ONCE(*spin->running))
+			;
+		igt_force_gpu_reset(i915);
+
+		igt_spin_batch_end(spin);
+		igt_assert_eq(__gem_execbuf(i915, &spin->execbuf), expect);
+		igt_spin_batch_free(i915, spin);
+
+		gem_context_destroy(i915, param.ctx_id);
+	}
+}
+
 igt_main
 {
 	const uint32_t batch[2] = { 0, MI_BATCH_BUFFER_END };
@@ -190,6 +235,9 @@ igt_main
 	igt_subtest("eviction")
 		big_exec(fd, handle, 0);
 
+	igt_subtest("norecovery")
+		norecovery(fd);
+
 	igt_subtest("reset-pin-leak") {
 		int i;
 
-- 
2.19.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Patchwork]

== Series Details ==

Series: igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE
URL   : https://patchwork.freedesktop.org/series/50561/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4931 -> IGTPW_1909 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50561/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1909 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3:
      fi-bdw-samus:       NOTRUN -> INCOMPLETE (fdo#107773)
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362)

    
    ==== Possible fixes ====

    igt@gem_ctx_param@basic-default:
      fi-pnv-d510:        INCOMPLETE (fdo#106007) -> SKIP

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-cfl-8109u:       INCOMPLETE (fdo#106070, fdo#108126) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#106007 https://bugs.freedesktop.org/show_bug.cgi?id=106007
  fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
  fdo#108126 https://bugs.freedesktop.org/show_bug.cgi?id=108126


== Participating hosts (48 -> 42) ==

  Additional (1): fi-bdw-samus 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-ctg-p8600 fi-kbl-7560u 


== Build changes ==

    * IGT: IGT_4667 -> IGTPW_1909

  CI_DRM_4931: 826702bf60ae2b37841c051ed769b44af194fbb1 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1909: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1909/
  IGT_4667: 596f48dcd59fd2f8c16671514f3e69d4a2891374 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools



== Testlist changes ==

+igt@gem_ctx_exec@norecovery

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1909/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Patchwork]

== Series Details ==

Series: igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE
URL   : https://patchwork.freedesktop.org/series/50561/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4667_full -> IGTPW_1909_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1909_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1909_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50561/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1909_full:

  === IGT changes ===

    ==== Warnings ====

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
      shard-snb:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in IGTPW_1909_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_atomic_transition@plane-all-modeset-transition:
      shard-glk:          PASS -> INCOMPLETE (fdo#103359, k.org#198133)

    igt@kms_color@pipe-a-ctm-max:
      shard-apl:          PASS -> FAIL (fdo#108147)

    igt@kms_cursor_crc@cursor-128x128-random:
      shard-apl:          PASS -> FAIL (fdo#103232) +4

    igt@kms_cursor_crc@cursor-256x256-sliding:
      shard-glk:          PASS -> FAIL (fdo#103232) +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
      shard-apl:          PASS -> FAIL (fdo#103167) +4

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-kbl:          PASS -> FAIL (fdo#103167) +4

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
      shard-glk:          PASS -> FAIL (fdo#103167) +6

    igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
      shard-glk:          PASS -> FAIL (fdo#103166) +1
      shard-kbl:          PASS -> FAIL (fdo#103166)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
      shard-apl:          PASS -> FAIL (fdo#103166) +1

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@perf_pmu@busy-start-vecs0:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    
    ==== Possible fixes ====

    igt@drv_suspend@fence-restore-untiled:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@gem_exec_big:
      shard-hsw:          TIMEOUT (fdo#107937) -> PASS

    igt@gem_mmap_gtt@medium-copy:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-snb:          DMESG-WARN (fdo#107956) -> SKIP

    igt@kms_ccs@pipe-a-bad-pixel-format:
      shard-apl:          DMESG-WARN (fdo#105602, fdo#103558) -> PASS +6

    igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
      shard-kbl:          FAIL (fdo#108145) -> PASS

    igt@kms_cursor_crc@cursor-128x128-dpms:
      shard-kbl:          FAIL (fdo#103232) -> PASS

    igt@kms_cursor_crc@cursor-128x128-suspend:
      shard-apl:          FAIL (fdo#103191, fdo#103232) -> PASS
      shard-kbl:          FAIL (fdo#103191, fdo#103232) -> PASS

    igt@kms_cursor_crc@cursor-128x42-onscreen:
      shard-glk:          FAIL (fdo#103232) -> PASS +4

    igt@kms_cursor_crc@cursor-256x256-suspend:
      shard-apl:          DMESG-FAIL (fdo#105602, fdo#103558) -> PASS

    igt@kms_cursor_crc@cursor-64x21-random:
      shard-apl:          FAIL (fdo#103232) -> PASS +7

    igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
      shard-hsw:          FAIL (fdo#105767) -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
      shard-apl:          FAIL (fdo#103167) -> PASS +3

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
      shard-glk:          FAIL (fdo#103167) -> PASS +2
      shard-kbl:          FAIL (fdo#103167) -> PASS +1

    {igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb}:
      shard-apl:          FAIL (fdo#108145) -> PASS

    igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
      shard-apl:          FAIL (fdo#103166) -> PASS +2

    igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
      shard-kbl:          FAIL (fdo#103166) -> PASS +1

    igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
      shard-glk:          FAIL (fdo#103166) -> PASS +1

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
  fdo#107937 https://bugs.freedesktop.org/show_bug.cgi?id=107937
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
  fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (6 -> 5) ==

  Missing    (1): shard-skl 


== Build changes ==

    * IGT: IGT_4667 -> IGTPW_1909
    * Linux: CI_DRM_4930 -> CI_DRM_4931

  CI_DRM_4930: bf1bd5e86f267d58ac68c342fcfff70e8ef1fd34 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4931: 826702bf60ae2b37841c051ed769b44af194fbb1 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1909: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1909/
  IGT_4667: 596f48dcd59fd2f8c16671514f3e69d4a2891374 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1909/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t v2] igt/gem_ctx_exec: Exercise I915_CONTEXT_PARAM_RECOVERABLE

[Mika Kuoppala]

Chris Wilson <chris@chris-wilson.co.uk> writes:

> When RECOVERABLE is set, the kernel will attempt to automatically recover
> a context after a hang. But if it is unset, the kernel will ban the
> guilty context on a hang, preventing subsequent execution.
>
> v2: Create a has_recoverable_param()
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@intel.com>
> ---
>  tests/gem_ctx_exec.c | 48 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/tests/gem_ctx_exec.c b/tests/gem_ctx_exec.c
> index 908b59af..44e6ec2b 100644
> --- a/tests/gem_ctx_exec.c
> +++ b/tests/gem_ctx_exec.c
> @@ -147,6 +147,51 @@ static void invalid_context(int fd, unsigned ring, uint32_t handle)
>  	igt_assert_eq(__gem_execbuf(fd, &execbuf), -ENOENT);
>  }
>  
> +static bool has_recoverable_param(int i915)
> +{
> +	struct drm_i915_gem_context_param param = {
> +		.param = 0x7,
> +	};
> +
> +	return __gem_context_get_param(i915, &param) == 0;
> +}
> +
> +static void norecovery(int i915)
> +{
> +	igt_require(has_recoverable_param(i915));
> +
> +	for (int pass = 1; pass >= 0; pass--) {
> +		struct drm_i915_gem_context_param param = {
> +			.ctx_id = gem_context_create(i915),
> +			.param = 0x7,
> +			.value = pass,
> +		};

Now it springs into mind that s/pass/recover would
have added readability.

But not enough for respin imo,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

> +		int expect = pass == 0 ? -EIO : 0;
> +		igt_spin_t *spin;
> +
> +		gem_context_set_param(i915, &param);
> +
> +		param.value = !pass;
> +		gem_context_get_param(i915, &param);
> +		igt_assert_eq(param.value, pass);
> +
> +		spin = __igt_spin_batch_new(i915,
> +					    .ctx = param.ctx_id,
> +					    .flags = IGT_SPIN_POLL_RUN);
> +		igt_assert(spin->running);
> +
> +		while (!READ_ONCE(*spin->running))
> +			;
> +		igt_force_gpu_reset(i915);
> +
> +		igt_spin_batch_end(spin);
> +		igt_assert_eq(__gem_execbuf(i915, &spin->execbuf), expect);
> +		igt_spin_batch_free(i915, spin);
> +
> +		gem_context_destroy(i915, param.ctx_id);
> +	}
> +}
> +
>  igt_main
>  {
>  	const uint32_t batch[2] = { 0, MI_BATCH_BUFFER_END };
> @@ -190,6 +235,9 @@ igt_main
>  	igt_subtest("eviction")
>  		big_exec(fd, handle, 0);
>  
> +	igt_subtest("norecovery")
> +		norecovery(fd);
> +
>  	igt_subtest("reset-pin-leak") {
>  		int i;
>  
> -- 
> 2.19.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx