All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto: caam/qi2 - add CONFIG_NETDEVICES dependency
@ 2018-09-26 13:00 ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2018-09-26 13:00 UTC (permalink / raw)
  To: Horia Geantă, Aymen Sghaier, Herbert Xu, David S. Miller
  Cc: Arnd Bergmann, linux-crypto, linux-kernel

This driver implements a (part of a) network driver, and fails to
build if we have turned off networking support:

drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb':
caamalg_qi2.c:(.text+0x577c): undefined reference to `napi_schedule_prep'
caamalg_qi2.c:(.text+0x578c): undefined reference to `__napi_schedule_irqoff'
drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_poll':
caamalg_qi2.c:(.text+0x59b8): undefined reference to `napi_complete_done'
drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_remove':
caamalg_qi2.c:(.text.unlikely+0x4e0): undefined reference to `napi_disable'
caamalg_qi2.c:(.text.unlikely+0x4e8): undefined reference to `netif_napi_del'
drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_setup':
caamalg_qi2.c:(.text.unlikely+0xc98): undefined reference to `netif_napi_add'

>From what I can tell, CONFIG_NETDEVICES is the correct dependency here,
and adding it fixes the randconfig failures.

Fixes: 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/crypto/caam/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/caam/Kconfig b/drivers/crypto/caam/Kconfig
index ec42fb652167..619a2c929f3e 100644
--- a/drivers/crypto/caam/Kconfig
+++ b/drivers/crypto/caam/Kconfig
@@ -156,6 +156,7 @@ endif # CRYPTO_DEV_FSL_CAAM
 config CRYPTO_DEV_FSL_DPAA2_CAAM
 	tristate "QorIQ DPAA2 CAAM (DPSECI) driver"
 	depends on FSL_MC_DPIO
+	depends on NETDEVICES
 	select CRYPTO_DEV_FSL_CAAM_COMMON
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_AUTHENC
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] crypto: caam/qi2 - add CONFIG_NETDEVICES dependency
@ 2018-09-26 13:00 ` Arnd Bergmann
  0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2018-09-26 13:00 UTC (permalink / raw)
  To: Horia Geantă, Aymen Sghaier, Herbert Xu, David S. Miller
  Cc: Arnd Bergmann, linux-crypto, linux-kernel

This driver implements a (part of a) network driver, and fails to
build if we have turned off networking support:

drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb':
caamalg_qi2.c:(.text+0x577c): undefined reference to `napi_schedule_prep'
caamalg_qi2.c:(.text+0x578c): undefined reference to `__napi_schedule_irqoff'
drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_poll':
caamalg_qi2.c:(.text+0x59b8): undefined reference to `napi_complete_done'
drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_remove':
caamalg_qi2.c:(.text.unlikely+0x4e0): undefined reference to `napi_disable'
caamalg_qi2.c:(.text.unlikely+0x4e8): undefined reference to `netif_napi_del'
drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_setup':
caamalg_qi2.c:(.text.unlikely+0xc98): undefined reference to `netif_napi_add'

From what I can tell, CONFIG_NETDEVICES is the correct dependency here,
and adding it fixes the randconfig failures.

Fixes: 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/crypto/caam/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/crypto/caam/Kconfig b/drivers/crypto/caam/Kconfig
index ec42fb652167..619a2c929f3e 100644
--- a/drivers/crypto/caam/Kconfig
+++ b/drivers/crypto/caam/Kconfig
@@ -156,6 +156,7 @@ endif # CRYPTO_DEV_FSL_CAAM
 config CRYPTO_DEV_FSL_DPAA2_CAAM
 	tristate "QorIQ DPAA2 CAAM (DPSECI) driver"
 	depends on FSL_MC_DPIO
+	depends on NETDEVICES
 	select CRYPTO_DEV_FSL_CAAM_COMMON
 	select CRYPTO_BLKCIPHER
 	select CRYPTO_AUTHENC
-- 
2.18.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: caam/qi2 - add CONFIG_NETDEVICES dependency
  2018-09-26 13:00 ` Arnd Bergmann
  (?)
@ 2018-09-26 13:07 ` Horia Geanta
  -1 siblings, 0 replies; 4+ messages in thread
From: Horia Geanta @ 2018-09-26 13:07 UTC (permalink / raw)
  To: Arnd Bergmann, Aymen Sghaier, Herbert Xu, David S. Miller
  Cc: linux-crypto, linux-kernel

On 9/26/2018 4:01 PM, Arnd Bergmann wrote:
> This driver implements a (part of a) network driver, and fails to
> build if we have turned off networking support:
> 
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb':
> caamalg_qi2.c:(.text+0x577c): undefined reference to `napi_schedule_prep'
> caamalg_qi2.c:(.text+0x578c): undefined reference to `__napi_schedule_irqoff'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_poll':
> caamalg_qi2.c:(.text+0x59b8): undefined reference to `napi_complete_done'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_remove':
> caamalg_qi2.c:(.text.unlikely+0x4e0): undefined reference to `napi_disable'
> caamalg_qi2.c:(.text.unlikely+0x4e8): undefined reference to `netif_napi_del'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_setup':
> caamalg_qi2.c:(.text.unlikely+0xc98): undefined reference to `netif_napi_add'
> 
> From what I can tell, CONFIG_NETDEVICES is the correct dependency here,
> and adding it fixes the randconfig failures.
> 
> Fixes: 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Horia Geantă <horia.geanta@nxp.com>

Thanks,
Horia

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: caam/qi2 - add CONFIG_NETDEVICES dependency
  2018-09-26 13:00 ` Arnd Bergmann
  (?)
  (?)
@ 2018-10-05  2:29 ` Herbert Xu
  -1 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2018-10-05  2:29 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Horia Geantă,
	Aymen Sghaier, David S. Miller, linux-crypto, linux-kernel

On Wed, Sep 26, 2018 at 03:00:34PM +0200, Arnd Bergmann wrote:
> This driver implements a (part of a) network driver, and fails to
> build if we have turned off networking support:
> 
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_fqdan_cb':
> caamalg_qi2.c:(.text+0x577c): undefined reference to `napi_schedule_prep'
> caamalg_qi2.c:(.text+0x578c): undefined reference to `__napi_schedule_irqoff'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_poll':
> caamalg_qi2.c:(.text+0x59b8): undefined reference to `napi_complete_done'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_caam_remove':
> caamalg_qi2.c:(.text.unlikely+0x4e0): undefined reference to `napi_disable'
> caamalg_qi2.c:(.text.unlikely+0x4e8): undefined reference to `netif_napi_del'
> drivers/crypto/caam/caamalg_qi2.o: In function `dpaa2_dpseci_setup':
> caamalg_qi2.c:(.text.unlikely+0xc98): undefined reference to `netif_napi_add'
> 
> >From what I can tell, CONFIG_NETDEVICES is the correct dependency here,
> and adding it fixes the randconfig failures.
> 
> Fixes: 8d818c105501 ("crypto: caam/qi2 - add DPAA2-CAAM driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-05  2:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 13:00 [PATCH] crypto: caam/qi2 - add CONFIG_NETDEVICES dependency Arnd Bergmann
2018-09-26 13:00 ` Arnd Bergmann
2018-09-26 13:07 ` Horia Geanta
2018-10-05  2:29 ` Herbert Xu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.