* [PATCH] mmc: tifm_sd: Mark expected switch fall-through
@ 2018-10-05 9:54 Gustavo A. R. Silva
2018-10-05 13:54 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-05 9:54 UTC (permalink / raw)
To: Alex Dubov, Ulf Hansson; +Cc: linux-mmc, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case, I replaced the
"deliberate fall-through" comment with a proper "fall through"
at the bottom of the case, which is what GCC is expecting to find.
Addresses-Coverity-ID: 1373887 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/mmc/host/tifm_sd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/tifm_sd.c b/drivers/mmc/host/tifm_sd.c
index a3d8380..b6644ce 100644
--- a/drivers/mmc/host/tifm_sd.c
+++ b/drivers/mmc/host/tifm_sd.c
@@ -336,7 +336,8 @@ static unsigned int tifm_sd_op_flags(struct mmc_command *cmd)
rc |= TIFM_MMCSD_RSP_R0;
break;
case MMC_RSP_R1B:
- rc |= TIFM_MMCSD_RSP_BUSY; // deliberate fall-through
+ rc |= TIFM_MMCSD_RSP_BUSY;
+ /* fall-through */
case MMC_RSP_R1:
rc |= TIFM_MMCSD_RSP_R1;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: tifm_sd: Mark expected switch fall-through
2018-10-05 9:54 [PATCH] mmc: tifm_sd: Mark expected switch fall-through Gustavo A. R. Silva
@ 2018-10-05 13:54 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2018-10-05 13:54 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Alex Dubov, linux-mmc, Linux Kernel Mailing List
On 5 October 2018 at 11:54, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case, I replaced the
> "deliberate fall-through" comment with a proper "fall through"
> at the bottom of the case, which is what GCC is expecting to find.
>
> Addresses-Coverity-ID: 1373887 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/tifm_sd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/tifm_sd.c b/drivers/mmc/host/tifm_sd.c
> index a3d8380..b6644ce 100644
> --- a/drivers/mmc/host/tifm_sd.c
> +++ b/drivers/mmc/host/tifm_sd.c
> @@ -336,7 +336,8 @@ static unsigned int tifm_sd_op_flags(struct mmc_command *cmd)
> rc |= TIFM_MMCSD_RSP_R0;
> break;
> case MMC_RSP_R1B:
> - rc |= TIFM_MMCSD_RSP_BUSY; // deliberate fall-through
> + rc |= TIFM_MMCSD_RSP_BUSY;
> + /* fall-through */
> case MMC_RSP_R1:
> rc |= TIFM_MMCSD_RSP_R1;
> break;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-05 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 9:54 [PATCH] mmc: tifm_sd: Mark expected switch fall-through Gustavo A. R. Silva
2018-10-05 13:54 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.