[PATCH] drm/vblank: Remove old-style comments

[PATCH] drm/vblank: Remove old-style comments

[Daniel Vetter]

Somehow I forgot a few when typing all the shiny new kerneldoc. Drop
them.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 include/drm/drm_vblank.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/drm/drm_vblank.h b/include/drm/drm_vblank.h
index d25a9603ab57..6ad9630d4f48 100644
--- a/include/drm/drm_vblank.h
+++ b/include/drm/drm_vblank.h
@@ -95,7 +95,7 @@ struct drm_vblank_crtc {
 	/**
 	 * @queue: Wait queue for vblank waiters.
 	 */
-	wait_queue_head_t queue;	/**< VBLANK wait queue */
+	wait_queue_head_t queue;
 	/**
 	 * @disable_timer: Disable timer for the delayed vblank disabling
 	 * hysteresis logic. Vblank disabling is controlled through the
@@ -107,7 +107,7 @@ struct drm_vblank_crtc {
 	/**
 	 * @seqlock: Protect vblank count and time.
 	 */
-	seqlock_t seqlock;		/* protects vblank count and time */
+	seqlock_t seqlock;
 
 	/**
 	 * @count: Current software vblank counter.
@@ -123,7 +123,7 @@ struct drm_vblank_crtc {
 	 * this refcount reaches 0 can the hardware interrupt be disabled using
 	 * @disable_timer.
 	 */
-	atomic_t refcount;		/* number of users of vblank interruptsper crtc */
+	atomic_t refcount;
 	/**
 	 * @last: Protected by &drm_device.vbl_lock, used for wraparound handling.
 	 */
@@ -136,7 +136,7 @@ struct drm_vblank_crtc {
 	 * call drm_crtc_vblank_off() and drm_crtc_vblank_on(), which explicitly
 	 * save and restore the vblank count.
 	 */
-	unsigned int inmodeset;		/* Display driver is setting mode */
+	unsigned int inmodeset;
 	/**
 	 * @pipe: drm_crtc_index() of the &drm_crtc corresponding to this
 	 * structure.
-- 
2.19.0.rc2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/vblank: Remove old-style comments

[Ville Syrjälä]

On Fri, Oct 05, 2018 at 09:36:36AM +0200, Daniel Vetter wrote:
> Somehow I forgot a few when typing all the shiny new kerneldoc. Drop
> them.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  include/drm/drm_vblank.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/drm/drm_vblank.h b/include/drm/drm_vblank.h
> index d25a9603ab57..6ad9630d4f48 100644
> --- a/include/drm/drm_vblank.h
> +++ b/include/drm/drm_vblank.h
> @@ -95,7 +95,7 @@ struct drm_vblank_crtc {
>  	/**
>  	 * @queue: Wait queue for vblank waiters.
>  	 */
> -	wait_queue_head_t queue;	/**< VBLANK wait queue */
> +	wait_queue_head_t queue;
>  	/**
>  	 * @disable_timer: Disable timer for the delayed vblank disabling
>  	 * hysteresis logic. Vblank disabling is controlled through the
> @@ -107,7 +107,7 @@ struct drm_vblank_crtc {
>  	/**
>  	 * @seqlock: Protect vblank count and time.
>  	 */
> -	seqlock_t seqlock;		/* protects vblank count and time */
> +	seqlock_t seqlock;
>  
>  	/**
>  	 * @count: Current software vblank counter.
> @@ -123,7 +123,7 @@ struct drm_vblank_crtc {
>  	 * this refcount reaches 0 can the hardware interrupt be disabled using
>  	 * @disable_timer.
>  	 */
> -	atomic_t refcount;		/* number of users of vblank interruptsper crtc */
> +	atomic_t refcount;
>  	/**
>  	 * @last: Protected by &drm_device.vbl_lock, used for wraparound handling.
>  	 */
> @@ -136,7 +136,7 @@ struct drm_vblank_crtc {
>  	 * call drm_crtc_vblank_off() and drm_crtc_vblank_on(), which explicitly
>  	 * save and restore the vblank count.
>  	 */
> -	unsigned int inmodeset;		/* Display driver is setting mode */
> +	unsigned int inmodeset;
>  	/**
>  	 * @pipe: drm_crtc_index() of the &drm_crtc corresponding to this
>  	 * structure.
> -- 
> 2.19.0.rc2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/vblank: Remove old-style comments

[Daniel Vetter]

On Fri, Oct 05, 2018 at 01:14:18PM +0300, Ville Syrjälä wrote:
> On Fri, Oct 05, 2018 at 09:36:36AM +0200, Daniel Vetter wrote:
> > Somehow I forgot a few when typing all the shiny new kerneldoc. Drop
> > them.
> > 
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Applied, thanks for reviewing.
-Daniel

> 
> > ---
> >  include/drm/drm_vblank.h | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/include/drm/drm_vblank.h b/include/drm/drm_vblank.h
> > index d25a9603ab57..6ad9630d4f48 100644
> > --- a/include/drm/drm_vblank.h
> > +++ b/include/drm/drm_vblank.h
> > @@ -95,7 +95,7 @@ struct drm_vblank_crtc {
> >  	/**
> >  	 * @queue: Wait queue for vblank waiters.
> >  	 */
> > -	wait_queue_head_t queue;	/**< VBLANK wait queue */
> > +	wait_queue_head_t queue;
> >  	/**
> >  	 * @disable_timer: Disable timer for the delayed vblank disabling
> >  	 * hysteresis logic. Vblank disabling is controlled through the
> > @@ -107,7 +107,7 @@ struct drm_vblank_crtc {
> >  	/**
> >  	 * @seqlock: Protect vblank count and time.
> >  	 */
> > -	seqlock_t seqlock;		/* protects vblank count and time */
> > +	seqlock_t seqlock;
> >  
> >  	/**
> >  	 * @count: Current software vblank counter.
> > @@ -123,7 +123,7 @@ struct drm_vblank_crtc {
> >  	 * this refcount reaches 0 can the hardware interrupt be disabled using
> >  	 * @disable_timer.
> >  	 */
> > -	atomic_t refcount;		/* number of users of vblank interruptsper crtc */
> > +	atomic_t refcount;
> >  	/**
> >  	 * @last: Protected by &drm_device.vbl_lock, used for wraparound handling.
> >  	 */
> > @@ -136,7 +136,7 @@ struct drm_vblank_crtc {
> >  	 * call drm_crtc_vblank_off() and drm_crtc_vblank_on(), which explicitly
> >  	 * save and restore the vblank count.
> >  	 */
> > -	unsigned int inmodeset;		/* Display driver is setting mode */
> > +	unsigned int inmodeset;
> >  	/**
> >  	 * @pipe: drm_crtc_index() of the &drm_crtc corresponding to this
> >  	 * structure.
> > -- 
> > 2.19.0.rc2
> > 
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> -- 
> Ville Syrjälä
> Intel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel