* [Qemu-devel] [PATCH] crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS
@ 2018-10-05 14:52 Alberto Garcia
2018-10-05 14:58 ` Daniel P. Berrangé
2018-11-12 14:45 ` Alberto Garcia
0 siblings, 2 replies; 4+ messages in thread
From: Alberto Garcia @ 2018-10-05 14:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Alberto Garcia, qemu-block, Daniel P . Berrangé
The values specified in the documentation don't match the actual
defaults set in qcrypto_block_luks_create().
Signed-off-by: Alberto Garcia <berto@igalia.com>
---
qapi/crypto.json | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qapi/crypto.json b/qapi/crypto.json
index a51b434412..b2a4cff683 100644
--- a/qapi/crypto.json
+++ b/qapi/crypto.json
@@ -181,11 +181,11 @@
# The options that apply to LUKS encryption format initialization
#
# @cipher-alg: the cipher algorithm for data encryption
-# Currently defaults to 'aes'.
+# Currently defaults to 'aes-256'.
# @cipher-mode: the cipher mode for data encryption
-# Currently defaults to 'cbc'
+# Currently defaults to 'xts'
# @ivgen-alg: the initialization vector generator
-# Currently defaults to 'essiv'
+# Currently defaults to 'plain64'
# @ivgen-hash-alg: the initialization vector generator hash
# Currently defaults to 'sha256'
# @hash-alg: the master key hash algorithm
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS
2018-10-05 14:52 [Qemu-devel] [PATCH] crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS Alberto Garcia
@ 2018-10-05 14:58 ` Daniel P. Berrangé
2018-11-12 14:45 ` Alberto Garcia
1 sibling, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2018-10-05 14:58 UTC (permalink / raw)
To: Alberto Garcia; +Cc: qemu-devel, qemu-block
On Fri, Oct 05, 2018 at 04:52:02PM +0200, Alberto Garcia wrote:
> The values specified in the documentation don't match the actual
> defaults set in qcrypto_block_luks_create().
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> qapi/crypto.json | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS
2018-10-05 14:52 [Qemu-devel] [PATCH] crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS Alberto Garcia
2018-10-05 14:58 ` Daniel P. Berrangé
@ 2018-11-12 14:45 ` Alberto Garcia
2018-11-12 14:48 ` Daniel P. Berrangé
1 sibling, 1 reply; 4+ messages in thread
From: Alberto Garcia @ 2018-11-12 14:45 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, Daniel P. Berrangé
ping
On Fri 05 Oct 2018 04:52:02 PM CEST, Alberto Garcia wrote:
> The values specified in the documentation don't match the actual
> defaults set in qcrypto_block_luks_create().
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> qapi/crypto.json | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index a51b434412..b2a4cff683 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -181,11 +181,11 @@
> # The options that apply to LUKS encryption format initialization
> #
> # @cipher-alg: the cipher algorithm for data encryption
> -# Currently defaults to 'aes'.
> +# Currently defaults to 'aes-256'.
> # @cipher-mode: the cipher mode for data encryption
> -# Currently defaults to 'cbc'
> +# Currently defaults to 'xts'
> # @ivgen-alg: the initialization vector generator
> -# Currently defaults to 'essiv'
> +# Currently defaults to 'plain64'
> # @ivgen-hash-alg: the initialization vector generator hash
> # Currently defaults to 'sha256'
> # @hash-alg: the master key hash algorithm
> --
> 2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS
2018-11-12 14:45 ` Alberto Garcia
@ 2018-11-12 14:48 ` Daniel P. Berrangé
0 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2018-11-12 14:48 UTC (permalink / raw)
To: Alberto Garcia; +Cc: qemu-devel, qemu-block
On Mon, Nov 12, 2018 at 03:45:45PM +0100, Alberto Garcia wrote:
> ping
Sorry, I should have said I queued this patch when adding my previous R-b.
> On Fri 05 Oct 2018 04:52:02 PM CEST, Alberto Garcia wrote:
> > The values specified in the documentation don't match the actual
> > defaults set in qcrypto_block_luks_create().
> >
> > Signed-off-by: Alberto Garcia <berto@igalia.com>
> > ---
> > qapi/crypto.json | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/qapi/crypto.json b/qapi/crypto.json
> > index a51b434412..b2a4cff683 100644
> > --- a/qapi/crypto.json
> > +++ b/qapi/crypto.json
> > @@ -181,11 +181,11 @@
> > # The options that apply to LUKS encryption format initialization
> > #
> > # @cipher-alg: the cipher algorithm for data encryption
> > -# Currently defaults to 'aes'.
> > +# Currently defaults to 'aes-256'.
> > # @cipher-mode: the cipher mode for data encryption
> > -# Currently defaults to 'cbc'
> > +# Currently defaults to 'xts'
> > # @ivgen-alg: the initialization vector generator
> > -# Currently defaults to 'essiv'
> > +# Currently defaults to 'plain64'
> > # @ivgen-hash-alg: the initialization vector generator hash
> > # Currently defaults to 'sha256'
> > # @hash-alg: the master key hash algorithm
> > --
> > 2.11.0
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-12 14:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05 14:52 [Qemu-devel] [PATCH] crypto: Fix defaults in QCryptoBlockCreateOptionsLUKS Alberto Garcia
2018-10-05 14:58 ` Daniel P. Berrangé
2018-11-12 14:45 ` Alberto Garcia
2018-11-12 14:48 ` Daniel P. Berrangé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.