* [PATCH 01/18] docs/man: Fix two typos detected by the Debian lintian tool
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:40 ` Wei Liu
2018-10-05 17:29 ` [PATCH 02/18] tools/xentrace/xenalyze: Fix typos detected by lintian Ian Jackson
` (17 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel; +Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson, Wei Liu
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
docs/man/xenstore.pod.1 | 2 +-
docs/man/xl.pod.1.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/man/xenstore.pod.1 b/docs/man/xenstore.pod.1
index 74172891e2..dd8f80647d 100644
--- a/docs/man/xenstore.pod.1
+++ b/docs/man/xenstore.pod.1
@@ -18,7 +18,7 @@ Sets the permissions of keys.
=item B<xenstore-exists>(1)
-Test for the existance of a key.
+Test for the existence of a key.
=item B<xenstore-list>(1)
diff --git a/docs/man/xl.pod.1.in b/docs/man/xl.pod.1.in
index b74764dcd3..18006880d6 100644
--- a/docs/man/xl.pod.1.in
+++ b/docs/man/xl.pod.1.in
@@ -1398,7 +1398,7 @@ Creates a new network device in the domain specified by I<domain-id>.
I<network-device> describes the device to attach, using the same format as the
B<vif> string in the domain config file. See L<xl.cfg(5)> and
L<xl-network-configuration(5)>
-for more informations.
+for more information.
Note that only attaching PV network interfaces is supported.
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 02/18] tools/xentrace/xenalyze: Fix typos detected by lintian
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
2018-10-05 17:29 ` [PATCH 01/18] docs/man: Fix two typos detected by the Debian lintian tool Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:29 ` George Dunlap
2018-10-05 17:29 ` [PATCH 03/18] Various: Fix typos `unkown', `retreive' (detected by lintian) Ian Jackson
` (16 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: George Dunlap, Ian Jackson, Hans van Kranenburg, Ian Jackson, Wei Liu
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/xentrace/xenalyze.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index 5ed0a12327..aa894673ad 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -9224,7 +9224,7 @@ void process_cpu_change(struct pcpu_info *p) {
/* File sanity check */
if(p->file_offset != p->next_cpu_change_offset) {
- fprintf(warn, "Strange, pcpu %d expected offet %llx, actual %llx!\n",
+ fprintf(warn, "Strange, pcpu %d expected offset %llx, actual %llx!\n",
p->pid, (unsigned long long)p->next_cpu_change_offset,
(unsigned long long)p->file_offset);
}
@@ -9673,7 +9673,7 @@ ssize_t read_record(struct pcpu_info * p) {
}
/*
- * This funciton gets called for every record when doing dump. Try to
+ * This function gets called for every record when doing dump. Try to
* make it efficient by changing the minimum amount from the last
* call. Do this by:
* - Keeping track of the last pcpu called, so we can just set that to -
@@ -10629,7 +10629,7 @@ const struct argp_option cmd_opts[] = {
.key = OPT_SCATTERPLOT_EXTINT_CYCLES,
.arg = "vector",
.group = OPT_GROUP_EXTRA,
- .doc = "Output a scatterplot of vmexit cycles for external interrupts of the given vector as a funciton of time.", },
+ .doc = "Output a scatterplot of vmexit cycles for external interrupts of the given vector as a function of time.", },
{ .name = "scatterplot-unpin-promote",
.key = OPT_SCATTERPLOT_UNPIN_PROMOTE,
@@ -10756,7 +10756,7 @@ const struct argp_option cmd_opts[] = {
.key = OPT_MMIO_ENUMERATION_SKIP_VGA,
.arg = "[0|1]",
.group = OPT_GROUP_SUMMARY,
- .doc = "Control whether we enumerate MMIO accesses to the VGA area, which can be extremly high during boot. Default: 0", },
+ .doc = "Control whether we enumerate MMIO accesses to the VGA area, which can be extremely high during boot. Default: 0", },
{ .name = "sample-size",
.key = OPT_SAMPLE_SIZE,
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 03/18] Various: Fix typos `unkown', `retreive' (detected by lintian)
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
2018-10-05 17:29 ` [PATCH 01/18] docs/man: Fix two typos detected by the Debian lintian tool Ian Jackson
2018-10-05 17:29 ` [PATCH 02/18] tools/xentrace/xenalyze: Fix typos detected by lintian Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:42 ` Wei Liu
2018-10-05 17:29 ` [PATCH 04/18] Various: Fix typo `occured' Ian Jackson
` (15 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Ian Jackson, Hans van Kranenburg,
Julien Grall, Yang Hongyang, Shriram Rajagopalan, Ian Jackson
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/hotplug/Linux/block-drbd-probe | 2 +-
tools/libxc/xc_dom_elfloader.c | 2 +-
tools/libxl/libxl_dm.c | 2 +-
tools/libxl/libxl_event.h | 2 +-
tools/libxl/libxl_qmp.c | 2 +-
xen/include/xen/libfdt/libfdt.h | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/hotplug/Linux/block-drbd-probe b/tools/hotplug/Linux/block-drbd-probe
index 635d9f9a52..7b2968b6d9 100755
--- a/tools/hotplug/Linux/block-drbd-probe
+++ b/tools/hotplug/Linux/block-drbd-probe
@@ -20,7 +20,7 @@
# Return value:
# 0: the device is drbd device
# 1: the device is not drbd device
-# 2: unkown error
+# 2: unknown error
# 3: the drbd device does not use protocol D
# 4: the drbd device is not ready
diff --git a/tools/libxc/xc_dom_elfloader.c b/tools/libxc/xc_dom_elfloader.c
index 26b2846365..82b5f2ee79 100644
--- a/tools/libxc/xc_dom_elfloader.c
+++ b/tools/libxc/xc_dom_elfloader.c
@@ -87,7 +87,7 @@ static char *xc_dom_guest_type(struct xc_dom_image *dom,
return "xen-3.0-x86_64";
default:
xc_dom_panic(dom->xch, XC_INVALID_KERNEL,
- "%s: unkown image type %"PRIu64,
+ "%s: unknown image type %"PRIu64,
__FUNCTION__, machine);
return NULL;
}
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index abd31ee6f2..26eb16af34 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -992,7 +992,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
/*
* Do not use any of the user-provided config files in sysconfdir,
- * avoiding unkown and uncontrolled configuration.
+ * avoiding unknown and uncontrolled configuration.
*/
flexarray_append(dm_args, "-no-user-config");
diff --git a/tools/libxl/libxl_event.h b/tools/libxl/libxl_event.h
index 1ea789e231..d1517f7456 100644
--- a/tools/libxl/libxl_event.h
+++ b/tools/libxl/libxl_event.h
@@ -169,7 +169,7 @@ void libxl_event_register_callbacks(libxl_ctx *ctx,
*
* Applications should ensure that they eventually retrieve every
* event using libxl_event_check or libxl_event_wait, since events
- * which occur but are not retreived by the application will be queued
+ * which occur but are not retrieved by the application will be queued
* inside libxl indefinitely. libxl_event_check/_wait may be O(n)
* where n is the number of queued events which do not match the
* criteria specified in the arguments to check/wait.
diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
index bdf1778cf1..6a5c997546 100644
--- a/tools/libxl/libxl_qmp.c
+++ b/tools/libxl/libxl_qmp.c
@@ -238,7 +238,7 @@ static int qmp_register_vnc_callback(libxl__qmp_handler *qmp,
port = libxl__json_object_get_string(obj);
if (!addr || !port) {
- LOGD(ERROR, qmp->domid, "Failed to retreive VNC connect information.");
+ LOGD(ERROR, qmp->domid, "Failed to retrieve VNC connect information.");
goto out;
}
diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h
index d6b94a1836..7c75688a39 100644
--- a/xen/include/xen/libfdt/libfdt.h
+++ b/xen/include/xen/libfdt/libfdt.h
@@ -594,7 +594,7 @@ const char *fdt_get_alias_namelen(const void *fdt,
const char *name, int namelen);
/**
- * fdt_get_alias - retreive the path referenced by a given alias
+ * fdt_get_alias - retrieve the path referenced by a given alias
* @fdt: pointer to the device tree blob
* @name: name of the alias th look up
*
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 03/18] Various: Fix typos `unkown', `retreive' (detected by lintian)
2018-10-05 17:29 ` [PATCH 03/18] Various: Fix typos `unkown', `retreive' (detected by lintian) Ian Jackson
@ 2018-10-08 9:42 ` Wei Liu
0 siblings, 0 replies; 48+ messages in thread
From: Wei Liu @ 2018-10-08 9:42 UTC (permalink / raw)
To: Ian Jackson
Cc: Stefano Stabellini, Wei Liu, Ian Jackson, Hans van Kranenburg,
Julien Grall, Yang Hongyang, Shriram Rajagopalan, xen-devel
On Fri, Oct 05, 2018 at 06:29:02PM +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 04/18] Various: Fix typo `occured'
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (2 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 03/18] Various: Fix typos `unkown', `retreive' (detected by lintian) Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:07 ` Jan Beulich
2018-10-08 9:30 ` George Dunlap
2018-10-05 17:29 ` [PATCH 05/18] Various: Fix typo `reseting' Ian Jackson
` (14 subsequent siblings)
18 siblings, 2 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Suravee Suthikulpanit,
Konrad Rzeszutek Wilk, George Dunlap, Andrew Cooper, Ian Jackson,
Tim Deegan, Hans van Kranenburg, Julien Grall, Jan Beulich,
Ian Jackson, Boris Ostrovsky, Brian Woods
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/xl/xl_flask.c | 2 +-
xen/arch/arm/arm64/lib/memcmp.S | 2 +-
xen/arch/x86/hvm/hvm.c | 2 +-
xen/arch/x86/hvm/svm/intr.c | 2 +-
xen/drivers/passthrough/arm/smmu.c | 2 +-
xen/include/efi/efiprot.h | 2 +-
xen/include/public/xen.h | 2 +-
xen/include/xen/sched.h | 2 +-
8 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/xl/xl_flask.c b/tools/xl/xl_flask.c
index 523769750b..6b11f091cc 100644
--- a/tools/xl/xl_flask.c
+++ b/tools/xl/xl_flask.c
@@ -75,7 +75,7 @@ int main_setenforce(int argc, char **argv)
fprintf(stderr, "Flask XSM disabled\n");
}
else
- fprintf(stderr, "error occured while setting enforcing mode (%i)\n", ret);
+ fprintf(stderr, "error occurred while setting enforcing mode (%i)\n", ret);
}
return ret;
diff --git a/xen/arch/arm/arm64/lib/memcmp.S b/xen/arch/arm/arm64/lib/memcmp.S
index 2eb81565ef..87c2537ffe 100644
--- a/xen/arch/arm/arm64/lib/memcmp.S
+++ b/xen/arch/arm/arm64/lib/memcmp.S
@@ -210,7 +210,7 @@ CPU_LE( lsr tmp2, tmp2, tmp1 )
.Lunequal_proc:
cbz diff, .Lremain8
-/*There is differnence occured in the latest comparison.*/
+/*There is differnence occurred in the latest comparison.*/
.Lnot_limit:
/*
* For little endian,reverse the low significant equal bits into MSB,then
diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
index fa994a36a4..6c1301df42 100644
--- a/xen/arch/x86/hvm/hvm.c
+++ b/xen/arch/x86/hvm/hvm.c
@@ -1696,7 +1696,7 @@ int hvm_hap_nested_page_fault(paddr_t gpa, unsigned long gla,
case NESTEDHVM_PAGEFAULT_RETRY:
return 1;
case NESTEDHVM_PAGEFAULT_L1_ERROR:
- /* An error occured while translating gpa from
+ /* An error occurred while translating gpa from
* l2 guest address to l1 guest address. */
return 0;
case NESTEDHVM_PAGEFAULT_INJECT:
diff --git a/xen/arch/x86/hvm/svm/intr.c b/xen/arch/x86/hvm/svm/intr.c
index ed5b100790..79673535d1 100644
--- a/xen/arch/x86/hvm/svm/intr.c
+++ b/xen/arch/x86/hvm/svm/intr.c
@@ -159,7 +159,7 @@ void svm_intr_assist(void)
int rc;
/* l2 guest was running when an interrupt for
- * the l1 guest occured.
+ * the l1 guest occurred.
*/
rc = nestedsvm_vcpu_interrupt(v, intack);
switch (rc) {
diff --git a/xen/drivers/passthrough/arm/smmu.c b/xen/drivers/passthrough/arm/smmu.c
index 53e5823d05..b51039943c 100644
--- a/xen/drivers/passthrough/arm/smmu.c
+++ b/xen/drivers/passthrough/arm/smmu.c
@@ -2278,7 +2278,7 @@ MODULE_DEVICE_TABLE(of, arm_smmu_of_match);
/*
* Xen: We don't have refcount for allocated memory so manually free memory
- * when an error occured.
+ * when an error occurred.
*/
static int arm_smmu_device_dt_probe(struct platform_device *pdev)
{
diff --git a/xen/include/efi/efiprot.h b/xen/include/efi/efiprot.h
index 05d3afb8d9..8cf04df437 100644
--- a/xen/include/efi/efiprot.h
+++ b/xen/include/efi/efiprot.h
@@ -691,7 +691,7 @@ typedef enum {
@retval EFI_SUCCESS The Blt operation completed.
@retval EFI_INVALID_PARAMETER BltOperation is not valid.
- @retval EFI_DEVICE_ERROR A hardware error occured writting to the video buffer.
+ @retval EFI_DEVICE_ERROR A hardware error occurred writting to the video buffer.
**/
typedef
diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h
index fb1df8f293..68ee09810f 100644
--- a/xen/include/public/xen.h
+++ b/xen/include/public/xen.h
@@ -177,7 +177,7 @@ DEFINE_XEN_GUEST_HANDLE(xen_ulong_t);
#define VIRQ_XENOPROF 7 /* V. XenOprofile interrupt: new sample available */
#define VIRQ_CON_RING 8 /* G. (DOM0) Bytes received on console */
#define VIRQ_PCPU_STATE 9 /* G. (DOM0) PCPU state changed */
-#define VIRQ_MEM_EVENT 10 /* G. (DOM0) A memory event has occured */
+#define VIRQ_MEM_EVENT 10 /* G. (DOM0) A memory event has occurred */
#define VIRQ_XC_RESERVED 11 /* G. Reserved for XenClient */
#define VIRQ_ENOMEM 12 /* G. (DOM0) Low on heap memory */
#define VIRQ_XENPMU 13 /* V. PMC interrupt */
diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
index a2334ddeff..c5540fa32f 100644
--- a/xen/include/xen/sched.h
+++ b/xen/include/xen/sched.h
@@ -615,7 +615,7 @@ void __domain_crash(struct domain *d);
/*
* Called from assembly code, with an optional address to help indicate why
- * the crash occured. If addr is 0, look up address from last extable
+ * the crash occurred. If addr is 0, look up address from last extable
* redirection.
*/
void noreturn asm_domain_crash_synchronous(unsigned long addr);
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 04/18] Various: Fix typo `occured'
2018-10-05 17:29 ` [PATCH 04/18] Various: Fix typo `occured' Ian Jackson
@ 2018-10-08 9:07 ` Jan Beulich
2018-10-08 9:30 ` George Dunlap
1 sibling, 0 replies; 48+ messages in thread
From: Jan Beulich @ 2018-10-08 9:07 UTC (permalink / raw)
To: Ian Jackson
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Hans van Kranenburg, Julien Grall, Suravee Suthikulpanit,
xen-devel, Boris Ostrovsky, Brian Woods
>>> On 05.10.18 at 19:29, <ian.jackson@citrix.com> wrote:
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 04/18] Various: Fix typo `occured'
2018-10-05 17:29 ` [PATCH 04/18] Various: Fix typo `occured' Ian Jackson
2018-10-08 9:07 ` Jan Beulich
@ 2018-10-08 9:30 ` George Dunlap
1 sibling, 0 replies; 48+ messages in thread
From: George Dunlap @ 2018-10-08 9:30 UTC (permalink / raw)
To: Ian Jackson, xen-devel
Cc: Stefano Stabellini, Wei Liu, Suravee Suthikulpanit,
Konrad Rzeszutek Wilk, George Dunlap, Andrew Cooper, Ian Jackson,
Tim Deegan, Hans van Kranenburg, Julien Grall, Jan Beulich,
Boris Ostrovsky, Brian Woods
On 10/05/2018 06:29 PM, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 05/18] Various: Fix typo `reseting'
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (3 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 04/18] Various: Fix typo `occured' Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:42 ` Wei Liu
2018-10-05 17:29 ` [PATCH 06/18] tools/python/xen/lowlevel: Fix typo `sucess' Ian Jackson
` (13 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel; +Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson, Wei Liu
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/misc/xenlockprof.c | 2 +-
tools/misc/xenperf.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/misc/xenlockprof.c b/tools/misc/xenlockprof.c
index df23c82912..11f43a35e3 100644
--- a/tools/misc/xenlockprof.c
+++ b/tools/misc/xenlockprof.c
@@ -46,7 +46,7 @@ int main(int argc, char *argv[])
{
if ( xc_lockprof_reset(xc_handle) != 0 )
{
- fprintf(stderr, "Error reseting profile data: %d (%s)\n",
+ fprintf(stderr, "Error resetting profile data: %d (%s)\n",
errno, strerror(errno));
return 1;
}
diff --git a/tools/misc/xenperf.c b/tools/misc/xenperf.c
index 07e584a5eb..a5fbdaa45f 100644
--- a/tools/misc/xenperf.c
+++ b/tools/misc/xenperf.c
@@ -123,7 +123,7 @@ int main(int argc, char *argv[])
{
if ( xc_perfc_reset(xc_handle) != 0 )
{
- fprintf(stderr, "Error reseting performance counters: %d (%s)\n",
+ fprintf(stderr, "Error resetting performance counters: %d (%s)\n",
errno, strerror(errno));
return 1;
}
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 06/18] tools/python/xen/lowlevel: Fix typo `sucess'
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (4 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 05/18] Various: Fix typo `reseting' Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:42 ` Wei Liu
2018-10-05 17:29 ` [PATCH 07/18] Various: Fix typo `infomation' Ian Jackson
` (12 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson,
Marek Marczykowski-Górecki, Wei Liu
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/python/xen/lowlevel/xc/xc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c
index b137d5a839..6f5b8a6fa8 100644
--- a/tools/python/xen/lowlevel/xc/xc.c
+++ b/tools/python/xen/lowlevel/xc/xc.c
@@ -2178,7 +2178,7 @@ static PyMethodDef pyxc_methods[] = {
" xenstore_gmfn [int]: \n"
" console_domid [int]: \n"
" xenstore_domid [int]: \n"
- "Returns: None on sucess. Raises exception on error.\n" },
+ "Returns: None on success. Raises exception on error.\n" },
{ "hvm_get_param",
(PyCFunction)pyxc_hvm_param_get,
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 07/18] Various: Fix typo `infomation'
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (5 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 06/18] tools/python/xen/lowlevel: Fix typo `sucess' Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:08 ` Jan Beulich
2018-10-08 9:31 ` George Dunlap
2018-10-05 17:29 ` [PATCH 08/18] Various: Fix typo `mappping' Ian Jackson
` (11 subsequent siblings)
18 siblings, 2 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson,
Marek Marczykowski-Górecki, Tim Deegan, Hans van Kranenburg,
Julien Grall, Meng Xu, Jan Beulich, Ian Jackson, Dario Faggioli
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/libxl/libxl_internal.h | 2 +-
tools/python/xen/lowlevel/xc/xc.c | 2 +-
tools/xenstat/libxenstat/src/xenstat_qmp.c | 2 +-
xen/common/sched_rt.c | 2 +-
xen/drivers/acpi/apei/erst.c | 2 +-
xen/include/public/domctl.h | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 802382c704..43947b1b07 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -2604,7 +2604,7 @@ struct libxl__multidev {
* Once finished, aodev->callback will be executed.
*/
/*
- * As of Xen 4.5 we maintain various infomation, including hotplug
+ * As of Xen 4.5 we maintain various information, including hotplug
* device information, in JSON files, so that we can use this JSON
* file as a template to reconstruct domain configuration.
*
diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c
index 6f5b8a6fa8..ebef92cd50 100644
--- a/tools/python/xen/lowlevel/xc/xc.c
+++ b/tools/python/xen/lowlevel/xc/xc.c
@@ -2200,7 +2200,7 @@ static PyMethodDef pyxc_methods[] = {
{ "get_device_group",
(PyCFunction)pyxc_get_device_group,
METH_VARARGS, "\n"
- "get sibling devices infomation.\n"
+ "get sibling devices information.\n"
" dom [int]: Domain to assign device to.\n"
" seg [int]: PCI segment.\n"
" bus [int]: PCI bus.\n"
diff --git a/tools/xenstat/libxenstat/src/xenstat_qmp.c b/tools/xenstat/libxenstat/src/xenstat_qmp.c
index 3fda487d49..19b236e7b6 100644
--- a/tools/xenstat/libxenstat/src/xenstat_qmp.c
+++ b/tools/xenstat/libxenstat/src/xenstat_qmp.c
@@ -59,7 +59,7 @@ enum query_block {
/* Given the qmp device name, get the image filename associated with it
- QMP Syntax for querying block infomation:
+ QMP Syntax for querying block information:
In: { "execute": "query-block" }
Out: {"return": [{
"device": 'str, "locked": 'bool', "removable": bool,
diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
index ac79f15dc3..59fbfa625f 100644
--- a/xen/common/sched_rt.c
+++ b/xen/common/sched_rt.c
@@ -203,7 +203,7 @@ struct rt_vcpu {
s_time_t period;
s_time_t budget;
- /* VCPU current infomation in nanosecond */
+ /* VCPU current information in nanosecond */
s_time_t cur_budget; /* current budget */
s_time_t last_start; /* last start time */
s_time_t cur_deadline; /* current deadline for EDF */
diff --git a/xen/drivers/acpi/apei/erst.c b/xen/drivers/acpi/apei/erst.c
index 7fc4de5de9..3a2e403173 100644
--- a/xen/drivers/acpi/apei/erst.c
+++ b/xen/drivers/acpi/apei/erst.c
@@ -2,7 +2,7 @@
* APEI Error Record Serialization Table support
*
* ERST is a way provided by APEI to save and retrieve hardware error
- * infomation to and from a persistent store.
+ * information to and from a persistent store.
*
* For more information about ERST, please refer to ACPI Specification
* version 4.0, section 17.4.
diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h
index 82b696798c..1bbdcd9f8a 100644
--- a/xen/include/public/domctl.h
+++ b/xen/include/public/domctl.h
@@ -508,7 +508,7 @@ struct xen_domctl_assign_device {
} u;
};
-/* Retrieve sibling devices infomation of machine_sbdf */
+/* Retrieve sibling devices information of machine_sbdf */
/* XEN_DOMCTL_get_device_group */
struct xen_domctl_get_device_group {
uint32_t machine_sbdf; /* IN */
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 07/18] Various: Fix typo `infomation'
2018-10-05 17:29 ` [PATCH 07/18] Various: Fix typo `infomation' Ian Jackson
@ 2018-10-08 9:08 ` Jan Beulich
2018-10-08 14:11 ` Ian Jackson
2018-10-08 9:31 ` George Dunlap
1 sibling, 1 reply; 48+ messages in thread
From: Jan Beulich @ 2018-10-08 9:08 UTC (permalink / raw)
To: Ian Jackson
Cc: Tim Deegan, Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Marek Marczykowski,
Dario Faggioli, Hans van Kranenburg, Julien Grall, Meng Xu,
xen-devel
>>> On 05.10.18 at 19:29, <ian.jackson@citrix.com> wrote:
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Funny how often the same spelling mistakes repeat...
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 07/18] Various: Fix typo `infomation'
2018-10-08 9:08 ` Jan Beulich
@ 2018-10-08 14:11 ` Ian Jackson
0 siblings, 0 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-08 14:11 UTC (permalink / raw)
To: Jan Beulich
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Tim Deegan, Marek Marczykowski,
Dario Faggioli, Hans van Kranenburg, Julien Grall, Meng Xu,
xen-devel
Jan Beulich writes ("Re: [PATCH 07/18] Various: Fix typo `infomation'"):
> On 05.10.18 at 19:29, <ian.jackson@citrix.com> wrote:
> > Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
>
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
> Funny how often the same spelling mistakes repeat...
Mmm.
In one of my own projects I had a persistent problem with `pseudo'
(which appeared in some textual protocol elements, so the spelling was
important). I eventually wrote a test case which fails iff the source
code contains `ps[u]edo' (written that way to avoid tripping itself).
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 07/18] Various: Fix typo `infomation'
2018-10-05 17:29 ` [PATCH 07/18] Various: Fix typo `infomation' Ian Jackson
2018-10-08 9:08 ` Jan Beulich
@ 2018-10-08 9:31 ` George Dunlap
1 sibling, 0 replies; 48+ messages in thread
From: George Dunlap @ 2018-10-08 9:31 UTC (permalink / raw)
To: Ian Jackson, xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson,
Marek Marczykowski-Górecki, Tim Deegan, Hans van Kranenburg,
Julien Grall, Meng Xu, Jan Beulich, Dario Faggioli
On 10/05/2018 06:29 PM, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 08/18] Various: Fix typo `mappping'
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (6 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 07/18] Various: Fix typo `infomation' Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:43 ` Wei Liu
2018-10-05 17:29 ` [PATCH 09/18] tools/Rules.mk: Honour PREPEND_LDFLAGS_XEN_TOOLS Ian Jackson
` (10 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Kevin Tian, Wei Liu, Ian Jackson,
Marek Marczykowski-Górecki, Hans van Kranenburg,
Ian Jackson
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/python/xen/lowlevel/xc/xc.c | 2 +-
xen/drivers/passthrough/vtd/iommu.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/python/xen/lowlevel/xc/xc.c b/tools/python/xen/lowlevel/xc/xc.c
index ebef92cd50..484b790c75 100644
--- a/tools/python/xen/lowlevel/xc/xc.c
+++ b/tools/python/xen/lowlevel/xc/xc.c
@@ -2385,7 +2385,7 @@ static PyMethodDef pyxc_methods[] = {
{ "domain_set_memmap_limit",
(PyCFunction)pyxc_domain_set_memmap_limit,
METH_VARARGS, "\n"
- "Set a domain's physical memory mappping limit\n"
+ "Set a domain's physical memory mapping limit\n"
" dom [int]: Identifier of domain.\n"
" map_limitkb [int]: .\n"
"Returns: [int] 0 on success; -1 on error.\n" },
diff --git a/xen/drivers/passthrough/vtd/iommu.h b/xen/drivers/passthrough/vtd/iommu.h
index 47bdfcb5ea..1a992f72d6 100644
--- a/xen/drivers/passthrough/vtd/iommu.h
+++ b/xen/drivers/passthrough/vtd/iommu.h
@@ -513,7 +513,7 @@ struct qi_ctrl {
struct ir_ctrl {
u64 iremap_maddr; /* interrupt remap table machine address */
int iremap_num; /* total num of used interrupt remap entry */
- spinlock_t iremap_lock; /* lock for irq remappping table */
+ spinlock_t iremap_lock; /* lock for irq remapping table */
};
struct iommu_flush {
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 09/18] tools/Rules.mk: Honour PREPEND_LDFLAGS_XEN_TOOLS
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (7 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 08/18] Various: Fix typo `mappping' Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-05 17:29 ` [PATCH 10/18] INSTALL: Mention kconfig Ian Jackson
` (9 subsequent siblings)
18 siblings, 0 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel; +Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson, Wei Liu
This allows the caller to provide some LDFLAGS to the Xen build
system.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/Rules.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 296b722372..68f2ed7ce1 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -9,6 +9,8 @@ include $(XEN_ROOT)/Config.mk
export _INSTALL := $(INSTALL)
INSTALL = $(XEN_ROOT)/tools/cross-install
+LDFLAGS += $(PREPEND_LDFLAGS_XEN_TOOLS)
+
XEN_INCLUDE = $(XEN_ROOT)/tools/include
XEN_LIBXENTOOLCORE = $(XEN_ROOT)/tools/libs/toolcore
XEN_LIBXENTOOLLOG = $(XEN_ROOT)/tools/libs/toollog
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 10/18] INSTALL: Mention kconfig
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (8 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 09/18] tools/Rules.mk: Honour PREPEND_LDFLAGS_XEN_TOOLS Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-07 18:27 ` Doug Goldstein
2018-10-08 9:13 ` Jan Beulich
2018-10-05 17:29 ` [PATCH 11/18] docs/man: Provide properly-formatted NAME sections Ian Jackson
` (8 subsequent siblings)
18 siblings, 2 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Tim Deegan, Ian Jackson, Hans van Kranenburg,
Julien Grall, Jan Beulich, Andrew Cooper, Ian Jackson,
Doug Goldstein
Firstly, add a reference to the documentation for the kconfig system.
Secondly, warn the user about the XEN_CONFIG_EXPERT problem.
CC: Doug Goldstein <cardoe@cardoe.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
INSTALL | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/INSTALL b/INSTALL
index 9aa9ebdddc..62b0162864 100644
--- a/INSTALL
+++ b/INSTALL
@@ -19,6 +19,26 @@ following compile process. Once configure is done, make(1) has to be
called. Also make(1) recognizes certain arguments. The following sections
will give an overview.
+Xen Hypervisor
+==============
+
+Xen itself is configured via a `kconfig' system borrowed from Linux.
+See docs/misc/kconfig.txt.
+
+Note that unlike with Linux, and contrary to that document, you cannot
+look at Kconfig files, or the default or generated config files etc.,
+to find available configuration options. This is because it is only
+supported (and security supported) by the Xen Project, to change a
+small subset of the options. Attempts to change other options will be
+silently overriden. The only way to find which configuration options
+are available is to run `make menuconfig' or the like.
+
+You can counter-override this behaviour by setting XEN_CONFIG_EXPERT=y
+in your environment. However, doing this is not supported and the
+resulting configurations do not receive security support. If you set
+this varible there is nothing stopping you setting dangerously
+experimental combinations of features - not even any warnings.
+
Options recognized by configure
===============================
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 10/18] INSTALL: Mention kconfig
2018-10-05 17:29 ` [PATCH 10/18] INSTALL: Mention kconfig Ian Jackson
@ 2018-10-07 18:27 ` Doug Goldstein
2018-10-08 14:04 ` Ian Jackson
2018-10-08 9:13 ` Jan Beulich
1 sibling, 1 reply; 48+ messages in thread
From: Doug Goldstein @ 2018-10-07 18:27 UTC (permalink / raw)
To: Ian Jackson
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Tim Deegan, Ian Jackson, Hans van Kranenburg,
Julien Grall, Jan Beulich, Andrew Cooper, xen-devel
On Fri, Oct 05, 2018 at 06:29:09PM +0100, Ian Jackson wrote:
> Firstly, add a reference to the documentation for the kconfig system.
>
> Secondly, warn the user about the XEN_CONFIG_EXPERT problem.
>
> CC: Doug Goldstein <cardoe@cardoe.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
> ---
> INSTALL | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/INSTALL b/INSTALL
> index 9aa9ebdddc..62b0162864 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -19,6 +19,26 @@ following compile process. Once configure is done, make(1) has to be
> called. Also make(1) recognizes certain arguments. The following sections
> will give an overview.
>
> +Xen Hypervisor
> +==============
> +
> +Xen itself is configured via a `kconfig' system borrowed from Linux.
> +See docs/misc/kconfig.txt.
> +
> +Note that unlike with Linux, and contrary to that document, you cannot
> +look at Kconfig files, or the default or generated config files etc.,
> +to find available configuration options. This is because it is only
> +supported (and security supported) by the Xen Project, to change a
> +small subset of the options. Attempts to change other options will be
> +silently overriden. The only way to find which configuration options
> +are available is to run `make menuconfig' or the like.
> +
> +You can counter-override this behaviour by setting XEN_CONFIG_EXPERT=y
> +in your environment. However, doing this is not supported and the
> +resulting configurations do not receive security support. If you set
> +this varible there is nothing stopping you setting dangerously
> +experimental combinations of features - not even any warnings.
Not really true because the shim is supported and relies on
XEN_CONFIG_EXPERT but certainly better to make users aware than blindly
hiding everything from them. I'd still argue that eventually we'll get
rid of this because most distros build with XEN_CONFIG_EXPERT on and
most Xen devs I know just have it set in their environment.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/18] INSTALL: Mention kconfig
2018-10-07 18:27 ` Doug Goldstein
@ 2018-10-08 14:04 ` Ian Jackson
0 siblings, 0 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-08 14:04 UTC (permalink / raw)
To: Doug Goldstein
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Tim Deegan, Hans van Kranenburg,
Julien Grall, Jan Beulich, xen-devel
Doug Goldstein writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
> On Fri, Oct 05, 2018 at 06:29:09PM +0100, Ian Jackson wrote:
> > Firstly, add a reference to the documentation for the kconfig system.
> >
> > Secondly, warn the user about the XEN_CONFIG_EXPERT problem.
>
> Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Thanks.
> > +Xen Hypervisor
> > +==============
> > +
> > +Xen itself is configured via a `kconfig' system borrowed from Linux.
> > +See docs/misc/kconfig.txt.
> > +
> > +Note that unlike with Linux, and contrary to that document, you cannot
> > +look at Kconfig files, or the default or generated config files etc.,
> > +to find available configuration options. This is because it is only
> > +supported (and security supported) by the Xen Project, to change a
> > +small subset of the options. Attempts to change other options will be
> > +silently overriden. The only way to find which configuration options
> > +are available is to run `make menuconfig' or the like.
> > +
> > +You can counter-override this behaviour by setting XEN_CONFIG_EXPERT=y
> > +in your environment. However, doing this is not supported and the
> > +resulting configurations do not receive security support. If you set
> > +this varible there is nothing stopping you setting dangerously
> > +experimental combinations of features - not even any warnings.
>
> Not really true because the shim is supported and relies on
> XEN_CONFIG_EXPERT
It sounds like you are saying that what I write above is not accurate.
I didn't intend it to cover any setting of XEN_CONFIG_EXPERT by the
Xen build system itself.
I'm not sure how that interacts wit your R-B either. Normally a R-B
would imply approval of the contents.
> but certainly better to make users aware than blindly
> hiding everything from them. I'd still argue that eventually we'll get
> rid of this because most distros build with XEN_CONFIG_EXPERT on and
> most Xen devs I know just have it set in their environment.
Well, yes. I decided that documenting the situation was the best way
to throw light on it and possibly even get it changed.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/18] INSTALL: Mention kconfig
2018-10-05 17:29 ` [PATCH 10/18] INSTALL: Mention kconfig Ian Jackson
2018-10-07 18:27 ` Doug Goldstein
@ 2018-10-08 9:13 ` Jan Beulich
2018-10-08 14:08 ` Ian Jackson
1 sibling, 1 reply; 48+ messages in thread
From: Jan Beulich @ 2018-10-08 9:13 UTC (permalink / raw)
To: Ian Jackson
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Hans van Kranenburg, Julien Grall, xen-devel, Doug Goldstein
>>> On 05.10.18 at 19:29, <ian.jackson@citrix.com> wrote:
> +Xen Hypervisor
> +==============
> +
> +Xen itself is configured via a `kconfig' system borrowed from Linux.
> +See docs/misc/kconfig.txt.
> +
> +Note that unlike with Linux, and contrary to that document, you cannot
> +look at Kconfig files, or the default or generated config files etc.,
> +to find available configuration options. This is because it is only
> +supported (and security supported) by the Xen Project, to change a
> +small subset of the options. Attempts to change other options will be
> +silently overriden. The only way to find which configuration options
Isn't it "overridden", or are both spellings okay?
> +are available is to run `make menuconfig' or the like.
> +
> +You can counter-override this behaviour by setting XEN_CONFIG_EXPERT=y
> +in your environment. However, doing this is not supported and the
> +resulting configurations do not receive security support. If you set
> +this varible there is nothing stopping you setting dangerously
variable
Beyond these nits I'm okay with the text now, accepting the anomaly
pointed out by Doug.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 10/18] INSTALL: Mention kconfig
2018-10-08 9:13 ` Jan Beulich
@ 2018-10-08 14:08 ` Ian Jackson
2018-10-08 14:22 ` Jan Beulich
0 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-08 14:08 UTC (permalink / raw)
To: Jan Beulich
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Doug Goldstein, Tim Deegan,
Hans van Kranenburg, Julien Grall, xen-devel, Ian Jackson,
Ian Jackson
Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
> On 05.10.18 at 19:29, <ian.jackson@citrix.com> wrote:
> > +silently overriden. The only way to find which configuration options
>
> Isn't it "overridden", or are both spellings okay?
It is; I was wrong.
> > +this varible there is nothing stopping you setting dangerously
>
> variable
Fixed.
> Beyond these nits I'm okay with the text now, accepting the anomaly
> pointed out by Doug.
Thanks, I'll take that as an ack. (Assuming you did indeed mean
`accepting' rather than `excepting'.)
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 10/18] INSTALL: Mention kconfig
2018-10-08 14:08 ` Ian Jackson
@ 2018-10-08 14:22 ` Jan Beulich
2018-10-08 14:24 ` Ian Jackson
0 siblings, 1 reply; 48+ messages in thread
From: Jan Beulich @ 2018-10-08 14:22 UTC (permalink / raw)
To: Ian Jackson
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Hans van Kranenburg, Julien Grall, xen-devel, Doug Goldstein
>>> On 08.10.18 at 16:08, <ian.jackson@citrix.com> wrote:
> Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
>> On 05.10.18 at 19:29, <ian.jackson@citrix.com> wrote:
>> > +silently overriden. The only way to find which configuration options
>>
>> Isn't it "overridden", or are both spellings okay?
>
> It is; I was wrong.
>
>> > +this varible there is nothing stopping you setting dangerously
>>
>> variable
>
> Fixed.
>
>> Beyond these nits I'm okay with the text now, accepting the anomaly
>> pointed out by Doug.
>
> Thanks, I'll take that as an ack. (Assuming you did indeed mean
> `accepting' rather than `excepting'.)
Well, no, it was not meant as an ack, merely as the absence of further
objections. (And yes, I did mean "accepting".)
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 10/18] INSTALL: Mention kconfig
2018-10-08 14:22 ` Jan Beulich
@ 2018-10-08 14:24 ` Ian Jackson
2018-10-09 3:52 ` Doug Goldstein
0 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-08 14:24 UTC (permalink / raw)
To: Jan Beulich
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Hans van Kranenburg, Julien Grall, xen-devel, Doug Goldstein
Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
> On 08.10.18 at 16:08, <ian.jackson@citrix.com> wrote:
> > Thanks, I'll take that as an ack. (Assuming you did indeed mean
> > `accepting' rather than `excepting'.)
>
> Well, no, it was not meant as an ack, merely as the absence of further
> objections. (And yes, I did mean "accepting".)
Err, OK.
Doug, do you want me to propose a different or expanded wording ?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 10/18] INSTALL: Mention kconfig
2018-10-08 14:24 ` Ian Jackson
@ 2018-10-09 3:52 ` Doug Goldstein
0 siblings, 0 replies; 48+ messages in thread
From: Doug Goldstein @ 2018-10-09 3:52 UTC (permalink / raw)
To: Ian Jackson
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
George Dunlap, Andrew Cooper, Ian Jackson, Tim Deegan,
Hans van Kranenburg, Julien Grall, Jan Beulich, xen-devel
On Mon, Oct 08, 2018 at 03:24:41PM +0100, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH 10/18] INSTALL: Mention kconfig"):
> > On 08.10.18 at 16:08, <ian.jackson@citrix.com> wrote:
> > > Thanks, I'll take that as an ack. (Assuming you did indeed mean
> > > `accepting' rather than `excepting'.)
> >
> > Well, no, it was not meant as an ack, merely as the absence of further
> > objections. (And yes, I did mean "accepting".)
>
> Err, OK.
>
> Doug, do you want me to propose a different or expanded wording ?
>
> Ian.
No. I think this good. It sheds light on something that was black magic
and that's good. I think you've started the conversation on how we see
XEN_CONFIG_EXPERT evolving (due to the shim config) and that's great
too. +1 from me.
--
Doug
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 11/18] docs/man: Provide properly-formatted NAME sections
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (9 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 10/18] INSTALL: Mention kconfig Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:44 ` Wei Liu
2018-10-05 17:29 ` [PATCH 12/18] docs/man/xen-pv-channel.pod.7: Remove a spurious blank line Ian Jackson
` (7 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel; +Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson, Wei Liu
A manpage `foo.7.pod' must start with
=head NAME
foo - some summary of what foo is or what this manpage is
because otherwise manpage catalogue systems cannot generate a proper
`whatis' entry.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
docs/man/xen-pci-device-reservations.pod.7 | 4 ++++
docs/man/xen-pv-channel.pod.7 | 2 +-
docs/man/xen-tscmode.pod.7 | 4 ++++
docs/man/xen-vtpm.pod.7 | 6 ++++++
docs/man/xen-vtpmmgr.pod.7 | 4 ++++
docs/man/xl-numa-placement.pod.7 | 2 +-
6 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/docs/man/xen-pci-device-reservations.pod.7 b/docs/man/xen-pci-device-reservations.pod.7
index dac92764fc..049e47410f 100644
--- a/docs/man/xen-pci-device-reservations.pod.7
+++ b/docs/man/xen-pci-device-reservations.pod.7
@@ -1,3 +1,7 @@
+=head1 NAME
+
+xen-pci-device-reservations - Xen PCI device ID registry
+
=head1 Description
PCI vendor ID 0x5853 has been reserved for use by Xen systems in order to
diff --git a/docs/man/xen-pv-channel.pod.7 b/docs/man/xen-pv-channel.pod.7
index 7229b26d06..f9f0108488 100644
--- a/docs/man/xen-pv-channel.pod.7
+++ b/docs/man/xen-pv-channel.pod.7
@@ -3,7 +3,7 @@
=head1 NAME
-Xen PV Channels
+xen-pv-channel - Xen PV Channels
=head1 DESCRIPTION
diff --git a/docs/man/xen-tscmode.pod.7 b/docs/man/xen-tscmode.pod.7
index 3bbc96f201..819c61dd05 100644
--- a/docs/man/xen-tscmode.pod.7
+++ b/docs/man/xen-tscmode.pod.7
@@ -1,3 +1,7 @@
+=head1 NAME
+
+xen-tscmode - Xen TSC (time stamp counter) and timekeeping discussion
+
=head1 OVERVIEW
As of Xen 4.0, a new config option called tsc_mode may be specified
diff --git a/docs/man/xen-vtpm.pod.7 b/docs/man/xen-vtpm.pod.7
index 8de67f4d94..1d8185616a 100644
--- a/docs/man/xen-vtpm.pod.7
+++ b/docs/man/xen-vtpm.pod.7
@@ -1,3 +1,9 @@
+=head1 NAME
+
+xen-vtpm - Xen virtual Trusted Platform Module (vTPM) subsystem
+
+=head1 RUBRIC
+
Copyright (c) 2010-2012 United States Government, as represented by
the Secretary of Defense. All rights reserved.
November 12 2012
diff --git a/docs/man/xen-vtpmmgr.pod.7 b/docs/man/xen-vtpmmgr.pod.7
index 2c3a2de8aa..af825a7ffe 100644
--- a/docs/man/xen-vtpmmgr.pod.7
+++ b/docs/man/xen-vtpmmgr.pod.7
@@ -1,3 +1,7 @@
+=head1 NAME
+
+xen-vtpmgr - Xen virtual TPM stubdomain
+
=head1 Authors
=over 4
diff --git a/docs/man/xl-numa-placement.pod.7 b/docs/man/xl-numa-placement.pod.7
index 54a444172e..ae8330207e 100644
--- a/docs/man/xl-numa-placement.pod.7
+++ b/docs/man/xl-numa-placement.pod.7
@@ -2,7 +2,7 @@
=head1 NAME
-Guest Automatic NUMA Placement in libxl and xl
+xl-numa-placement - Guest Automatic NUMA Placement in libxl and xl
=head1 DESCRIPTION
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 12/18] docs/man/xen-pv-channel.pod.7: Remove a spurious blank line
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (10 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 11/18] docs/man: Provide properly-formatted NAME sections Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:44 ` Wei Liu
2018-10-05 17:29 ` [PATCH 13/18] tools/xenstat: Fix shared library version Ian Jackson
` (6 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel; +Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson, Wei Liu
No functional change.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
docs/man/xen-pv-channel.pod.7 | 1 -
1 file changed, 1 deletion(-)
diff --git a/docs/man/xen-pv-channel.pod.7 b/docs/man/xen-pv-channel.pod.7
index f9f0108488..07898f6dde 100644
--- a/docs/man/xen-pv-channel.pod.7
+++ b/docs/man/xen-pv-channel.pod.7
@@ -1,6 +1,5 @@
=encoding utf8
-
=head1 NAME
xen-pv-channel - Xen PV Channels
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 13/18] tools/xenstat: Fix shared library version
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (11 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 12/18] docs/man/xen-pv-channel.pod.7: Remove a spurious blank line Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:44 ` Wei Liu
2018-10-09 13:59 ` Andrew Cooper
2018-10-05 17:29 ` [PATCH 14/18] gdbsx: Honour LDFLAGS when linking Ian Jackson
` (5 subsequent siblings)
18 siblings, 2 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Bastian Blank, Wei Liu, Hans van Kranenburg, Ian Jackson, Ian Jackson
From: Bastian Blank <waldi@debian.org>
libxenstat does not have a stable ABI. Set its version to the current
Xen release version.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/xenstat/libxenstat/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xenstat/libxenstat/Makefile b/tools/xenstat/libxenstat/Makefile
index 8979fa1583..8c6ddf86e8 100644
--- a/tools/xenstat/libxenstat/Makefile
+++ b/tools/xenstat/libxenstat/Makefile
@@ -18,7 +18,7 @@ include $(XEN_ROOT)/tools/Rules.mk
LDCONFIG=ldconfig
MAKE_LINK=ln -sf
-MAJOR=0
+MAJOR=4.11
MINOR=0
LIB=src/libxenstat.a
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 13/18] tools/xenstat: Fix shared library version
2018-10-05 17:29 ` [PATCH 13/18] tools/xenstat: Fix shared library version Ian Jackson
@ 2018-10-08 9:44 ` Wei Liu
2018-10-09 13:59 ` Andrew Cooper
1 sibling, 0 replies; 48+ messages in thread
From: Wei Liu @ 2018-10-08 9:44 UTC (permalink / raw)
To: Ian Jackson
Cc: Bastian Blank, xen-devel, Hans van Kranenburg, Ian Jackson, Wei Liu
On Fri, Oct 05, 2018 at 06:29:12PM +0100, Ian Jackson wrote:
> From: Bastian Blank <waldi@debian.org>
>
> libxenstat does not have a stable ABI. Set its version to the current
> Xen release version.
>
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 13/18] tools/xenstat: Fix shared library version
2018-10-05 17:29 ` [PATCH 13/18] tools/xenstat: Fix shared library version Ian Jackson
2018-10-08 9:44 ` Wei Liu
@ 2018-10-09 13:59 ` Andrew Cooper
1 sibling, 0 replies; 48+ messages in thread
From: Andrew Cooper @ 2018-10-09 13:59 UTC (permalink / raw)
To: Ian Jackson, xen-devel
Cc: Bastian Blank, Hans van Kranenburg, Wei Liu, Ian Jackson
On 05/10/18 18:29, Ian Jackson wrote:
> From: Bastian Blank <waldi@debian.org>
>
> libxenstat does not have a stable ABI. Set its version to the current
> Xen release version.
>
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
> ---
> tools/xenstat/libxenstat/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xenstat/libxenstat/Makefile b/tools/xenstat/libxenstat/Makefile
> index 8979fa1583..8c6ddf86e8 100644
> --- a/tools/xenstat/libxenstat/Makefile
> +++ b/tools/xenstat/libxenstat/Makefile
> @@ -18,7 +18,7 @@ include $(XEN_ROOT)/tools/Rules.mk
> LDCONFIG=ldconfig
> MAKE_LINK=ln -sf
>
> -MAJOR=0
> +MAJOR=4.11
I see you've already committed this patch, but you don't mean 4.11 here.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* [PATCH 14/18] gdbsx: Honour LDFLAGS when linking
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (12 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 13/18] tools/xenstat: Fix shared library version Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-05 17:29 ` [PATCH 15/18] libfsimage: Honour general LDFLAGS Ian Jackson
` (4 subsequent siblings)
18 siblings, 0 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Elena Ufimtseva, Ian Jackson, Hans van Kranenburg, Ian Jackson, Wei Liu
This command does the link, so it needs LDFLAGS.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/debugger/gdbsx/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/debugger/gdbsx/Makefile b/tools/debugger/gdbsx/Makefile
index 723a2743cc..8d7cd94a31 100644
--- a/tools/debugger/gdbsx/Makefile
+++ b/tools/debugger/gdbsx/Makefile
@@ -26,7 +26,7 @@ uninstall:
rm -f $(DESTDIR)$(sbindir)/gdbsx
gdbsx: gx/gx_all.a xg/xg_all.a
- $(CC) -o $@ $^
+ $(CC) $(LDFLAGS) -o $@ $^
xg/xg_all.a:
$(MAKE) -C xg
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 15/18] libfsimage: Honour general LDFLAGS
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (13 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 14/18] gdbsx: Honour LDFLAGS when linking Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:45 ` Wei Liu
2018-10-05 17:29 ` [PATCH 16/18] pygrub fsimage.so: Honour LDFLAGS when building Ian Jackson
` (3 subsequent siblings)
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel; +Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson, Wei Liu
Do not reset LDFLAGS to empty. Instead, append the fsimage-special
LDFLAGS.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/libfsimage/common/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/libfsimage/common/Makefile b/tools/libfsimage/common/Makefile
index 0791fc9923..a4655c421c 100644
--- a/tools/libfsimage/common/Makefile
+++ b/tools/libfsimage/common/Makefile
@@ -6,7 +6,7 @@ MINOR = 0
LDFLAGS-$(CONFIG_SunOS) = -Wl,-M -Wl,mapfile-SunOS
LDFLAGS-$(CONFIG_Linux) = -Wl,mapfile-GNU
-LDFLAGS = $(LDFLAGS-y)
+LDFLAGS += $(LDFLAGS-y)
CFLAGS += $(PTHREAD_CFLAGS)
LDFLAGS += $(PTHREAD_LDFLAGS)
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 16/18] pygrub fsimage.so: Honour LDFLAGS when building
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (14 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 15/18] libfsimage: Honour general LDFLAGS Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-05 17:29 ` [PATCH 17/18] xenmon: Install as xenmon, not xenmon.py Ian Jackson
` (2 subsequent siblings)
18 siblings, 0 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel; +Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson, Wei Liu
This seems to have been simply omitted. Obviously this is needed when
building and not just when installing. Passing only when installing
is ineffective.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/pygrub/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
index 536af07932..3063c4998f 100644
--- a/tools/pygrub/Makefile
+++ b/tools/pygrub/Makefile
@@ -10,7 +10,7 @@ INSTALL_LOG = build/installed_files.txt
all: build
.PHONY: build
build:
- CC="$(CC)" CFLAGS="$(PY_CFLAGS)" $(PYTHON) setup.py build
+ CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py build
.PHONY: install
install: all
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 17/18] xenmon: Install as xenmon, not xenmon.py
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (15 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 16/18] pygrub fsimage.so: Honour LDFLAGS when building Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-08 9:51 ` Wei Liu
2018-10-05 17:29 ` [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd' Ian Jackson
2018-10-08 14:28 ` [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel; +Cc: Hans van Kranenburg, Ian Jackson, Ian Jackson, Wei Liu
Adding the implementation language as a suffix to a program name is
poor practice.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/xenmon/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/xenmon/Makefile b/tools/xenmon/Makefile
index e45c5b8c14..e1712304d0 100644
--- a/tools/xenmon/Makefile
+++ b/tools/xenmon/Makefile
@@ -32,13 +32,13 @@ install: build
$(INSTALL_DIR) $(DESTDIR)$(sbindir)
$(INSTALL_PROG) xenbaked $(DESTDIR)$(sbindir)/xenbaked
$(INSTALL_PROG) xentrace_setmask $(DESTDIR)$(sbindir)/xentrace_setmask
- $(INSTALL_PROG) xenmon.py $(DESTDIR)$(sbindir)/xenmon.py
+ $(INSTALL_PROG) xenmon.py $(DESTDIR)$(sbindir)/xenmon
.PHONY: uninstall
uninstall:
rm -f $(DESTDIR)$(sbindir)/xenbaked
rm -f $(DESTDIR)$(sbindir)/xentrace_setmask
- rm -f $(DESTDIR)$(sbindir)/xenmon.py
+ rm -f $(DESTDIR)$(sbindir)/xenmon
.PHONY: clean
clean:
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (16 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 17/18] xenmon: Install as xenmon, not xenmon.py Ian Jackson
@ 2018-10-05 17:29 ` Ian Jackson
2018-10-07 16:37 ` Tim Deegan
2018-10-08 14:28 ` [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
18 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-05 17:29 UTC (permalink / raw)
To: xen-devel
Cc: Hans van Kranenburg, Ian Jackson, Tim Deegan, Ian Jackson, Wei Liu
`kdd' is an unfortunate namespace landgrab.
Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
---
tools/debugger/kdd/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/debugger/kdd/Makefile b/tools/debugger/kdd/Makefile
index 5509eee68c..26116949d4 100644
--- a/tools/debugger/kdd/Makefile
+++ b/tools/debugger/kdd/Makefile
@@ -24,8 +24,8 @@ distclean: clean
.PHONY: install
install: all
[ -d $(DESTDIR)$(sbindir) ] || $(INSTALL_DIR) $(DESTDIR)$(sbindir)
- $(INSTALL_PROG) kdd $(DESTDIR)$(sbindir)/kdd
+ $(INSTALL_PROG) kdd $(DESTDIR)$(sbindir)/xen-kdd
.PHONY: uninstall
uninstall:
- rm -f $(DESTDIR)$(sbindir)/kdd
+ rm -f $(DESTDIR)$(sbindir)/xen-kdd
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 48+ messages in thread* Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
2018-10-05 17:29 ` [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd' Ian Jackson
@ 2018-10-07 16:37 ` Tim Deegan
2018-10-08 14:01 ` Ian Jackson
0 siblings, 1 reply; 48+ messages in thread
From: Tim Deegan @ 2018-10-07 16:37 UTC (permalink / raw)
To: Ian Jackson; +Cc: Hans van Kranenburg, xen-devel, Ian Jackson, Wei Liu
At 18:29 +0100 on 05 Oct (1538764157), Ian Jackson wrote:
> `kdd' is an unfortunate namespace landgrab.
Bah, humbug, etc. :) Can we have a note in the changelog for the next
release to warn the few kdd users that we've done this?
> Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
Cheers,
Tim.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
2018-10-07 16:37 ` Tim Deegan
@ 2018-10-08 14:01 ` Ian Jackson
2018-10-08 14:29 ` Juergen Gross
0 siblings, 1 reply; 48+ messages in thread
From: Ian Jackson @ 2018-10-08 14:01 UTC (permalink / raw)
To: Tim Deegan, Jurgen Gross; +Cc: Hans van Kranenburg, xen-devel, Wei Liu
Tim Deegan writes ("Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'"):
> At 18:29 +0100 on 05 Oct (1538764157), Ian Jackson wrote:
> > `kdd' is an unfortunate namespace landgrab.
>
> Bah, humbug, etc. :) Can we have a note in the changelog for the next
> release to warn the few kdd users that we've done this?
Mmm, sorry. Err, where are such release notes collected ?
CC'ing Juergen as RM.
> > Signed-off-by: Ian Jackson <ian.jackson@citrix.com>
>
> Acked-by: Tim Deegan <tim@xen.org>
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
2018-10-08 14:01 ` Ian Jackson
@ 2018-10-08 14:29 ` Juergen Gross
2018-10-12 15:00 ` Ian Jackson
0 siblings, 1 reply; 48+ messages in thread
From: Juergen Gross @ 2018-10-08 14:29 UTC (permalink / raw)
To: Ian Jackson, Tim Deegan; +Cc: Hans van Kranenburg, xen-devel, Wei Liu
On 08/10/2018 16:01, Ian Jackson wrote:
> Tim Deegan writes ("Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'"):
>> At 18:29 +0100 on 05 Oct (1538764157), Ian Jackson wrote:
>>> `kdd' is an unfortunate namespace landgrab.
>>
>> Bah, humbug, etc. :) Can we have a note in the changelog for the next
>> release to warn the few kdd users that we've done this?
>
> Mmm, sorry. Err, where are such release notes collected ?
I believe this is a manual process triggered by the Community Manager.
I'm fine with collecting RN snipplets for the upcoming release, of
course.
Ian, another question: could we add a link to the release note of the
related version on:
https://xenbits.xen.org/docs/unstable/support-matrix.html
like it was done on:
https://wiki.xenproject.org/wiki/Xen_Project_Release_Features
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread* Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'
2018-10-08 14:29 ` Juergen Gross
@ 2018-10-12 15:00 ` Ian Jackson
0 siblings, 0 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-12 15:00 UTC (permalink / raw)
To: Juergen Gross; +Cc: Hans van Kranenburg, xen-devel, Tim Deegan, Wei Liu
Juergen Gross writes ("Re: [Xen-devel] [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'"):
> On 08/10/2018 16:01, Ian Jackson wrote:
> > Tim Deegan writes ("Re: [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd'"):
> >> At 18:29 +0100 on 05 Oct (1538764157), Ian Jackson wrote:
> >>> `kdd' is an unfortunate namespace landgrab.
> >>
> >> Bah, humbug, etc. :) Can we have a note in the changelog for the next
> >> release to warn the few kdd users that we've done this?
> >
> > Mmm, sorry. Err, where are such release notes collected ?
>
> I believe this is a manual process triggered by the Community Manager.
>
> I'm fine with collecting RN snipplets for the upcoming release, of
> course.
Thanks. Can you add kdd -> xen-kdd to that list then please ?
> Ian, another question: could we add a link to the release note of the
> related version on:
>
> https://xenbits.xen.org/docs/unstable/support-matrix.html
Yes, I think so. That page is generated by
docs/support-matrix-generate
docs/parse-support-md
which consumes
SUPPORT.md
from each tree.
I think if we change SUPPORT.md to have a proper hyperlink to the
release notes, in each tree, in the Release Support indented stanza,
it will appear on the support matrix page.
That is better than having the url be magically inserted by the matrix
generation machinery because it will appear in places like this too
https://xenbits.xen.org/docs/4.11-testing/SUPPORT.html
Would you prepare a patch for 4.11 to add the RN URL ? You can
perhaps test the support matrix output by running a variant of the
rune at the top of
docs/support-matrix-generate
and I will fix the matrix code it if it doesn't seem to work :-).
Regards,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread
* Re: [PATCH 00/18] Miscellaneous build and docs, fixes from Debian
2018-10-05 17:28 [PATCH 00/18] Miscellaneous build and docs, fixes from Debian Ian Jackson
` (17 preceding siblings ...)
2018-10-05 17:29 ` [PATCH 18/18] tools/debugger/kdd: Install as `xen-kdd', not just `kdd' Ian Jackson
@ 2018-10-08 14:28 ` Ian Jackson
18 siblings, 0 replies; 48+ messages in thread
From: Ian Jackson @ 2018-10-08 14:28 UTC (permalink / raw)
To: xen-devel, Wei Liu, George Dunlap, Shriram Rajagopalan,
Yang Hongyang, Stefano Stabellini, Julien Grall, Andrew Cooper,
Jan Beulich, Konrad Rzeszutek Wilk, Tim Deegan, Boris Ostrovsky,
Suravee Suthikulpanit, Brian Woods,
Marek Marczykowski-Górecki, Dario Faggioli, Meng Xu,
Kevin Tian, Doug Goldstein, Elena Ufimtseva, Hans van Kranenburg
Ian Jackson writes ("[PATCH 00/18] Miscellaneous build and docs, fixes from Debian"):
> Bastian Blank (1):
> Ian Jackson (17):
Thanks to the reviewers. I have pushed to staging these patches,
which were acked/reviewed and seemed to me to be uncontroversial:
> docs/man: Fix two typos detected by the Debian lintian tool
> tools/xentrace/xenalyze: Fix typos detected by lintian
> Various: Fix typos `unkown', `retreive' (detected by lintian)
> Various: Fix typo `occured'
> Various: Fix typo `reseting'
> tools/python/xen/lowlevel: Fix typo `sucess'
> Various: Fix typo `infomation'
> Various: Fix typo `mappping'
> docs/man: Provide properly-formatted NAME sections
> docs/man/xen-pv-channel.pod.7: Remove a spurious blank line
> tools/xenstat: Fix shared library version
> libfsimage: Honour general LDFLAGS
Subject to further comments, I will repost the remainder as a v2 of
the series.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 48+ messages in thread