All of lore.kernel.org
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Bart Van Assche <bvanassche@acm.org>,
	linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Ming Lei <ming.lei@redhat.com>, Hannes Reinecke <hare@suse.com>,
	Johannes Thumshirn <jthumshirn@suse.de>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] blk-mq-debugfs: Also show requests that have not yet been started
Date: Fri, 5 Oct 2018 15:37:18 -0700	[thread overview]
Message-ID: <20181005223718.GL25437@vader> (raw)
In-Reply-To: <a3f6a55e-eaa5-6a65-8360-9d85c7566961@kernel.dk>

On Fri, Oct 05, 2018 at 08:18:00AM -0600, Jens Axboe wrote:
> On 10/4/18 11:35 AM, Bart Van Assche wrote:
> > When debugging e.g. the SCSI timeout handler it is important that
> > requests that have not yet been started or that already have
> > completed are also reported through debugfs.
> 
> Thanks, I like this better - applied. BTW, what's up with the
> reverse ordering on this:
> 
> > Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Ming Lei <ming.lei@redhat.com>
> > Cc: Hannes Reinecke <hare@suse.com>
> > Cc: Johannes Thumshirn <jthumshirn@suse.de>
> > Cc: Martin K. Petersen <martin.petersen@oracle.com>
> 
> For some reason that really annoys me, and I see it in various
> patches these days. IMHO the SOB should be last, with whatever
> acks, reviews, CC, before that.

I could've sworn that this guideline was even documented somewhere, but
I can't find it now ¯\_(ツ)_/¯

  reply	other threads:[~2018-10-05 22:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 17:35 [PATCH] blk-mq-debugfs: Also show requests that have not yet been started Bart Van Assche
2018-10-05  5:48 ` Hannes Reinecke
2018-10-05  7:06 ` Johannes Thumshirn
2018-10-05 14:18 ` Jens Axboe
2018-10-05 22:37   ` Omar Sandoval [this message]
2018-10-06  1:13     ` Jens Axboe
2018-10-08  9:15       ` Johannes Thumshirn
  -- strict thread matches above, loose matches on Subject: below --
2018-02-12 17:02 Bart Van Assche
2018-01-12 21:52 Bart Van Assche
2018-01-12 21:55 ` Jens Axboe
2018-01-12 22:00   ` Bart Van Assche
2018-01-12 22:05     ` Jens Axboe
2018-01-12 22:11       ` Bart Van Assche
2018-10-03 21:42         ` Bart Van Assche
2018-10-03 22:12           ` Jens Axboe
2018-10-03 22:51             ` Bart Van Assche
2018-10-03 23:52               ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181005223718.GL25437@vader \
    --to=osandov@osandov.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=jthumshirn@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.