All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quentin Schulz <quentin.schulz@bootlin.com>
To: Oskari Lemmela <oskari@lemmela.net>
Cc: Sebastian Reichel <sre@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Lee Jones <lee.jones@linaro.org>,
	Quentin Schulz <quentin.schulz@free-electrons.com>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/6] ARM: dts: axp81x: add AC power supply subnode
Date: Mon, 8 Oct 2018 09:27:43 +0200	[thread overview]
Message-ID: <20181008072743.ecjb75nixm6wbp6b@qschulz> (raw)
In-Reply-To: <20181006211836.28253-3-oskari@lemmela.net>

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Hi Oskari,

On Sun, Oct 07, 2018 at 12:18:32AM +0300, Oskari Lemmela wrote:
> Add AC power supply subnode for AXP81X PMIC.
> 
> Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
> ---
>  arch/arm/boot/dts/axp81x.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> index 043c717dcef1..67c17151b584 100644
> --- a/arch/arm/boot/dts/axp81x.dtsi
> +++ b/arch/arm/boot/dts/axp81x.dtsi
> @@ -69,6 +69,11 @@
>  		};
>  	};
>  
> +	ac_power_supply: ac-power-supply {
> +		compatible = "x-powers,axp813-ac-power-supply";
> +		status = "disabled";
> +	};
> +

IIRC, when it's a DT node of something that has no address (register or
bus address), we order alphabetically the DT nodes within the same
parent node. So here, we would put it before axp_adc.

Thanks,
Quentin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: quentin.schulz@bootlin.com (Quentin Schulz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] ARM: dts: axp81x: add AC power supply subnode
Date: Mon, 8 Oct 2018 09:27:43 +0200	[thread overview]
Message-ID: <20181008072743.ecjb75nixm6wbp6b@qschulz> (raw)
In-Reply-To: <20181006211836.28253-3-oskari@lemmela.net>

Hi Oskari,

On Sun, Oct 07, 2018 at 12:18:32AM +0300, Oskari Lemmela wrote:
> Add AC power supply subnode for AXP81X PMIC.
> 
> Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
> ---
>  arch/arm/boot/dts/axp81x.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> index 043c717dcef1..67c17151b584 100644
> --- a/arch/arm/boot/dts/axp81x.dtsi
> +++ b/arch/arm/boot/dts/axp81x.dtsi
> @@ -69,6 +69,11 @@
>  		};
>  	};
>  
> +	ac_power_supply: ac-power-supply {
> +		compatible = "x-powers,axp813-ac-power-supply";
> +		status = "disabled";
> +	};
> +

IIRC, when it's a DT node of something that has no address (register or
bus address), we order alphabetically the DT nodes within the same
parent node. So here, we would put it before axp_adc.

Thanks,
Quentin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181008/dd269fd7/attachment-0001.sig>

  reply	other threads:[~2018-10-08  7:27 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 19:34 [PATCH 0/4] AXP8x3 AC and battery power supply support Oskari Lemmela
2018-10-04 19:34 ` Oskari Lemmela
2018-10-04 19:34 ` Oskari Lemmela
2018-10-04 19:34 ` [PATCH 1/4] dt-bindings: add compatibles for AXP803 AC and battery power supplies Oskari Lemmela
2018-10-04 19:34   ` Oskari Lemmela
2018-10-04 19:34   ` Oskari Lemmela
2018-10-08 20:19   ` Jonathan Cameron
2018-10-08 20:19     ` Jonathan Cameron
2018-10-04 19:34 ` [PATCH 2/4] ARM: dtsi: axp81x: add AC power supply subnode Oskari Lemmela
2018-10-04 19:34   ` Oskari Lemmela
2018-10-04 19:34   ` Oskari Lemmela
2018-10-04 19:34 ` [PATCH 3/4] arm64: allwinner: a64: add battery and AC power supply support Oskari Lemmela
2018-10-04 19:34   ` Oskari Lemmela
2018-10-04 19:34   ` Oskari Lemmela
2018-10-04 19:34 ` [PATCH 4/4] power: supply: add AXP803/AXP813 AC and battery " Oskari Lemmela
2018-10-04 19:34   ` Oskari Lemmela
2018-10-04 19:34   ` Oskari Lemmela
2018-10-05  8:29   ` Quentin Schulz
2018-10-05  8:29     ` Quentin Schulz
2018-10-05 18:28     ` Oskari Lemmelä
2018-10-05 18:28       ` Oskari Lemmelä
2018-10-05  3:37 ` [PATCH 0/4] AXP8x3 " Chen-Yu Tsai
2018-10-05  3:37   ` Chen-Yu Tsai
2018-10-05  3:37   ` Chen-Yu Tsai
2018-10-06 21:18 ` [PATCH v2 0/6] " Oskari Lemmela
2018-10-06 21:18   ` Oskari Lemmela
2018-10-06 21:18   ` [PATCH v2 1/6] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding Oskari Lemmela
2018-10-06 21:18     ` Oskari Lemmela
2018-10-06 21:18   ` [PATCH v2 2/6] ARM: dts: axp81x: add AC power supply subnode Oskari Lemmela
2018-10-06 21:18     ` Oskari Lemmela
2018-10-08  7:27     ` Quentin Schulz [this message]
2018-10-08  7:27       ` Quentin Schulz
2018-10-06 21:18   ` [PATCH v2 3/6] arm64: dts: allwinner: axp803: add AC and battery power supplies Oskari Lemmela
2018-10-06 21:18     ` Oskari Lemmela
2018-10-08  7:28     ` Quentin Schulz
2018-10-08  7:28       ` Quentin Schulz
2018-10-06 21:18   ` [PATCH v2 4/6] arm64: dts: allwinner: a64: sopine: enable " Oskari Lemmela
2018-10-06 21:18     ` Oskari Lemmela
2018-10-06 21:18   ` [PATCH v2 5/6] mfd: axp20x: add support AXP803 AC and battery " Oskari Lemmela
2018-10-06 21:18     ` Oskari Lemmela
2018-10-08  7:33     ` Quentin Schulz
2018-10-08  7:33       ` Quentin Schulz
2018-10-06 21:18   ` [PATCH v2 6/6] power: supply: add AC power supply driver for AXP813 Oskari Lemmela
2018-10-06 21:18     ` Oskari Lemmela
2018-10-08  7:44     ` Quentin Schulz
2018-10-08  7:44       ` Quentin Schulz
2018-10-08  7:11   ` [PATCH v2 0/6] AXP8x3 AC and battery power supply support Quentin Schulz
2018-10-08  7:11     ` Quentin Schulz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181008072743.ecjb75nixm6wbp6b@qschulz \
    --to=quentin.schulz@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=oskari@lemmela.net \
    --cc=quentin.schulz@free-electrons.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.