* [Buildroot] [git commit] utils/get-developers: add -e flag to only list email addresses for git send-email
@ 2018-10-08 15:47 Thomas Petazzoni
0 siblings, 0 replies; only message in thread
From: Thomas Petazzoni @ 2018-10-08 15:47 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=bcf2ed5cc3e6cba61aedb9eeb34f39d96d612867
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
When called with a list of patches, get-developers prints the entire git
send-email invocation line:
./utils/get-developers 0001-git-security-bump-to-version-2.16.5.patch
git send-email --to buildroot at buildroot.org --cc "Matt Weber <matthew.weber@rockwellcollins.com>"
This may be handy when creating an entire patch series and editing a cover
letter, but it does mean that this has to be explicitly executed and
get-developers cannot be used directly by the --cc-cmd option of git
send-email to automatically CC affected developers.
So add an -e flag to only let get-developers print the email addresses of
the affected developers in the one-email-per-line format expected by git
send-email, similar to how get_maintainer.pl works in the Linux kernel.
With this and a suitable git configuration:
git config sendemail.to buildroot at buildroot.org
git config sendemail.ccCmd "$(pwd)/utils/get-developers -e"
You can simply do:
git send-email master
To automatically mail the buildroot list and CC affected developers on
patches.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
utils/get-developers | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/utils/get-developers b/utils/get-developers
index f525ff2226..9135b41662 100755
--- a/utils/get-developers
+++ b/utils/get-developers
@@ -18,6 +18,8 @@ def parse_args():
help='find developers in charge of these files')
parser.add_argument('-c', dest='check', action='store_const',
const=True, help='list files not handled by any developer')
+ parser.add_argument('-e', dest='email', action='store_const',
+ const=True, help='only list affected developer email addresses')
return parser.parse_args()
@@ -90,12 +92,16 @@ def __main__():
if i in dev.infras:
matching_devs.add(dev.name)
- result = "--to buildroot at buildroot.org"
- for dev in matching_devs:
- result += " --cc \"%s\"" % dev
+ if args.email:
+ for dev in matching_devs:
+ print dev
+ else:
+ result = "--to buildroot at buildroot.org"
+ for dev in matching_devs:
+ result += " --cc \"%s\"" % dev
- if result != "":
- print("git send-email %s" % result)
+ if result != "":
+ print("git send-email %s" % result)
__main__()
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-10-08 15:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-08 15:47 [Buildroot] [git commit] utils/get-developers: add -e flag to only list email addresses for git send-email Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.