All of lore.kernel.org
 help / color / mirror / Atom feed
* [Outreachy kernel][Patch v3] staging: mt7621-dma: Delete unused define
@ 2018-10-10  1:04 Bhanusree Pola
  2018-10-10  6:28 ` Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Bhanusree Pola @ 2018-10-10  1:04 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: greg

delete unused '#define GDMA_REG_CTRL1_CONTINOUS BIT(14)'

Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
---
 drivers/staging/mt7621-dma/ralink-gdma.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c b/drivers/staging/mt7621-dma/ralink-gdma.c
index 6d9fe175ea52..73dbc7fe38a2 100644
--- a/drivers/staging/mt7621-dma/ralink-gdma.c
+++ b/drivers/staging/mt7621-dma/ralink-gdma.c
@@ -47,7 +47,6 @@
 #define GDMA_REG_CTRL1_REQ_MASK		0x3f
 #define GDMA_REG_CTRL1_SRC_REQ_SHIFT	16
 #define GDMA_REG_CTRL1_DST_REQ_SHIFT	8
-#define GDMA_REG_CTRL1_CONTINOUS	BIT(14)
 #define GDMA_REG_CTRL1_NEXT_MASK	0x1f
 #define GDMA_REG_CTRL1_NEXT_SHIFT	3
 #define GDMA_REG_CTRL1_COHERENT		BIT(2)
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel][Patch v3] staging: mt7621-dma: Delete unused define
  2018-10-10  1:04 [Outreachy kernel][Patch v3] staging: mt7621-dma: Delete unused define Bhanusree Pola
@ 2018-10-10  6:28 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2018-10-10  6:28 UTC (permalink / raw)
  To: Bhanusree Pola; +Cc: outreachy-kernel, greg



On Wed, 10 Oct 2018, Bhanusree Pola wrote:

> delete unused '#define GDMA_REG_CTRL1_CONTINOUS BIT(14)'

Did someone ask for this? Often it is useful to keep such #defines,
because they record some information about the hardware.

julia

>
> Signed-off-by: Bhanusree Pola <bhanusreemahesh@gmail.com>
> ---
>  drivers/staging/mt7621-dma/ralink-gdma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/mt7621-dma/ralink-gdma.c b/drivers/staging/mt7621-dma/ralink-gdma.c
> index 6d9fe175ea52..73dbc7fe38a2 100644
> --- a/drivers/staging/mt7621-dma/ralink-gdma.c
> +++ b/drivers/staging/mt7621-dma/ralink-gdma.c
> @@ -47,7 +47,6 @@
>  #define GDMA_REG_CTRL1_REQ_MASK		0x3f
>  #define GDMA_REG_CTRL1_SRC_REQ_SHIFT	16
>  #define GDMA_REG_CTRL1_DST_REQ_SHIFT	8
> -#define GDMA_REG_CTRL1_CONTINOUS	BIT(14)
>  #define GDMA_REG_CTRL1_NEXT_MASK	0x1f
>  #define GDMA_REG_CTRL1_NEXT_SHIFT	3
>  #define GDMA_REG_CTRL1_COHERENT		BIT(2)
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181010010416.GA13096%40veda-VGN-CS3AGH-R.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-10  6:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10  1:04 [Outreachy kernel][Patch v3] staging: mt7621-dma: Delete unused define Bhanusree Pola
2018-10-10  6:28 ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.