* [PATCH] ASoC: max98988: add I2C dependency
@ 2018-10-10 8:37 Arnd Bergmann
2018-10-10 12:05 ` Marco Felsch
2018-10-10 14:40 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2018-10-10 8:37 UTC (permalink / raw)
To: Mark Brown
Cc: Arnd Bergmann, Liam Girdwood, Marco Felsch, alsa-devel, linux-kernel
max98988 only builds with I2C support enabled, otherwise we get a build error:
sound/soc/codecs/max98088.c:1789:1: error: data definition has no type or storage class [-Werror]
module_i2c_driver(max98088_i2c_driver);
^~~~~~~~~~~~~~~~~
sound/soc/codecs/max98088.c:1789:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/max98088.c:1789:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/max98088.c:1780:26: error: 'max98088_i2c_driver' defined but not used [-Werror=unused-variable]
Fixes: 24ae67c58250 ("ASoC: max98988: make it selectable")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 3c6bd6019b92..774d38310875 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -641,6 +641,7 @@ config SND_SOC_LM49453
config SND_SOC_MAX98088
tristate "Maxim MAX98088/9 Low-Power, Stereo Audio Codec"
+ depends on I2C
config SND_SOC_MAX98090
tristate
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: max98988: add I2C dependency
2018-10-10 8:37 [PATCH] ASoC: max98988: add I2C dependency Arnd Bergmann
@ 2018-10-10 12:05 ` Marco Felsch
2018-10-10 14:40 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Marco Felsch @ 2018-10-10 12:05 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Mark Brown, Liam Girdwood, alsa-devel, linux-kernel
Hi Arnd,
On 18-10-10 10:37, Arnd Bergmann wrote:
> max98988 only builds with I2C support enabled, otherwise we get a build error:
>
> sound/soc/codecs/max98088.c:1789:1: error: data definition has no type or storage class [-Werror]
> module_i2c_driver(max98088_i2c_driver);
> ^~~~~~~~~~~~~~~~~
> sound/soc/codecs/max98088.c:1789:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> sound/soc/codecs/max98088.c:1789:1: error: parameter names (without types) in function declaration [-Werror]
> sound/soc/codecs/max98088.c:1780:26: error: 'max98088_i2c_driver' defined but not used [-Werror=unused-variable]
>
> Fixes: 24ae67c58250 ("ASoC: max98988: make it selectable")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for covering the issue.
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Regrads,
Marco
> ---
> sound/soc/codecs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 3c6bd6019b92..774d38310875 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -641,6 +641,7 @@ config SND_SOC_LM49453
>
> config SND_SOC_MAX98088
> tristate "Maxim MAX98088/9 Low-Power, Stereo Audio Codec"
> + depends on I2C
>
> config SND_SOC_MAX98090
> tristate
> --
> 2.18.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ASoC: max98988: add I2C dependency
@ 2018-10-10 12:05 ` Marco Felsch
0 siblings, 0 replies; 5+ messages in thread
From: Marco Felsch @ 2018-10-10 12:05 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: alsa-devel, Mark Brown, Liam Girdwood, linux-kernel
Hi Arnd,
On 18-10-10 10:37, Arnd Bergmann wrote:
> max98988 only builds with I2C support enabled, otherwise we get a build error:
>
> sound/soc/codecs/max98088.c:1789:1: error: data definition has no type or storage class [-Werror]
> module_i2c_driver(max98088_i2c_driver);
> ^~~~~~~~~~~~~~~~~
> sound/soc/codecs/max98088.c:1789:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
> sound/soc/codecs/max98088.c:1789:1: error: parameter names (without types) in function declaration [-Werror]
> sound/soc/codecs/max98088.c:1780:26: error: 'max98088_i2c_driver' defined but not used [-Werror=unused-variable]
>
> Fixes: 24ae67c58250 ("ASoC: max98988: make it selectable")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for covering the issue.
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Regrads,
Marco
> ---
> sound/soc/codecs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 3c6bd6019b92..774d38310875 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -641,6 +641,7 @@ config SND_SOC_LM49453
>
> config SND_SOC_MAX98088
> tristate "Maxim MAX98088/9 Low-Power, Stereo Audio Codec"
> + depends on I2C
>
> config SND_SOC_MAX98090
> tristate
> --
> 2.18.0
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "ASoC: max98988: add I2C dependency" to the asoc tree
2018-10-10 8:37 [PATCH] ASoC: max98988: add I2C dependency Arnd Bergmann
@ 2018-10-10 14:40 ` Mark Brown
2018-10-10 14:40 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2018-10-10 14:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mark Brown, Mark Brown, linux-kernel, alsa-devel, Liam Girdwood,
Marco Felsch, alsa-devel
The patch
ASoC: max98988: add I2C dependency
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From 9641faa2db7e856f50a6d1169e1b9f01e7fcb2b0 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 10 Oct 2018 10:37:13 +0200
Subject: [PATCH] ASoC: max98988: add I2C dependency
max98988 only builds with I2C support enabled, otherwise we get a build error:
sound/soc/codecs/max98088.c:1789:1: error: data definition has no type or storage class [-Werror]
module_i2c_driver(max98088_i2c_driver);
^~~~~~~~~~~~~~~~~
sound/soc/codecs/max98088.c:1789:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/max98088.c:1789:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/max98088.c:1780:26: error: 'max98088_i2c_driver' defined but not used [-Werror=unused-variable]
Fixes: 24ae67c58250 ("ASoC: max98988: make it selectable")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 3c6bd6019b92..774d38310875 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -641,6 +641,7 @@ config SND_SOC_LM49453
config SND_SOC_MAX98088
tristate "Maxim MAX98088/9 Low-Power, Stereo Audio Codec"
+ depends on I2C
config SND_SOC_MAX98090
tristate
--
2.19.0.rc2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Applied "ASoC: max98988: add I2C dependency" to the asoc tree
@ 2018-10-10 14:40 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2018-10-10 14:40 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Mark Brown
The patch
ASoC: max98988: add I2C dependency
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From 9641faa2db7e856f50a6d1169e1b9f01e7fcb2b0 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 10 Oct 2018 10:37:13 +0200
Subject: [PATCH] ASoC: max98988: add I2C dependency
max98988 only builds with I2C support enabled, otherwise we get a build error:
sound/soc/codecs/max98088.c:1789:1: error: data definition has no type or storage class [-Werror]
module_i2c_driver(max98088_i2c_driver);
^~~~~~~~~~~~~~~~~
sound/soc/codecs/max98088.c:1789:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
sound/soc/codecs/max98088.c:1789:1: error: parameter names (without types) in function declaration [-Werror]
sound/soc/codecs/max98088.c:1780:26: error: 'max98088_i2c_driver' defined but not used [-Werror=unused-variable]
Fixes: 24ae67c58250 ("ASoC: max98988: make it selectable")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index 3c6bd6019b92..774d38310875 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -641,6 +641,7 @@ config SND_SOC_LM49453
config SND_SOC_MAX98088
tristate "Maxim MAX98088/9 Low-Power, Stereo Audio Codec"
+ depends on I2C
config SND_SOC_MAX98090
tristate
--
2.19.0.rc2
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-10 14:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 8:37 [PATCH] ASoC: max98988: add I2C dependency Arnd Bergmann
2018-10-10 12:05 ` Marco Felsch
2018-10-10 12:05 ` Marco Felsch
2018-10-10 14:40 ` Applied "ASoC: max98988: add I2C dependency" to the asoc tree Mark Brown
2018-10-10 14:40 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.