From: "Darrick J. Wong" <darrick.wong@oracle.com> To: Amir Goldstein <amir73il@gmail.com> Cc: Dave Chinner <david@fromorbit.com>, Eric Sandeen <sandeen@redhat.com>, Linux NFS Mailing List <linux-nfs@vger.kernel.org>, linux-cifs@vger.kernel.org, overlayfs <linux-unionfs@vger.kernel.org>, linux-xfs <linux-xfs@vger.kernel.org>, Linux MM <linux-mm@kvack.org>, Linux Btrfs <linux-btrfs@vger.kernel.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 14/25] vfs: make remap_file_range functions take and return bytes completed Date: Wed, 10 Oct 2018 11:32:36 -0700 [thread overview] Message-ID: <20181010183236.GU28243@magnolia> (raw) In-Reply-To: <CAOQ4uxjsKZHxoYqbnJTxQ1SPGn7o_2QhYseuETHnvZxvgCV5vg@mail.gmail.com> On Wed, Oct 10, 2018 at 09:28:34PM +0300, Amir Goldstein wrote: > On Wed, Oct 10, 2018 at 6:51 PM Darrick J. Wong <darrick.wong@oracle.com> wrote: > > > > On Wed, Oct 10, 2018 at 09:47:00AM +0300, Amir Goldstein wrote: > > > On Wed, Oct 10, 2018 at 3:14 AM Darrick J. Wong <darrick.wong@oracle.com> wrote: > > > > > > > > From: Darrick J. Wong <darrick.wong@oracle.com> > > > > > > > > Change the remap_file_range functions to take a number of bytes to > > > > operate upon and return the number of bytes they operated on. This is a > > > > requirement for allowing fs implementations to return short clone/dedupe > > > > results to the user, which will enable us to obey resource limits in a > > > > graceful manner. > > > > > > > > A subsequent patch will enable copy_file_range to signal to the > > > > ->clone_file_range implementation that it can handle a short length, > > > > which will be returned in the function's return value. Neither clone > > > > ioctl can take advantage of this, alas. > > > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > > > --- > [...] > > > Commit message wasn't clear enough on the behavior of copy_file_range() > > > before and after the patch IMO. Maybe it would be better to pospone this > > > semantic change to the RFR_SHORTEN patch and keep if (cloned == len) > > > in this patch? > > > > There shouldn't be any behavior change here -- all implementations > > return a negative error code or the length that was passed in. I'll > > clarify that in the commit message. > > > > OK. BTW, you forgot to update Documentation/filesystems/vfs.txt. Yeah, I noticed that and updated it too. > Also since this series has a potential to break clone/dedup on > overlayfs, it would be great if you could run some of the clone/dedupe > xfstests with overlay over xfs. > > For the simple case of running ./check with a local.config file that is > not multi section, this just means running ./check -overlay after the > first ./check run (-overlay doesn't mkfs the base fs). I'll give it a try, though we should probably both run '-g clone' just to make sure everything is working... > If this is a problem, let me know once new devel branch is ready Yeah, Dave asked me to merge the xfs for-next branch so I'm working on that too. > and I'll pull it for testing. If I need to pull in extra xfstests, please > mention that as well. You'll probably want "generic: test creation time recovery after power failure" that I sent to the fstests lists a few days ago. --D > > Thanks, > Amir.
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com> To: Amir Goldstein <amir73il@gmail.com> Cc: Dave Chinner <david@fromorbit.com>, Eric Sandeen <sandeen@redhat.com>, Linux NFS Mailing List <linux-nfs@vger.kernel.org>, linux-cifs@vger.kernel.org, overlayfs <linux-unionfs@vger.kernel.org>, linux-xfs <linux-xfs@vger.kernel.org>, Linux MM <linux-mm@kvack.org>, Linux Btrfs <linux-btrfs@vger.kernel.org>, linux-fsdevel <linux-fsdevel@vger.kernel.org>, ocfs2-devel@oss.oracle.com Subject: [Ocfs2-devel] [PATCH 14/25] vfs: make remap_file_range functions take and return bytes completed Date: Wed, 10 Oct 2018 11:32:36 -0700 [thread overview] Message-ID: <20181010183236.GU28243@magnolia> (raw) In-Reply-To: <CAOQ4uxjsKZHxoYqbnJTxQ1SPGn7o_2QhYseuETHnvZxvgCV5vg@mail.gmail.com> On Wed, Oct 10, 2018 at 09:28:34PM +0300, Amir Goldstein wrote: > On Wed, Oct 10, 2018 at 6:51 PM Darrick J. Wong <darrick.wong@oracle.com> wrote: > > > > On Wed, Oct 10, 2018 at 09:47:00AM +0300, Amir Goldstein wrote: > > > On Wed, Oct 10, 2018 at 3:14 AM Darrick J. Wong <darrick.wong@oracle.com> wrote: > > > > > > > > From: Darrick J. Wong <darrick.wong@oracle.com> > > > > > > > > Change the remap_file_range functions to take a number of bytes to > > > > operate upon and return the number of bytes they operated on. This is a > > > > requirement for allowing fs implementations to return short clone/dedupe > > > > results to the user, which will enable us to obey resource limits in a > > > > graceful manner. > > > > > > > > A subsequent patch will enable copy_file_range to signal to the > > > > ->clone_file_range implementation that it can handle a short length, > > > > which will be returned in the function's return value. Neither clone > > > > ioctl can take advantage of this, alas. > > > > > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > > > --- > [...] > > > Commit message wasn't clear enough on the behavior of copy_file_range() > > > before and after the patch IMO. Maybe it would be better to pospone this > > > semantic change to the RFR_SHORTEN patch and keep if (cloned == len) > > > in this patch? > > > > There shouldn't be any behavior change here -- all implementations > > return a negative error code or the length that was passed in. I'll > > clarify that in the commit message. > > > > OK. BTW, you forgot to update Documentation/filesystems/vfs.txt. Yeah, I noticed that and updated it too. > Also since this series has a potential to break clone/dedup on > overlayfs, it would be great if you could run some of the clone/dedupe > xfstests with overlay over xfs. > > For the simple case of running ./check with a local.config file that is > not multi section, this just means running ./check -overlay after the > first ./check run (-overlay doesn't mkfs the base fs). I'll give it a try, though we should probably both run '-g clone' just to make sure everything is working... > If this is a problem, let me know once new devel branch is ready Yeah, Dave asked me to merge the xfs for-next branch so I'm working on that too. > and I'll pull it for testing. If I need to pull in extra xfstests, please > mention that as well. You'll probably want "generic: test creation time recovery after power failure" that I sent to the fstests lists a few days ago. --D > > Thanks, > Amir.
next prev parent reply other threads:[~2018-10-10 18:32 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-10 0:10 [PATCH v2 00/25] fs: fixes for serious clone/dedupe problems Darrick J. Wong 2018-10-10 0:10 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:10 ` [PATCH 01/25] xfs: add a per-xfs trace_printk macro Darrick J. Wong 2018-10-10 0:10 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:36 ` Dave Chinner 2018-10-10 0:36 ` [Ocfs2-devel] " Dave Chinner 2018-10-10 15:00 ` [PATCH v2 " Darrick J. Wong 2018-10-10 15:00 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:10 ` [PATCH 02/25] xfs: refactor clonerange preparation into a separate helper Darrick J. Wong 2018-10-10 0:10 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:10 ` [PATCH 03/25] xfs: zero posteof blocks when cloning above eof Darrick J. Wong 2018-10-10 0:10 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:11 ` [PATCH 04/25] xfs: update ctime and remove suid before cloning files Darrick J. Wong 2018-10-10 0:11 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:11 ` [PATCH 05/25] vfs: check file ranges " Darrick J. Wong 2018-10-10 0:11 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 23:06 ` Dave Chinner 2018-10-10 23:06 ` [Ocfs2-devel] " Dave Chinner 2018-10-10 23:13 ` Darrick J. Wong 2018-10-10 23:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:11 ` [PATCH 06/25] vfs: strengthen checking of file range inputs to generic_remap_checks Darrick J. Wong 2018-10-10 0:11 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 5:23 ` Amir Goldstein 2018-10-10 17:01 ` Darrick J. Wong 2018-10-10 17:01 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 17:26 ` Amir Goldstein 2018-10-10 0:11 ` [PATCH 07/25] vfs: skip zero-length dedupe requests Darrick J. Wong 2018-10-10 0:11 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:11 ` [PATCH 08/25] vfs: combine the clone and dedupe into a single remap_file_range Darrick J. Wong 2018-10-10 0:11 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 5:54 ` Amir Goldstein 2018-10-10 15:13 ` Darrick J. Wong 2018-10-10 15:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 15:23 ` Amir Goldstein 2018-10-10 0:11 ` [PATCH 09/25] vfs: rename vfs_clone_file_prep to be more descriptive Darrick J. Wong 2018-10-10 0:11 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:11 ` [PATCH 10/25] vfs: rename clone_verify_area to remap_verify_area Darrick J. Wong 2018-10-10 0:11 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:13 ` [PATCH 11/25] vfs: create generic_remap_file_range_touch to update inode metadata Darrick J. Wong 2018-10-10 0:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:13 ` [PATCH 12/25] vfs: pass remap flags to generic_remap_file_range_prep Darrick J. Wong 2018-10-10 0:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:13 ` [PATCH 13/25] vfs: pass remap flags to generic_remap_checks Darrick J. Wong 2018-10-10 0:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:13 ` [PATCH 14/25] vfs: make remap_file_range functions take and return bytes completed Darrick J. Wong 2018-10-10 0:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 6:47 ` Amir Goldstein 2018-10-10 15:50 ` Darrick J. Wong 2018-10-10 15:50 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 18:28 ` Amir Goldstein 2018-10-10 18:32 ` Darrick J. Wong [this message] 2018-10-10 18:32 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:13 ` [PATCH 15/25] vfs: plumb RFR_* remap flags through the vfs clone functions Darrick J. Wong 2018-10-10 0:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 6:22 ` Amir Goldstein 2018-10-10 6:39 ` Amir Goldstein 2018-10-10 0:13 ` [PATCH 16/25] vfs: plumb RFR_* remap flags through the vfs dedupe functions Darrick J. Wong 2018-10-10 0:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:13 ` [PATCH 17/25] vfs: make remapping to source file eof more explicit Darrick J. Wong 2018-10-10 0:13 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 12:29 ` Amir Goldstein 2018-10-10 16:29 ` Darrick J. Wong 2018-10-10 16:29 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 17:31 ` Amir Goldstein 2018-10-10 0:14 ` [PATCH 18/25] vfs: enable remap callers that can handle short operations Darrick J. Wong 2018-10-10 0:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:14 ` [PATCH 19/25] vfs: hide file range comparison function Darrick J. Wong 2018-10-10 0:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:14 ` [PATCH 20/25] vfs: implement opportunistic short dedupe Darrick J. Wong 2018-10-10 0:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:14 ` [PATCH 21/25] ocfs2: truncate page cache for clone destination file before remapping Darrick J. Wong 2018-10-10 0:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:14 ` [PATCH 22/25] ocfs2: fix pagecache truncation prior to reflink Darrick J. Wong 2018-10-10 0:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:14 ` [PATCH 23/25] ocfs2: support partial clone range and dedupe range Darrick J. Wong 2018-10-10 0:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:14 ` [PATCH 24/25] xfs: fix pagecache truncation prior to reflink Darrick J. Wong 2018-10-10 0:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 0:14 ` [PATCH 25/25] xfs: support returning partial reflink results Darrick J. Wong 2018-10-10 0:14 ` [Ocfs2-devel] " Darrick J. Wong 2018-10-10 1:02 ` [PATCH v2 00/25] fs: fixes for serious clone/dedupe problems Dave Chinner 2018-10-10 1:02 ` [Ocfs2-devel] " Dave Chinner 2018-10-10 1:06 ` Darrick J. Wong 2018-10-10 1:06 ` [Ocfs2-devel] " Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181010183236.GU28243@magnolia \ --to=darrick.wong@oracle.com \ --cc=amir73il@gmail.com \ --cc=david@fromorbit.com \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-nfs@vger.kernel.org \ --cc=linux-unionfs@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=ocfs2-devel@oss.oracle.com \ --cc=sandeen@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.