All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] scanpypi: improve BSD licence handling
@ 2018-10-11  5:54 yegorslists at googlemail.com
  2018-10-11  7:33 ` Thomas Petazzoni
  2018-10-23 23:08 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: yegorslists at googlemail.com @ 2018-10-11  5:54 UTC (permalink / raw)
  To: buildroot

From: Yegor Yefremov <yegorslists@googlemail.com>

When used without spdx_lookup the BSD licence cannot be
detected correctly because many Python packages just specify
BSD without the exact version in their metadata. So add a
special message warning the user instead of the licence id.

Bonus: fix typo.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 utils/scanpypi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/utils/scanpypi b/utils/scanpypi
index 31e242e3db..3983be1ad1 100755
--- a/utils/scanpypi
+++ b/utils/scanpypi
@@ -395,7 +395,7 @@ class BuildrootPackage():
         """
         Try to determine the related license name.
 
-        There are two possibilities. Either the scripts tries to
+        There are two possibilities. Either the script tries to
         get license name from package's metadata or, if spdx_lookup
         package is available, the script compares license files with
         SPDX database.
@@ -404,7 +404,7 @@ class BuildrootPackage():
         if liclookup is None:
             license_dict = {
                 'Apache Software License': 'Apache-2.0',
-                'BSD License': 'BSD',
+                'BSD License': 'FIXME: please specify the exact BSD version',
                 'European Union Public Licence 1.0': 'EUPL-1.0',
                 'European Union Public Licence 1.1': 'EUPL-1.1',
                 "GNU General Public License": "GPL",
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] scanpypi: improve BSD licence handling
  2018-10-11  5:54 [Buildroot] [PATCH] scanpypi: improve BSD licence handling yegorslists at googlemail.com
@ 2018-10-11  7:33 ` Thomas Petazzoni
  2018-10-23 23:08 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-10-11  7:33 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 11 Oct 2018 07:54:11 +0200, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> When used without spdx_lookup the BSD licence cannot be
> detected correctly because many Python packages just specify
> BSD without the exact version in their metadata. So add a
> special message warning the user instead of the licence id.
> 
> Bonus: fix typo.
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  utils/scanpypi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] scanpypi: improve BSD licence handling
  2018-10-11  5:54 [Buildroot] [PATCH] scanpypi: improve BSD licence handling yegorslists at googlemail.com
  2018-10-11  7:33 ` Thomas Petazzoni
@ 2018-10-23 23:08 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-10-23 23:08 UTC (permalink / raw)
  To: buildroot

>>>>> "yegorslists" == yegorslists  <yegorslists@googlemail.com> writes:

 > From: Yegor Yefremov <yegorslists@googlemail.com>
 > When used without spdx_lookup the BSD licence cannot be
 > detected correctly because many Python packages just specify
 > BSD without the exact version in their metadata. So add a
 > special message warning the user instead of the licence id.

 > Bonus: fix typo.

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Committed to 2018.02.x and 2018.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-10-23 23:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11  5:54 [Buildroot] [PATCH] scanpypi: improve BSD licence handling yegorslists at googlemail.com
2018-10-11  7:33 ` Thomas Petazzoni
2018-10-23 23:08 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.