* [igt-dev] [PATCH i-g-t] Add TODO.rst
@ 2018-10-11 16:36 Daniel Vetter
2018-10-11 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel Vetter @ 2018-10-11 16:36 UTC (permalink / raw)
To: IGT development; +Cc: Petri Latvala, Rodrigo Vivi, Daniel Vetter
First attempt at collecting a bunch of cleanup tasks. I think using
the kernel as an example, it's much better if we keep these here than
in our own internal $bug_db instance.
v2: Fix typo (Rodrigo).
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
TODO.rst | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
create mode 100644 TODO.rst
diff --git a/TODO.rst b/TODO.rst
new file mode 100644
index 000000000000..eb3e50f14ed4
--- /dev/null
+++ b/TODO.rst
@@ -0,0 +1,31 @@
+TODO
+====
+
+This contains a list of refactoring, cleanup and getting-started tasks around
+the IGT library.
+
+Split up igt_kms.c/igt_kms.h
+----------------------------
+
+igt_kms contains both a low-level modeset library, with thin convenience
+wrappers around core kernel code and libdrm. These functions usually have a
+drmtest_ prefix (but not all of them).
+
+The other part is a higher-level library around the igt_display and related
+structures. Those usually come with an igt_ prefix.
+
+The task would be to split this up, and where necessary, fix up the prefixes to
+match the level a function operates at.
+
+Remove property enums from igt_kms
+----------------------------------
+
+These are just needless indirection for writing tests. We can keep the #defines
+(since those strings are defacto uapi), but everything else is best handled by
+runtime-sizing all the arrays.
+
+Documentation
+-------------
+
+igt documentation is full of warnings and fairly incomplete. Pick a library, and
+work together with its authors to fix things up.
--
2.19.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Add TODO.rst
2018-10-11 16:36 [igt-dev] [PATCH i-g-t] Add TODO.rst Daniel Vetter
@ 2018-10-11 17:05 ` Patchwork
2018-10-11 17:26 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
2018-10-11 22:03 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-10-11 17:05 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: Add TODO.rst
URL : https://patchwork.freedesktop.org/series/50876/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4958 -> IGTPW_1942 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50876/revisions/1/mbox/
== Known issues ==
Here are the changes found in IGTPW_1942 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
{fi-icl-u2}: PASS -> INCOMPLETE (fdo#108315)
==== Possible fixes ====
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@pm_rpm@basic-pci-d3-state:
fi-skl-6600u: FAIL (fdo#107707) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#107707 https://bugs.freedesktop.org/show_bug.cgi?id=107707
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
== Participating hosts (48 -> 40) ==
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-ctg-p8600 fi-byt-n2820 fi-snb-2600
== Build changes ==
* IGT: IGT_4672 -> IGTPW_1942
CI_DRM_4958: 9990e1665029dc2ef4a9c0632b8a2f516263e595 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1942: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1942/
IGT_4672: 4497591d2572831a9f07fd9e48a2571bfcffe354 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1942/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] Add TODO.rst
2018-10-11 16:36 [igt-dev] [PATCH i-g-t] Add TODO.rst Daniel Vetter
2018-10-11 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-11 17:26 ` Rodrigo Vivi
2018-10-11 22:03 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2018-10-11 17:26 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Daniel Vetter, Petri Latvala
On Thu, Oct 11, 2018 at 06:36:32PM +0200, Daniel Vetter wrote:
> First attempt at collecting a bunch of cleanup tasks. I think using
> the kernel as an example, it's much better if we keep these here than
> in our own internal $bug_db instance.
>
> v2: Fix typo (Rodrigo).
>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> TODO.rst | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 TODO.rst
>
> diff --git a/TODO.rst b/TODO.rst
> new file mode 100644
> index 000000000000..eb3e50f14ed4
> --- /dev/null
> +++ b/TODO.rst
> @@ -0,0 +1,31 @@
> +TODO
> +====
> +
> +This contains a list of refactoring, cleanup and getting-started tasks around
> +the IGT library.
> +
> +Split up igt_kms.c/igt_kms.h
> +----------------------------
> +
> +igt_kms contains both a low-level modeset library, with thin convenience
> +wrappers around core kernel code and libdrm. These functions usually have a
> +drmtest_ prefix (but not all of them).
> +
> +The other part is a higher-level library around the igt_display and related
> +structures. Those usually come with an igt_ prefix.
> +
> +The task would be to split this up, and where necessary, fix up the prefixes to
> +match the level a function operates at.
> +
> +Remove property enums from igt_kms
> +----------------------------------
> +
> +These are just needless indirection for writing tests. We can keep the #defines
> +(since those strings are defacto uapi), but everything else is best handled by
> +runtime-sizing all the arrays.
> +
> +Documentation
> +-------------
> +
> +igt documentation is full of warnings and fairly incomplete. Pick a library, and
> +work together with its authors to fix things up.
> --
> 2.19.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Add TODO.rst
2018-10-11 16:36 [igt-dev] [PATCH i-g-t] Add TODO.rst Daniel Vetter
2018-10-11 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-11 17:26 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
@ 2018-10-11 22:03 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-10-11 22:03 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: Add TODO.rst
URL : https://patchwork.freedesktop.org/series/50876/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4672_full -> IGTPW_1942_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1942_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1942_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50876/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1942_full:
=== IGT changes ===
==== Warnings ====
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
igt@pm_rc6_residency@rc6-accuracy:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1942_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: PASS -> INCOMPLETE (fdo#106023, fdo#103665)
igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133) +1
igt@kms_color@pipe-a-legacy-gamma:
shard-kbl: PASS -> FAIL (fdo#108145, fdo#104782)
shard-apl: PASS -> FAIL (fdo#108145, fdo#104782)
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-apl: PASS -> FAIL (fdo#103191, fdo#103232)
igt@kms_cursor_crc@cursor-128x42-random:
shard-glk: PASS -> FAIL (fdo#103232) +1
shard-kbl: PASS -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-64x21-sliding:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled:
shard-glk: PASS -> FAIL (fdo#103184)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-apl: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
shard-glk: PASS -> FAIL (fdo#103167) +4
igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-glk: PASS -> FAIL (fdo#108145)
shard-kbl: PASS -> FAIL (fdo#108145)
shard-apl: PASS -> FAIL (fdo#108145)
igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
shard-glk: PASS -> FAIL (fdo#103166)
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
shard-kbl: PASS -> FAIL (fdo#103166)
igt@kms_vblank@pipe-a-query-forked-busy-hang:
shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763) +1
==== Possible fixes ====
igt@kms_available_modes_crc@available_mode_test_crc:
shard-apl: FAIL (fdo#106641) -> PASS
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-kbl: DMESG-WARN (fdo#107956) -> PASS
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_cursor_crc@cursor-128x42-onscreen:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_crc@cursor-256x256-sliding:
shard-glk: FAIL (fdo#103232) -> PASS +2
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-apl: FAIL (fdo#103191, fdo#103232) -> PASS
igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
shard-hsw: FAIL (fdo#105767) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-snb: INCOMPLETE (fdo#105411) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: FAIL (fdo#103167) -> PASS +1
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-glk: FAIL (fdo#103166) -> PASS +2
igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
shard-apl: FAIL (fdo#103166) -> PASS
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 5) ==
Missing (1): shard-skl
== Build changes ==
* IGT: IGT_4672 -> IGTPW_1942
* Linux: CI_DRM_4952 -> CI_DRM_4958
CI_DRM_4952: a62e43ba13605a478b22307ea1790d48aea029a6 @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4958: 9990e1665029dc2ef4a9c0632b8a2f516263e595 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1942: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1942/
IGT_4672: 4497591d2572831a9f07fd9e48a2571bfcffe354 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1942/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-11 22:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11 16:36 [igt-dev] [PATCH i-g-t] Add TODO.rst Daniel Vetter
2018-10-11 17:05 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-10-11 17:26 ` [igt-dev] [PATCH i-g-t] " Rodrigo Vivi
2018-10-11 22:03 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.