* [Buildroot] [PATCH 1/1] xerces: fix buid with older cmake
@ 2018-10-11 19:04 Fabrice Fontaine
2018-10-11 20:08 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2018-10-11 19:04 UTC (permalink / raw)
To: buildroot
Old version of cmake break cross-compilation when FindThreads is used
because of a try_run call. Add a workaround that avoids try_run.
cmake bug report: https://gitlab.kitware.com/cmake/cmake/issues/16920
Fixes:
- http://autobuild.buildroot.org/results/784918c58310474e8b4a0b42850a55ba35a1a19e
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/xerces/xerces.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/xerces/xerces.mk b/package/xerces/xerces.mk
index 906e4b663c..c75a8b0d35 100644
--- a/package/xerces/xerces.mk
+++ b/package/xerces/xerces.mk
@@ -17,6 +17,11 @@ endef
XERCES_POST_PATCH_HOOKS += XERCES_DISABLE_SAMPLES
+# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
+# disable a try_run() call in the FindThreads tests, which caused a
+# build failure when cross-compiling.
+XERCES_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
+
ifeq ($(BR2_PACKAGE_ICU),y)
XERCES_DEPENDENCIES += icu
endif
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] xerces: fix buid with older cmake
2018-10-11 19:04 [Buildroot] [PATCH 1/1] xerces: fix buid with older cmake Fabrice Fontaine
@ 2018-10-11 20:08 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-10-11 20:08 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 11 Oct 2018 21:04:29 +0200, Fabrice Fontaine wrote:
> Old version of cmake break cross-compilation when FindThreads is used
> because of a try_run call. Add a workaround that avoids try_run.
>
> cmake bug report: https://gitlab.kitware.com/cmake/cmake/issues/16920
>
> Fixes:
> - http://autobuild.buildroot.org/results/784918c58310474e8b4a0b42850a55ba35a1a19e
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/xerces/xerces.mk | 5 +++++
> 1 file changed, 5 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-11 20:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11 19:04 [Buildroot] [PATCH 1/1] xerces: fix buid with older cmake Fabrice Fontaine
2018-10-11 20:08 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.