* [Buildroot] [PATCH 1/1] utils/get-developers: fix syntax error
@ 2018-10-11 23:00 Grégoire Delattre
2018-10-12 7:05 ` Peter Korsgaard
0 siblings, 1 reply; 2+ messages in thread
From: Grégoire Delattre @ 2018-10-11 23:00 UTC (permalink / raw)
To: buildroot
From: Gr?goire Delattre <gregoire.delattre@gmail.com>
This fixes a syntax error introduced in bcf2ed5cc3.
Output before the patch:
$ ./utils/get-developers outgoing/*
File "./utils/get-developers", line 97
print dev
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean
print(dev)?
Output after the patch:
$ ./utils/get-developers outgoing/*
git send-email --to buildroot at buildroot.org
Signed-off-by: Gr?goire Delattre <gregoire.delattre@gmail.com>
---
utils/get-developers | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/get-developers b/utils/get-developers
index 9135b41662..ce882e6699 100755
--- a/utils/get-developers
+++ b/utils/get-developers
@@ -94,7 +94,7 @@ def __main__():
if args.email:
for dev in matching_devs:
- print dev
+ print(dev)
else:
result = "--to buildroot at buildroot.org"
for dev in matching_devs:
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] utils/get-developers: fix syntax error
2018-10-11 23:00 [Buildroot] [PATCH 1/1] utils/get-developers: fix syntax error Grégoire Delattre
@ 2018-10-12 7:05 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2018-10-12 7:05 UTC (permalink / raw)
To: buildroot
>>>>> "Gr?goire" == Gr?goire Delattre <greg@quimbo.fr> writes:
> From: Gr?goire Delattre <gregoire.delattre@gmail.com>
> This fixes a syntax error introduced in bcf2ed5cc3.
> Output before the patch:
> $ ./utils/get-developers outgoing/*
> File "./utils/get-developers", line 97
> print dev
> ^
> SyntaxError: Missing parentheses in call to 'print'. Did you mean
> print(dev)?
> Output after the patch:
> $ ./utils/get-developers outgoing/*
> git send-email --to buildroot at buildroot.org
Ahh, indeed - We need print(foo) instead of print foo for python 3.x
compatibility.
Committed with the commit message extended to explain that this is for
python 3.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-12 7:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11 23:00 [Buildroot] [PATCH 1/1] utils/get-developers: fix syntax error Grégoire Delattre
2018-10-12 7:05 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.