* [PATCH] drm/i915/icl: enable SAGV for ICL platform
@ 2018-10-11 22:57 Paulo Zanoni
2018-10-11 23:30 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Paulo Zanoni @ 2018-10-11 22:57 UTC (permalink / raw)
To: intel-gfx; +Cc: Paulo Zanoni
From: Mahesh Kumar <mahesh1.kumar@intel.com>
Enable SAGV for ICL platform.
Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Reviewed-by: James Ausmus <james.ausmus@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I had previously blocked this patch in January:
https://patchwork.freedesktop.org/patch/200285/
But since then the spec was fixed and now the requirements listed for
sagv on ICL are the same as for the previous platforms, so the patch
is now valid. Thanks to Gwan-gyeong Mun for re-checking that.
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 7a53079f3196..b9febe1d2f6b 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -3613,7 +3613,7 @@ static bool
intel_has_sagv(struct drm_i915_private *dev_priv)
{
if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
- IS_CANNONLAKE(dev_priv))
+ IS_CANNONLAKE(dev_priv) || IS_ICELAKE(dev_priv))
return true;
if (IS_SKYLAKE(dev_priv) &&
--
2.14.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/icl: enable SAGV for ICL platform
2018-10-11 22:57 [PATCH] drm/i915/icl: enable SAGV for ICL platform Paulo Zanoni
@ 2018-10-11 23:30 ` Patchwork
2018-10-12 5:14 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-12 13:55 ` [PATCH] " Mun, Gwan-gyeong
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-10-11 23:30 UTC (permalink / raw)
To: Paulo Zanoni; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: enable SAGV for ICL platform
URL : https://patchwork.freedesktop.org/series/50888/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4975 -> Patchwork_10431 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50888/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10431 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-icl-u: NOTRUN -> INCOMPLETE (fdo#108315)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
fi-cfl-8109u: INCOMPLETE (fdo#108126, fdo#107187) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@pm_rpm@basic-pci-d3-state:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS
igt@pm_rpm@module-reload:
fi-glk-j4005: DMESG-WARN (fdo#107726, fdo#106097) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#107187 https://bugs.freedesktop.org/show_bug.cgi?id=107187
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107726 https://bugs.freedesktop.org/show_bug.cgi?id=107726
fdo#108126 https://bugs.freedesktop.org/show_bug.cgi?id=108126
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
== Participating hosts (43 -> 41) ==
Additional (2): fi-skl-guc fi-icl-u
Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
== Build changes ==
* Linux: CI_DRM_4975 -> Patchwork_10431
CI_DRM_4975: 2079843dea0b57ecf37532761a95e3f0752d1260 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4674: 93871c6fb3c25e5d350c9faf36ded917174214de @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10431: 171603a8ed7fa6a375d97f0ba385d229a4ec3d58 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
171603a8ed7f drm/i915/icl: enable SAGV for ICL platform
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10431/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/icl: enable SAGV for ICL platform
2018-10-11 22:57 [PATCH] drm/i915/icl: enable SAGV for ICL platform Paulo Zanoni
2018-10-11 23:30 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-10-12 5:14 ` Patchwork
2018-10-12 13:55 ` [PATCH] " Mun, Gwan-gyeong
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-10-12 5:14 UTC (permalink / raw)
To: Paulo Zanoni; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/icl: enable SAGV for ICL platform
URL : https://patchwork.freedesktop.org/series/50888/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4975_full -> Patchwork_10431_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10431_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10431_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10431_full:
=== IGT changes ===
==== Warnings ====
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-shrfb-msflip-blt:
shard-hsw: SKIP -> PASS
igt@perf_pmu@rc6:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_10431_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: PASS -> INCOMPLETE (fdo#106023, fdo#103665)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
shard-snb: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-hang-newfb-render-a:
shard-apl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_color@pipe-c-gamma:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_cursor_crc@cursor-64x21-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-apl: PASS -> FAIL (fdo#103232, fdo#103191) +1
igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
shard-hsw: PASS -> FAIL (fdo#105767)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
shard-apl: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_plane@pixel-format-pipe-b-planes:
shard-skl: NOTRUN -> DMESG-FAIL (fdo#103166, fdo#106885)
igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
shard-glk: PASS -> FAIL (fdo#108145)
igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
shard-skl: NOTRUN -> FAIL (fdo#108145)
igt@pm_rpm@gem-idle:
shard-skl: PASS -> INCOMPLETE (fdo#107807)
igt@pm_rpm@system-suspend-modeset:
shard-skl: PASS -> INCOMPLETE (fdo#107807, fdo#104108)
==== Possible fixes ====
igt@gem_exec_await@wide-contexts:
shard-glk: FAIL (fdo#106680) -> PASS
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665) -> PASS
igt@gem_softpin@noreloc-s3:
shard-skl: INCOMPLETE (fdo#104108, fdo#107773) -> PASS
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-glk: DMESG-WARN (fdo#107956) -> PASS
igt@kms_chv_cursor_fail@pipe-b-64x64-left-edge:
shard-kbl: DMESG-WARN -> PASS
igt@kms_cursor_crc@cursor-256x85-onscreen:
shard-apl: FAIL (fdo#103232) -> PASS +1
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS
igt@kms_flip@flip-vs-modeset-interruptible:
shard-hsw: DMESG-WARN (fdo#102614) -> PASS
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
shard-glk: FAIL (fdo#103167) -> PASS +5
igt@kms_frontbuffer_tracking@fbc-suspend:
shard-kbl: DMESG-WARN (fdo#103313) -> PASS
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-glk: FAIL (fdo#103166) -> PASS
igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
shard-hsw: FAIL (fdo#99912) -> PASS
igt@kms_vblank@pipe-c-ts-continuation-suspend:
shard-apl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +1
igt@prime_vgem@basic-fence-flip:
shard-kbl: FAIL (fdo#104008) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106885 https://bugs.freedesktop.org/show_bug.cgi?id=106885
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4975 -> Patchwork_10431
CI_DRM_4975: 2079843dea0b57ecf37532761a95e3f0752d1260 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4674: 93871c6fb3c25e5d350c9faf36ded917174214de @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10431: 171603a8ed7fa6a375d97f0ba385d229a4ec3d58 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10431/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/icl: enable SAGV for ICL platform
2018-10-11 22:57 [PATCH] drm/i915/icl: enable SAGV for ICL platform Paulo Zanoni
2018-10-11 23:30 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-12 5:14 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-10-12 13:55 ` Mun, Gwan-gyeong
2 siblings, 0 replies; 4+ messages in thread
From: Mun, Gwan-gyeong @ 2018-10-12 13:55 UTC (permalink / raw)
To: intel-gfx, Zanoni, Paulo R
On Thu, 2018-10-11 at 15:57 -0700, Paulo Zanoni wrote:
> From: Mahesh Kumar <mahesh1.kumar@intel.com>
>
> Enable SAGV for ICL platform.
>
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Reviewed-by: James Ausmus <james.ausmus@intel.com>
> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I had previously blocked this patch in January:
> https://patchwork.freedesktop.org/patch/200285/
>
> But since then the spec was fixed and now the requirements listed for
> sagv on ICL are the same as for the previous platforms, so the patch
> is now valid. Thanks to Gwan-gyeong Mun for re-checking that.
>
As Paulo mentioned, an SAGV between GEN9 and GEN11 uses same algorithm
with different SAGV block time on the each platforms.
This patch looks to be fixing SAGV related FIFO underrun issues of ICL.
[test manners]
Add an external monitor (I tested with a monitor which has usb-c type
connector (it uses dp-alt mode).) (additional explains: edp + usb-c
type monitor were used.)
and check dmesg log which said a disabling SAGV and an occurrence of
FIFO underrun.
[test results]
the dmesg log showed below log
...
[drm:intel_enable_sagv [i915]] Enabling the SAGV
...
[drm:intel_disable_sagv [i915]] Disabling the SAGV
...
and when I tested I didn't meet FIFO underrun message from dmesg.
Tested-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Best regards
> diff --git a/drivers/gpu/drm/i915/intel_pm.c
> b/drivers/gpu/drm/i915/intel_pm.c
> index 7a53079f3196..b9febe1d2f6b 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3613,7 +3613,7 @@ static bool
> intel_has_sagv(struct drm_i915_private *dev_priv)
> {
> if (IS_KABYLAKE(dev_priv) || IS_COFFEELAKE(dev_priv) ||
> - IS_CANNONLAKE(dev_priv))
> + IS_CANNONLAKE(dev_priv) || IS_ICELAKE(dev_priv))
> return true;
>
> if (IS_SKYLAKE(dev_priv) &&
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-12 13:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11 22:57 [PATCH] drm/i915/icl: enable SAGV for ICL platform Paulo Zanoni
2018-10-11 23:30 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-12 5:14 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-12 13:55 ` [PATCH] " Mun, Gwan-gyeong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.