From: Chao Fan <fanc.fnst@cn.fujitsu.com> To: Borislav Petkov <bp@alien8.de> Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, keescook@chromium.org, bhe@redhat.com, rjw@rjwysocki.net, lenb@kernel.org, ard.biesheuvel@linaro.org, indou.takao@jp.fujitsu.com, caoj.fnst@cn.fujitsu.com Subject: Re: [PATCH v8 1/3] x86/boot: Add acpitb.c to parse acpi tables Date: Fri, 12 Oct 2018 18:03:38 +0800 [thread overview] Message-ID: <20181012100338.GB1898@localhost.localdomain> (raw) In-Reply-To: <20181012094655.GB12328@zn.tnic> On Fri, Oct 12, 2018 at 11:46:55AM +0200, Borislav Petkov wrote: >On Fri, Oct 12, 2018 at 05:36:38PM +0800, Chao Fan wrote: >> Prefer to compile out entire functions, rather than portions of functions or >> portions of expressions. Rather than putting an ifdef in an expression, factor >> out part or all of the expression into a separate helper function and apply the >> conditional to that function. >> >> So I am puzzled. If my understanding is wrong, please let me know. > >If you do it the way I suggested, you simply have one ifdeffery branch >less. And ifdeffery is ugly. So less clutter. Also, this way you do >compile out entire functions too. > >HTH. Got it, thanks for your rapid reply. Thanks, Chao Fan > >-- >Regards/Gruss, > Boris. > >Good mailing practices for 400: avoid top-posting and trim the reply. > >
WARNING: multiple messages have this Message-ID (diff)
From: Chao Fan <fanc.fnst@cn.fujitsu.com> To: Borislav Petkov <bp@alien8.de> Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <linux-efi@vger.kernel.org>, <linux-acpi@vger.kernel.org>, <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>, <keescook@chromium.org>, <bhe@redhat.com>, <rjw@rjwysocki.net>, <lenb@kernel.org>, <ard.biesheuvel@linaro.org>, <indou.takao@jp.fujitsu.com>, <caoj.fnst@cn.fujitsu.com> Subject: Re: [PATCH v8 1/3] x86/boot: Add acpitb.c to parse acpi tables Date: Fri, 12 Oct 2018 18:03:38 +0800 [thread overview] Message-ID: <20181012100338.GB1898@localhost.localdomain> (raw) In-Reply-To: <20181012094655.GB12328@zn.tnic> On Fri, Oct 12, 2018 at 11:46:55AM +0200, Borislav Petkov wrote: >On Fri, Oct 12, 2018 at 05:36:38PM +0800, Chao Fan wrote: >> Prefer to compile out entire functions, rather than portions of functions or >> portions of expressions. Rather than putting an ifdef in an expression, factor >> out part or all of the expression into a separate helper function and apply the >> conditional to that function. >> >> So I am puzzled. If my understanding is wrong, please let me know. > >If you do it the way I suggested, you simply have one ifdeffery branch >less. And ifdeffery is ugly. So less clutter. Also, this way you do >compile out entire functions too. > >HTH. Got it, thanks for your rapid reply. Thanks, Chao Fan > >-- >Regards/Gruss, > Boris. > >Good mailing practices for 400: avoid top-posting and trim the reply. > >
next prev parent reply other threads:[~2018-10-12 10:03 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-10 8:41 [PATCH v8 0/3] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory Chao Fan 2018-10-10 8:41 ` Chao Fan 2018-10-10 8:41 ` [PATCH v8 1/3] x86/boot: Add acpitb.c to parse acpi tables Chao Fan 2018-10-10 8:41 ` Chao Fan 2018-10-11 10:57 ` Borislav Petkov 2018-10-12 1:56 ` Chao Fan 2018-10-12 1:56 ` Chao Fan 2018-10-12 9:36 ` Chao Fan 2018-10-12 9:36 ` Chao Fan 2018-10-12 9:46 ` Borislav Petkov 2018-10-12 10:03 ` Chao Fan [this message] 2018-10-12 10:03 ` Chao Fan 2018-10-16 2:48 ` Chao Fan 2018-10-16 2:48 ` Chao Fan 2018-10-16 12:40 ` Borislav Petkov 2018-10-17 1:10 ` Chao Fan 2018-10-17 1:10 ` Chao Fan 2018-10-15 20:26 ` Masayoshi Mizuma 2018-10-16 1:50 ` Chao Fan 2018-10-16 1:50 ` Chao Fan 2018-10-10 8:41 ` [PATCH v8 2/3] x86/boot/KASLR: Walk srat tables to filter immovable memory Chao Fan 2018-10-10 8:41 ` Chao Fan 2018-10-10 8:41 ` [PATCH v8 3/3] x86/boot/KASLR: Limit kaslr to choosing the " Chao Fan 2018-10-10 8:41 ` Chao Fan 2018-10-10 8:59 ` [PATCH v8 0/3] x86/boot/KASLR: Parse ACPI table and limit kaslr in " Borislav Petkov 2018-10-10 8:59 ` Borislav Petkov 2018-10-10 9:06 ` Baoquan He 2018-10-10 9:12 ` Chao Fan 2018-10-10 9:12 ` Chao Fan 2018-10-10 9:21 ` Baoquan He 2018-10-10 9:14 ` Thomas Gleixner 2018-10-10 9:19 ` Borislav Petkov 2018-10-10 9:30 ` Baoquan He 2018-10-10 19:44 ` Masayoshi Mizuma 2018-10-11 0:29 ` Baoquan He 2018-10-11 5:51 ` Chao Fan 2018-10-11 5:51 ` Chao Fan 2018-10-13 20:19 ` Masayoshi Mizuma 2018-10-13 20:34 ` Borislav Petkov 2018-10-13 21:45 ` Masayoshi Mizuma 2018-10-13 22:05 ` Borislav Petkov 2018-10-15 0:50 ` Masayoshi Mizuma 2018-10-16 15:13 ` Masayoshi Mizuma 2018-10-16 19:11 ` Borislav Petkov 2018-10-16 19:54 ` Masayoshi Mizuma 2018-10-16 19:59 ` Borislav Petkov 2018-10-22 15:42 ` Masayoshi Mizuma 2018-10-23 2:48 ` Chao Fan 2018-10-23 2:48 ` Chao Fan 2018-10-24 19:21 ` Masayoshi Mizuma 2018-10-25 1:22 ` Chao Fan 2018-10-25 1:22 ` Chao Fan 2018-10-25 10:33 ` Borislav Petkov 2018-10-25 13:40 ` Masayoshi Mizuma 2018-11-06 12:10 ` Borislav Petkov 2018-11-06 14:07 ` Baoquan He 2018-11-07 1:21 ` Chao Fan 2018-11-07 1:21 ` Chao Fan 2018-11-06 18:45 ` Borislav Petkov 2018-11-06 19:36 ` Masayoshi Mizuma 2018-11-06 20:45 ` Borislav Petkov 2018-11-06 22:21 ` Masayoshi Mizuma 2018-11-08 10:51 ` Borislav Petkov 2018-11-08 10:51 ` Borislav Petkov 2018-11-10 10:54 ` Borislav Petkov 2018-11-11 13:45 ` Masayoshi Mizuma 2019-02-05 15:05 ` Masayoshi Mizuma 2019-02-08 18:26 ` Borislav Petkov 2019-02-09 0:24 ` Masayoshi Mizuma 2019-02-11 1:46 ` Chao Fan 2019-02-11 1:46 ` Chao Fan 2019-02-11 20:11 ` Masayoshi Mizuma 2018-10-10 17:16 ` Borislav Petkov 2018-10-11 1:30 ` Chao Fan 2018-10-11 1:30 ` Chao Fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181012100338.GB1898@localhost.localdomain \ --to=fanc.fnst@cn.fujitsu.com \ --cc=ard.biesheuvel@linaro.org \ --cc=bhe@redhat.com \ --cc=bp@alien8.de \ --cc=caoj.fnst@cn.fujitsu.com \ --cc=hpa@zytor.com \ --cc=indou.takao@jp.fujitsu.com \ --cc=keescook@chromium.org \ --cc=lenb@kernel.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-efi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=rjw@rjwysocki.net \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.