* [PATCH v2] netlink: replace __NLA_ENSURE implementation
@ 2018-10-12 10:53 Johannes Berg
2018-10-12 18:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2018-10-12 10:53 UTC (permalink / raw)
To: linux-wireless, netdev; +Cc: John Garry, Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
We already have BUILD_BUG_ON_ZERO() which I just hadn't found
before, so we should use it here instead of open-coding another
implementation thereof.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
v2: remove all the language about -Wvla, I misunderstood John
and he was just referring to *other* VLA warnings in the
wifi stack (which we know about and are being fixed by the
crypto tree)
---
include/net/netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/netlink.h b/include/net/netlink.h
index 589683091f16..094012174b6f 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -311,7 +311,7 @@ struct nla_policy {
#define NLA_POLICY_NESTED_ARRAY(maxattr, policy) \
{ .type = NLA_NESTED_ARRAY, .validation_data = policy, .len = maxattr }
-#define __NLA_ENSURE(condition) (sizeof(char[1 - 2*!(condition)]) - 1)
+#define __NLA_ENSURE(condition) BUILD_BUG_ON_ZERO(!(condition))
#define NLA_ENSURE_INT_TYPE(tp) \
(__NLA_ENSURE(tp == NLA_S8 || tp == NLA_U8 || \
tp == NLA_S16 || tp == NLA_U16 || \
--
2.14.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] netlink: replace __NLA_ENSURE implementation
2018-10-12 10:53 [PATCH v2] netlink: replace __NLA_ENSURE implementation Johannes Berg
@ 2018-10-12 18:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-12 18:00 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, netdev, john.garry, johannes.berg
From: Johannes Berg <johannes@sipsolutions.net>
Date: Fri, 12 Oct 2018 12:53:00 +0200
> From: Johannes Berg <johannes.berg@intel.com>
>
> We already have BUILD_BUG_ON_ZERO() which I just hadn't found
> before, so we should use it here instead of open-coding another
> implementation thereof.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> v2: remove all the language about -Wvla, I misunderstood John
> and he was just referring to *other* VLA warnings in the
> wifi stack (which we know about and are being fixed by the
> crypto tree)
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-12 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-12 10:53 [PATCH v2] netlink: replace __NLA_ENSURE implementation Johannes Berg
2018-10-12 18:00 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.