From: Richard Cochran <richardcochran@gmail.com>
To: Miroslav Lichvar <mlichvar@redhat.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Jacob Keller <jacob.e.keller@intel.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] igb: shorten maximum PHC timecounter update interval
Date: Fri, 12 Oct 2018 07:05:30 -0700 [thread overview]
Message-ID: <20181012140530.6mjxkb2co3nhl5pf@localhost> (raw)
In-Reply-To: <20181012111339.1361-1-mlichvar@redhat.com>
On Fri, Oct 12, 2018 at 01:13:39PM +0200, Miroslav Lichvar wrote:
> Since commit 500462a9d ("timers: Switch to a non-cascading wheel"),
> scheduling of delayed work seems to be less accurate and a requested
> delay of 540 seconds may actually be longer than 550 seconds. Shorten
> the delay to 480 seconds to be sure the timecounter is updated in time.
Good catch. This timer wheel change will affect other, similar
drivers. Guess I'll go through and adjust their timeouts, too.
Thanks,
Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igb: shorten maximum PHC timecounter update interval
Date: Fri, 12 Oct 2018 07:05:30 -0700 [thread overview]
Message-ID: <20181012140530.6mjxkb2co3nhl5pf@localhost> (raw)
In-Reply-To: <20181012111339.1361-1-mlichvar@redhat.com>
On Fri, Oct 12, 2018 at 01:13:39PM +0200, Miroslav Lichvar wrote:
> Since commit 500462a9d ("timers: Switch to a non-cascading wheel"),
> scheduling of delayed work seems to be less accurate and a requested
> delay of 540 seconds may actually be longer than 550 seconds. Shorten
> the delay to 480 seconds to be sure the timecounter is updated in time.
Good catch. This timer wheel change will affect other, similar
drivers. Guess I'll go through and adjust their timeouts, too.
Thanks,
Richard
next prev parent reply other threads:[~2018-10-12 21:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 11:13 [PATCH] igb: shorten maximum PHC timecounter update interval Miroslav Lichvar
2018-10-12 11:13 ` [Intel-wired-lan] " Miroslav Lichvar
2018-10-12 14:05 ` Richard Cochran [this message]
2018-10-12 14:05 ` Richard Cochran
2018-10-26 12:04 ` Miroslav Lichvar
2018-10-26 12:04 ` [Intel-wired-lan] " Miroslav Lichvar
2018-10-26 15:47 ` Keller, Jacob E
2018-10-26 15:47 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-12 14:08 ` Richard Cochran
2018-10-12 14:08 ` [Intel-wired-lan] " Richard Cochran
2018-10-20 1:13 ` Brown, Aaron F
2018-10-20 1:13 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012140530.6mjxkb2co3nhl5pf@localhost \
--to=richardcochran@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.