From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
"David S . Miller" <davem@davemloft.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
Tsang-Shian Lin <thlin@realtek.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement
Date: Sat, 13 Oct 2018 11:59:48 +0000 (UTC) [thread overview]
Message-ID: <20181013115948.230CE6072E@smtp.codeaurora.org> (raw)
In-Reply-To: <20181006184246.29985-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The switch case RATR_INX_WIRELESS_MC has a missing break, this seems
> to be unintentional as the setting of variable ret gets overwritten
> when the case falls through to the following RATR_INX_WIRELESS_AC_5N
> case. Fix this by adding in the missing break.
>
> Detected by CoverityScan, CID#1167237 ("Missing break in switch")
>
> Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Dropping this patch per discussion.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10629291/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
"David S . Miller" <davem@davemloft.net>,
Larry Finger <Larry.Finger@lwfinger.net>,
Tsang-Shian Lin <thlin@realtek.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement
Date: Sat, 13 Oct 2018 11:59:48 +0000 [thread overview]
Message-ID: <20181013115948.230CE6072E@smtp.codeaurora.org> (raw)
In-Reply-To: <20181006184246.29985-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The switch case RATR_INX_WIRELESS_MC has a missing break, this seems
> to be unintentional as the setting of variable ret gets overwritten
> when the case falls through to the following RATR_INX_WIRELESS_AC_5N
> case. Fix this by adding in the missing break.
>
> Detected by CoverityScan, CID#1167237 ("Missing break in switch")
>
> Fixes: 3c05bedb5fef ("Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Dropping this patch per discussion.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10629291/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-10-13 12:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-06 18:42 [PATCH] rtlwifi: rtl8821ae: add in a missing break in switch statement Colin King
2018-10-06 18:42 ` Colin King
2018-10-06 19:30 ` Kalle Valo
2018-10-06 19:30 ` Kalle Valo
2018-10-06 20:05 ` Larry Finger
2018-10-06 20:05 ` Larry Finger
2018-10-06 20:17 ` Joe Perches
2018-10-06 20:17 ` Joe Perches
2018-10-06 22:00 ` Larry Finger
2018-10-06 22:00 ` Larry Finger
2018-10-06 22:03 ` Joe Perches
2018-10-06 22:03 ` Joe Perches
2018-10-07 0:48 ` Larry Finger
2018-10-07 0:48 ` Larry Finger
2018-10-08 8:55 ` Colin Ian King
2018-10-08 8:55 ` Colin Ian King
2018-10-13 11:59 ` Kalle Valo [this message]
2018-10-13 11:59 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181013115948.230CE6072E@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=thlin@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.