* [PATCH] libxl: CODING_STYLE: Clarify line length limit to 75
@ 2018-10-15 13:53 Ian Jackson
2018-10-15 13:54 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Ian Jackson @ 2018-10-15 13:53 UTC (permalink / raw)
To: xen-devel; +Cc: Anthony PERARD, Wei Liu, Ian Jackson
And give a reason.
The previous `limit' of 75-80 was ambiguous.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Anthony PERARD <anthony.perard@citrix.com>
---
tools/libxl/CODING_STYLE | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/libxl/CODING_STYLE b/tools/libxl/CODING_STYLE
index 32170efb9e..3d572f6925 100644
--- a/tools/libxl/CODING_STYLE
+++ b/tools/libxl/CODING_STYLE
@@ -220,12 +220,14 @@ Do not leave whitespace dangling off the ends of lines.
2. Line width
-Lines are limited to 75-80 characters.
+Lines are limited to 75 characters.
Rationale:
- Some people like to tile their 24" screens with a 6x4 matrix of 80x24
xterms and use vi in all of them. The best way to punish them is to
let them keep doing it.
+ - In an 80 column terminal, some room needs to be left for > quoting
+ characters, +/- diff characters, and so on, in emails.
- Code and especially patches is much more readable if limited to a sane
line length. Eighty is traditional.
- It is the libxenlight coding style.
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libxl: CODING_STYLE: Clarify line length limit to 75
2018-10-15 13:53 [PATCH] libxl: CODING_STYLE: Clarify line length limit to 75 Ian Jackson
@ 2018-10-15 13:54 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2018-10-15 13:54 UTC (permalink / raw)
To: Ian Jackson; +Cc: Anthony PERARD, xen-devel, Wei Liu
On Mon, Oct 15, 2018 at 02:53:27PM +0100, Ian Jackson wrote:
> And give a reason.
>
> The previous `limit' of 75-80 was ambiguous.
>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> CC: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-15 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-15 13:53 [PATCH] libxl: CODING_STYLE: Clarify line length limit to 75 Ian Jackson
2018-10-15 13:54 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.