* [PATCH] Input: atmel_mxt_ts - mark expected switch fall-through
@ 2018-10-08 17:03 Gustavo A. R. Silva
2018-10-15 18:21 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-08 17:03 UTC (permalink / raw)
To: Nick Dyer, Dmitry Torokhov; +Cc: linux-input, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/input/touchscreen/atmel_mxt_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index bbc122f..d3aacd5 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -488,7 +488,7 @@ static int mxt_lookup_bootloader_address(struct mxt_data *data, bool retry)
bootloader = appmode - 0x24;
break;
}
- /* Fall through for normal case */
+ /* Fall through - for normal case */
case 0x4c:
case 0x4d:
case 0x5a:
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: atmel_mxt_ts - mark expected switch fall-through
2018-10-08 17:03 [PATCH] Input: atmel_mxt_ts - mark expected switch fall-through Gustavo A. R. Silva
@ 2018-10-15 18:21 ` Dmitry Torokhov
2018-10-15 18:30 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2018-10-15 18:21 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Nick Dyer, linux-input, linux-kernel
On Mon, Oct 08, 2018 at 07:03:55PM +0200, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/atmel_mxt_ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
> index bbc122f..d3aacd5 100644
> --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> @@ -488,7 +488,7 @@ static int mxt_lookup_bootloader_address(struct mxt_data *data, bool retry)
> bootloader = appmode - 0x24;
> break;
> }
> - /* Fall through for normal case */
> + /* Fall through - for normal case */
> case 0x4c:
> case 0x4d:
> case 0x5a:
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: atmel_mxt_ts - mark expected switch fall-through
2018-10-15 18:21 ` Dmitry Torokhov
@ 2018-10-15 18:30 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-10-15 18:30 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: Nick Dyer, linux-input, linux-kernel
On 10/15/18 8:21 PM, Dmitry Torokhov wrote:
> On Mon, Oct 08, 2018 at 07:03:55PM +0200, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Applied, thank you.
>
Thanks, Dmitry.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-15 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-08 17:03 [PATCH] Input: atmel_mxt_ts - mark expected switch fall-through Gustavo A. R. Silva
2018-10-15 18:21 ` Dmitry Torokhov
2018-10-15 18:30 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.