* [U-Boot] [PATCH] arm: socfpga: fpga: fix type of local variable
@ 2018-10-15 18:35 Simon Goldschmidt
2018-10-16 17:46 ` Marek Vasut
0 siblings, 1 reply; 2+ messages in thread
From: Simon Goldschmidt @ 2018-10-15 18:35 UTC (permalink / raw)
To: u-boot
The 'status' variable in 'socfpga_load()' for both gen5 and arria10
is of type 'unsigned long' while it is always used as 'int' only.
Change it to 'int'.
Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
---
drivers/fpga/socfpga_arria10.c | 2 +-
drivers/fpga/socfpga_gen5.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/fpga/socfpga_arria10.c b/drivers/fpga/socfpga_arria10.c
index d6b59498e5..114dd910ab 100644
--- a/drivers/fpga/socfpga_arria10.c
+++ b/drivers/fpga/socfpga_arria10.c
@@ -453,7 +453,7 @@ int fpgamgr_program_finish(void)
*/
int socfpga_load(Altera_desc *desc, const void *rbf_data, size_t rbf_size)
{
- unsigned long status;
+ int status;
/* disable all signals from hps peripheral controller to fpga */
writel(0, &system_manager_base->fpgaintf_en_global);
diff --git a/drivers/fpga/socfpga_gen5.c b/drivers/fpga/socfpga_gen5.c
index 184de743fd..6d16e0b37f 100644
--- a/drivers/fpga/socfpga_gen5.c
+++ b/drivers/fpga/socfpga_gen5.c
@@ -204,7 +204,7 @@ static int fpgamgr_program_poll_usermode(void)
*/
int socfpga_load(Altera_desc *desc, const void *rbf_data, size_t rbf_size)
{
- unsigned long status;
+ int status;
if ((uint32_t)rbf_data & 0x3) {
puts("FPGA: Unaligned data, realign to 32bit boundary.\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] arm: socfpga: fpga: fix type of local variable
2018-10-15 18:35 [U-Boot] [PATCH] arm: socfpga: fpga: fix type of local variable Simon Goldschmidt
@ 2018-10-16 17:46 ` Marek Vasut
0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2018-10-16 17:46 UTC (permalink / raw)
To: u-boot
On 10/15/2018 08:35 PM, Simon Goldschmidt wrote:
> The 'status' variable in 'socfpga_load()' for both gen5 and arria10
> is of type 'unsigned long' while it is always used as 'int' only.
> Change it to 'int'.
>
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> ---
Applied, thanks
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-16 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-15 18:35 [U-Boot] [PATCH] arm: socfpga: fpga: fix type of local variable Simon Goldschmidt
2018-10-16 17:46 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.