All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds
@ 2018-10-16  8:59 Michal Wajdeczko
  2018-10-16  8:59 ` [PATCH 2/2] HAX enable GuC for CI Michal Wajdeczko
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Michal Wajdeczko @ 2018-10-16  8:59 UTC (permalink / raw)
  To: intel-gfx

In commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading") we
stopped converting errors detected during firmware transfer into
-EAGAIN and this indirectly killed our workarounds for Gen9 GuC.
Reactivate those workarounds by looking for actual -ETIMEDOUT error.

Testcase: igt@drv_selftest@live_hangcheck
Reported-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
References: commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading")

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_uc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
index b1b3e81..b34c318 100644
--- a/drivers/gpu/drm/i915/intel_uc.c
+++ b/drivers/gpu/drm/i915/intel_uc.c
@@ -376,7 +376,7 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
 
 		intel_guc_init_params(guc);
 		ret = intel_guc_fw_upload(guc);
-		if (ret == 0 || ret != -EAGAIN)
+		if (ret == 0 || ret != -ETIMEDOUT)
 			break;
 
 		DRM_DEBUG_DRIVER("GuC fw load failed: %d; will reset and "
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH 2/2] HAX enable GuC for CI
  2018-10-16  8:59 [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Michal Wajdeczko
@ 2018-10-16  8:59 ` Michal Wajdeczko
  2018-10-16  9:41 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Michal Wajdeczko @ 2018-10-16  8:59 UTC (permalink / raw)
  To: intel-gfx

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 7e56c51..c681537 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -45,7 +45,7 @@
 	param(int, disable_power_well, -1) \
 	param(int, enable_ips, 1) \
 	param(int, invert_brightness, 0) \
-	param(int, enable_guc, 0) \
+	param(int, enable_guc, -1) \
 	param(int, guc_log_level, -1) \
 	param(char *, guc_firmware_path, NULL) \
 	param(char *, huc_firmware_path, NULL) \
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds
  2018-10-16  8:59 [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Michal Wajdeczko
  2018-10-16  8:59 ` [PATCH 2/2] HAX enable GuC for CI Michal Wajdeczko
@ 2018-10-16  9:41 ` Patchwork
  2018-10-16 10:05 ` ✗ Fi.CI.BAT: failure " Patchwork
  2018-10-16 23:03 ` [PATCH 1/2] " Daniele Ceraolo Spurio
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-10-16  9:41 UTC (permalink / raw)
  To: Michal Wajdeczko; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds
URL   : https://patchwork.freedesktop.org/series/51053/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bd0a30d28b4b drm/i915/guc: Fix Gen9 GuC loading workarounds
a34c27b8f8d2 HAX enable GuC for CI
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds
  2018-10-16  8:59 [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Michal Wajdeczko
  2018-10-16  8:59 ` [PATCH 2/2] HAX enable GuC for CI Michal Wajdeczko
  2018-10-16  9:41 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Patchwork
@ 2018-10-16 10:05 ` Patchwork
  2018-10-16 23:03 ` [PATCH 1/2] " Daniele Ceraolo Spurio
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-10-16 10:05 UTC (permalink / raw)
  To: Michal Wajdeczko; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds
URL   : https://patchwork.freedesktop.org/series/51053/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4984 -> Patchwork_10468 =

== Summary - FAILURE ==

  Serious unknown changes coming with Patchwork_10468 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_10468, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/51053/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_10468:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_gem:
      fi-whl-u:           PASS -> INCOMPLETE
      fi-skl-6600u:       PASS -> INCOMPLETE
      fi-kbl-7560u:       PASS -> INCOMPLETE
      fi-cfl-s3:          PASS -> INCOMPLETE
      fi-skl-iommu:       PASS -> INCOMPLETE
      fi-skl-6700k2:      PASS -> INCOMPLETE
      fi-skl-6700hq:      PASS -> INCOMPLETE
      fi-cfl-8109u:       PASS -> INCOMPLETE
      fi-kbl-7500u:       PASS -> INCOMPLETE
      fi-cfl-8700k:       PASS -> INCOMPLETE
      fi-skl-6770hq:      PASS -> INCOMPLETE
      fi-skl-6260u:       PASS -> INCOMPLETE
      fi-kbl-7567u:       PASS -> INCOMPLETE
      fi-kbl-x1275:       PASS -> INCOMPLETE
      fi-kbl-8809g:       PASS -> INCOMPLETE
      fi-kbl-r:           PASS -> INCOMPLETE

    
== Known issues ==

  Here are the changes found in Patchwork_10468 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@amdgpu/amd_cs_nop@fork-gfx0:
      fi-kbl-8809g:       PASS -> DMESG-WARN (fdo#107762)

    igt@drv_selftest@live_gem:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)
      fi-skl-gvtdvm:      PASS -> INCOMPLETE (fdo#105600)
      fi-bxt-j4205:       PASS -> INCOMPLETE (fdo#103927)

    igt@gem_exec_suspend@basic-s4-devices:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    
    ==== Possible fixes ====

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105600 https://bugs.freedesktop.org/show_bug.cgi?id=105600
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#107762 https://bugs.freedesktop.org/show_bug.cgi?id=107762


== Participating hosts (53 -> 42) ==

  Missing    (11): fi-ilk-m540 fi-hsw-4200u fi-bdw-gvtdvm fi-glk-dsi fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-glk-j4005 fi-pnv-d510 fi-ivb-3520m fi-byt-n2820 


== Build changes ==

    * Linux: CI_DRM_4984 -> Patchwork_10468

  CI_DRM_4984: 90b59df999a13a6405f8d7ece08a69120a9b361a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4678: 9310a1265ceabeec736bdf0a76e1e0357c76c0b1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_10468: a34c27b8f8d21981c9032788e832bb16f830eed6 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

a34c27b8f8d2 HAX enable GuC for CI
bd0a30d28b4b drm/i915/guc: Fix Gen9 GuC loading workarounds

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10468/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds
  2018-10-16  8:59 [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Michal Wajdeczko
                   ` (2 preceding siblings ...)
  2018-10-16 10:05 ` ✗ Fi.CI.BAT: failure " Patchwork
@ 2018-10-16 23:03 ` Daniele Ceraolo Spurio
  2018-10-17  8:09   ` Chris Wilson
  3 siblings, 1 reply; 6+ messages in thread
From: Daniele Ceraolo Spurio @ 2018-10-16 23:03 UTC (permalink / raw)
  To: Michal Wajdeczko, intel-gfx



On 16/10/18 01:59, Michal Wajdeczko wrote:
> In commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading") we
> stopped converting errors detected during firmware transfer into
> -EAGAIN and this indirectly killed our workarounds for Gen9 GuC.
> Reactivate those workarounds by looking for actual -ETIMEDOUT error.
> 
> Testcase: igt@drv_selftest@live_hangcheck
> Reported-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> References: commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading")

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/intel_uc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index b1b3e81..b34c318 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -376,7 +376,7 @@ int intel_uc_init_hw(struct drm_i915_private *i915)
>   
>   		intel_guc_init_params(guc);
>   		ret = intel_guc_fw_upload(guc);
> -		if (ret == 0 || ret != -EAGAIN)
> +		if (ret == 0 || ret != -ETIMEDOUT)
>   			break;
>   
>   		DRM_DEBUG_DRIVER("GuC fw load failed: %d; will reset and "
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds
  2018-10-16 23:03 ` [PATCH 1/2] " Daniele Ceraolo Spurio
@ 2018-10-17  8:09   ` Chris Wilson
  0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-10-17  8:09 UTC (permalink / raw)
  To: Daniele Ceraolo Spurio, Michal Wajdeczko, intel-gfx

Quoting Daniele Ceraolo Spurio (2018-10-17 00:03:38)
> 
> 
> On 16/10/18 01:59, Michal Wajdeczko wrote:
> > In commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading") we
> > stopped converting errors detected during firmware transfer into
> > -EAGAIN and this indirectly killed our workarounds for Gen9 GuC.
> > Reactivate those workarounds by looking for actual -ETIMEDOUT error.
> > 
> > Testcase: igt@drv_selftest@live_hangcheck
> > Reported-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > References: commit 4502e9ec820d ("drm/i915/uc: Unify firmware loading")
> 
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Thanks for the fix and review, pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-17  8:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16  8:59 [PATCH 1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Michal Wajdeczko
2018-10-16  8:59 ` [PATCH 2/2] HAX enable GuC for CI Michal Wajdeczko
2018-10-16  9:41 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/guc: Fix Gen9 GuC loading workarounds Patchwork
2018-10-16 10:05 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-10-16 23:03 ` [PATCH 1/2] " Daniele Ceraolo Spurio
2018-10-17  8:09   ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.