* [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
@ 2018-10-16 16:00 Imre Deak
2018-10-16 17:16 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Imre Deak @ 2018-10-16 16:00 UTC (permalink / raw)
To: intel-gfx
Cc: Ville Syrjälä, Mika Westerberg, Hans de Goede, ronald, stable
If BIOS configured a Y tiled FB we failed to set up the backing object
tiling accordingly, leading to a lack of GT fence installed and a
garbled console.
The problem was bisected to
commit 011f22eb545a ("drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers v2")
but it just revealed a pre-existing issue.
Kudos to Ville who suspected a missing fence looking at the corruption
on the screen.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: ronald@innovation.ch
Cc: <stable@vger.kernel.org>
Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reported-by: ronald@innovation.ch
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108264
Fixes: bc8d7dffacb1 ("drm/i915/skl: Provide a Skylake version of get_plane_config()")
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a2e729fa8d64..3d34b98c4634 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -2674,6 +2674,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
if (size_aligned * 2 > dev_priv->stolen_usable_size)
return false;
+ switch (fb->modifier) {
+ case DRM_FORMAT_MOD_LINEAR:
+ case I915_FORMAT_MOD_X_TILED:
+ case I915_FORMAT_MOD_Y_TILED:
+ break;
+ default:
+ DRM_DEBUG_DRIVER("Unsupported modifier for initial FB: 0x%llx\n",
+ fb->modifier);
+ return false;
+ }
+
mutex_lock(&dev->struct_mutex);
obj = i915_gem_object_create_stolen_for_preallocated(dev_priv,
base_aligned,
@@ -2683,8 +2694,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
if (!obj)
return false;
- if (plane_config->tiling == I915_TILING_X)
- obj->tiling_and_stride = fb->pitches[0] | I915_TILING_X;
+ switch (plane_config->tiling) {
+ case I915_TILING_NONE:
+ break;
+ case I915_TILING_X:
+ case I915_TILING_Y:
+ obj->tiling_and_stride = fb->pitches[0] | plane_config->tiling;
+ break;
+ default:
+ MISSING_CASE(plane_config->tiling);
+ return false;
+ }
mode_cmd.pixel_format = fb->format->format;
mode_cmd.width = fb->width;
@@ -8827,6 +8847,7 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,
fb->modifier = I915_FORMAT_MOD_X_TILED;
break;
case PLANE_CTL_TILED_Y:
+ plane_config->tiling = I915_TILING_Y;
if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
else
--
2.13.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
2018-10-16 16:00 [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers Imre Deak
@ 2018-10-16 17:16 ` Patchwork
2018-10-16 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-10-16 17:16 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
URL : https://patchwork.freedesktop.org/series/51075/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
030f7e7d682d drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
commit 011f22eb545a ("drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers v2")
total: 0 errors, 1 warnings, 0 checks, 43 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
2018-10-16 16:00 [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers Imre Deak
2018-10-16 17:16 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-10-16 17:34 ` Patchwork
2018-10-16 17:56 ` Ville Syrjälä
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-10-16 17:34 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
URL : https://patchwork.freedesktop.org/series/51075/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4990 -> Patchwork_10477 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/51075/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10477 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-no-display:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#105719)
igt@gem_exec_suspend@basic-s3:
fi-kbl-soraka: NOTRUN -> INCOMPLETE (fdo#107859, fdo#107774, fdo#107556)
igt@pm_rpm@module-reload:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#107726, fdo#106097)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-icl-u2: INCOMPLETE (fdo#108315) -> PASS
igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
fi-glk-j4005: FAIL (fdo#106765) -> PASS
igt@kms_flip@basic-flip-vs-dpms:
fi-hsw-4770r: DMESG-WARN (fdo#105602) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: FAIL (fdo#100368) -> PASS
igt@kms_flip@basic-plain-flip:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-icl-u2: FAIL (fdo#103167) -> PASS
fi-byt-clapper: FAIL (fdo#103167) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106765 https://bugs.freedesktop.org/show_bug.cgi?id=106765
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107726 https://bugs.freedesktop.org/show_bug.cgi?id=107726
fdo#107774 https://bugs.freedesktop.org/show_bug.cgi?id=107774
fdo#107859 https://bugs.freedesktop.org/show_bug.cgi?id=107859
fdo#108315 https://bugs.freedesktop.org/show_bug.cgi?id=108315
== Participating hosts (46 -> 42) ==
Additional (2): fi-kbl-soraka fi-icl-u
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-pnv-d510
== Build changes ==
* Linux: CI_DRM_4990 -> Patchwork_10477
CI_DRM_4990: 0bd34d92e9a27784cb988a300619f497ca0e99ec @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4681: 959d6f95cb1344e0c0dace5b236e17755826fac1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10477: 030f7e7d682d65b11f75afd2a5e128e2b839130c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
030f7e7d682d drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10477/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
2018-10-16 16:00 [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers Imre Deak
@ 2018-10-16 17:56 ` Ville Syrjälä
2018-10-16 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Ville Syrjälä @ 2018-10-16 17:56 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx, Mika Westerberg, Hans de Goede, ronald, stable
On Tue, Oct 16, 2018 at 07:00:11PM +0300, Imre Deak wrote:
> If BIOS configured a Y tiled FB we failed to set up the backing object
> tiling accordingly, leading to a lack of GT fence installed and a
> garbled console.
>
> The problem was bisected to
> commit 011f22eb545a ("drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers v2")
> but it just revealed a pre-existing issue.
>
> Kudos to Ville who suspected a missing fence looking at the corruption
> on the screen.
>
> Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: ronald@innovation.ch
> Cc: <stable@vger.kernel.org>
> Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reported-by: ronald@innovation.ch
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108264
> Fixes: bc8d7dffacb1 ("drm/i915/skl: Provide a Skylake version of get_plane_config()")
> Signed-off-by: Imre Deak <imre.deak@intel.com>
lgtm
Reviewed-by: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a2e729fa8d64..3d34b98c4634 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2674,6 +2674,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
> if (size_aligned * 2 > dev_priv->stolen_usable_size)
> return false;
>
> + switch (fb->modifier) {
> + case DRM_FORMAT_MOD_LINEAR:
> + case I915_FORMAT_MOD_X_TILED:
> + case I915_FORMAT_MOD_Y_TILED:
> + break;
> + default:
> + DRM_DEBUG_DRIVER("Unsupported modifier for initial FB: 0x%llx\n",
> + fb->modifier);
> + return false;
> + }
> +
> mutex_lock(&dev->struct_mutex);
> obj = i915_gem_object_create_stolen_for_preallocated(dev_priv,
> base_aligned,
> @@ -2683,8 +2694,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
> if (!obj)
> return false;
>
> - if (plane_config->tiling == I915_TILING_X)
> - obj->tiling_and_stride = fb->pitches[0] | I915_TILING_X;
> + switch (plane_config->tiling) {
> + case I915_TILING_NONE:
> + break;
> + case I915_TILING_X:
> + case I915_TILING_Y:
> + obj->tiling_and_stride = fb->pitches[0] | plane_config->tiling;
> + break;
> + default:
> + MISSING_CASE(plane_config->tiling);
> + return false;
> + }
>
> mode_cmd.pixel_format = fb->format->format;
> mode_cmd.width = fb->width;
> @@ -8827,6 +8847,7 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,
> fb->modifier = I915_FORMAT_MOD_X_TILED;
> break;
> case PLANE_CTL_TILED_Y:
> + plane_config->tiling = I915_TILING_Y;
> if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
> fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
> else
> --
> 2.13.2
--
Ville Syrj�l�
Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
@ 2018-10-16 17:56 ` Ville Syrjälä
0 siblings, 0 replies; 9+ messages in thread
From: Ville Syrjälä @ 2018-10-16 17:56 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx, Mika Westerberg, Hans de Goede, ronald, stable
On Tue, Oct 16, 2018 at 07:00:11PM +0300, Imre Deak wrote:
> If BIOS configured a Y tiled FB we failed to set up the backing object
> tiling accordingly, leading to a lack of GT fence installed and a
> garbled console.
>
> The problem was bisected to
> commit 011f22eb545a ("drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers v2")
> but it just revealed a pre-existing issue.
>
> Kudos to Ville who suspected a missing fence looking at the corruption
> on the screen.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: ronald@innovation.ch
> Cc: <stable@vger.kernel.org>
> Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reported-by: ronald@innovation.ch
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108264
> Fixes: bc8d7dffacb1 ("drm/i915/skl: Provide a Skylake version of get_plane_config()")
> Signed-off-by: Imre Deak <imre.deak@intel.com>
lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a2e729fa8d64..3d34b98c4634 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2674,6 +2674,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
> if (size_aligned * 2 > dev_priv->stolen_usable_size)
> return false;
>
> + switch (fb->modifier) {
> + case DRM_FORMAT_MOD_LINEAR:
> + case I915_FORMAT_MOD_X_TILED:
> + case I915_FORMAT_MOD_Y_TILED:
> + break;
> + default:
> + DRM_DEBUG_DRIVER("Unsupported modifier for initial FB: 0x%llx\n",
> + fb->modifier);
> + return false;
> + }
> +
> mutex_lock(&dev->struct_mutex);
> obj = i915_gem_object_create_stolen_for_preallocated(dev_priv,
> base_aligned,
> @@ -2683,8 +2694,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
> if (!obj)
> return false;
>
> - if (plane_config->tiling == I915_TILING_X)
> - obj->tiling_and_stride = fb->pitches[0] | I915_TILING_X;
> + switch (plane_config->tiling) {
> + case I915_TILING_NONE:
> + break;
> + case I915_TILING_X:
> + case I915_TILING_Y:
> + obj->tiling_and_stride = fb->pitches[0] | plane_config->tiling;
> + break;
> + default:
> + MISSING_CASE(plane_config->tiling);
> + return false;
> + }
>
> mode_cmd.pixel_format = fb->format->format;
> mode_cmd.width = fb->width;
> @@ -8827,6 +8847,7 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,
> fb->modifier = I915_FORMAT_MOD_X_TILED;
> break;
> case PLANE_CTL_TILED_Y:
> + plane_config->tiling = I915_TILING_Y;
> if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
> fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
> else
> --
> 2.13.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
2018-10-16 16:00 [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers Imre Deak
` (2 preceding siblings ...)
2018-10-16 17:56 ` Ville Syrjälä
@ 2018-10-16 21:26 ` Patchwork
2018-10-17 10:50 ` Imre Deak
2018-10-17 9:02 ` Life is hard, and then you die
4 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2018-10-16 21:26 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
URL : https://patchwork.freedesktop.org/series/51075/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4990_full -> Patchwork_10477_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10477_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_await@wide-contexts:
shard-skl: PASS -> FAIL (fdo#106680)
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-skl: NOTRUN -> TIMEOUT (fdo#108039)
igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
shard-skl: NOTRUN -> FAIL (fdo#108228)
igt@kms_busy@extended-modeset-hang-newfb-render-a:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +1
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-glk: NOTRUN -> DMESG-WARN (fdo#107956)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
shard-hsw: NOTRUN -> DMESG-WARN (fdo#107956) +2
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-skl: NOTRUN -> FAIL (fdo#103191, fdo#103232)
igt@kms_cursor_crc@cursor-256x85-sliding:
shard-apl: PASS -> FAIL (fdo#103232)
igt@kms_cursor_crc@cursor-64x64-suspend:
shard-skl: PASS -> INCOMPLETE (fdo#104108)
igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
shard-skl: NOTRUN -> FAIL (fdo#103184) +2
igt@kms_flip@blocking-absolute-wf_vblank:
shard-kbl: PASS -> DMESG-WARN (fdo#105345)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-skl: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
shard-skl: NOTRUN -> FAIL (fdo#105682) +1
igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
shard-skl: NOTRUN -> FAIL (fdo#103167) +4
igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
shard-glk: NOTRUN -> FAIL (fdo#108145) +1
igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
shard-skl: NOTRUN -> FAIL (fdo#108145) +3
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@pm_rpm@gem-mmap-cpu:
shard-skl: PASS -> INCOMPLETE (fdo#107807)
==== Possible fixes ====
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
shard-glk: FAIL (fdo#103167) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108228 https://bugs.freedesktop.org/show_bug.cgi?id=108228
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4990 -> Patchwork_10477
CI_DRM_4990: 0bd34d92e9a27784cb988a300619f497ca0e99ec @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4681: 959d6f95cb1344e0c0dace5b236e17755826fac1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10477: 030f7e7d682d65b11f75afd2a5e128e2b839130c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10477/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
2018-10-16 16:00 [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers Imre Deak
@ 2018-10-17 9:02 ` Life is hard, and then you die
2018-10-16 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Life is hard, and then you die @ 2018-10-17 9:02 UTC (permalink / raw)
To: Imre Deak
Cc: intel-gfx, Ville Syrjälä,
Mika Westerberg, Hans de Goede, stable
On Tue, Oct 16, 2018 at 07:00:11PM +0300, Imre Deak wrote:
> If BIOS configured a Y tiled FB we failed to set up the backing object
> tiling accordingly, leading to a lack of GT fence installed and a
> garbled console.
>
> The problem was bisected to
> commit 011f22eb545a ("drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers v2")
> but it just revealed a pre-existing issue.
>
> Kudos to Ville who suspected a missing fence looking at the corruption
> on the screen.
>
> Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: ronald@innovation.ch
> Cc: <stable@vger.kernel.org>
> Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reported-by: ronald@innovation.ch
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108264
> Fixes: bc8d7dffacb1 ("drm/i915/skl: Provide a Skylake version of get_plane_config()")
> Signed-off-by: Imre Deak <imre.deak@intel.com>
I can confirm it fixes the issue for MBP13,3 (Skylake) on kernels
4.18.14, 4.19.0-rc8, and drm-tip.
Cheers,
Ronald
> ---
> drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a2e729fa8d64..3d34b98c4634 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2674,6 +2674,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
> if (size_aligned * 2 > dev_priv->stolen_usable_size)
> return false;
>
> + switch (fb->modifier) {
> + case DRM_FORMAT_MOD_LINEAR:
> + case I915_FORMAT_MOD_X_TILED:
> + case I915_FORMAT_MOD_Y_TILED:
> + break;
> + default:
> + DRM_DEBUG_DRIVER("Unsupported modifier for initial FB: 0x%llx\n",
> + fb->modifier);
> + return false;
> + }
> +
> mutex_lock(&dev->struct_mutex);
> obj = i915_gem_object_create_stolen_for_preallocated(dev_priv,
> base_aligned,
> @@ -2683,8 +2694,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
> if (!obj)
> return false;
>
> - if (plane_config->tiling == I915_TILING_X)
> - obj->tiling_and_stride = fb->pitches[0] | I915_TILING_X;
> + switch (plane_config->tiling) {
> + case I915_TILING_NONE:
> + break;
> + case I915_TILING_X:
> + case I915_TILING_Y:
> + obj->tiling_and_stride = fb->pitches[0] | plane_config->tiling;
> + break;
> + default:
> + MISSING_CASE(plane_config->tiling);
> + return false;
> + }
>
> mode_cmd.pixel_format = fb->format->format;
> mode_cmd.width = fb->width;
> @@ -8827,6 +8847,7 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,
> fb->modifier = I915_FORMAT_MOD_X_TILED;
> break;
> case PLANE_CTL_TILED_Y:
> + plane_config->tiling = I915_TILING_Y;
> if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
> fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
> else
> --
> 2.13.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
@ 2018-10-17 9:02 ` Life is hard, and then you die
0 siblings, 0 replies; 9+ messages in thread
From: Life is hard, and then you die @ 2018-10-17 9:02 UTC (permalink / raw)
To: Imre Deak
Cc: intel-gfx, Ville Syrjälä,
Mika Westerberg, Hans de Goede, stable
On Tue, Oct 16, 2018 at 07:00:11PM +0300, Imre Deak wrote:
> If BIOS configured a Y tiled FB we failed to set up the backing object
> tiling accordingly, leading to a lack of GT fence installed and a
> garbled console.
>
> The problem was bisected to
> commit 011f22eb545a ("drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers v2")
> but it just revealed a pre-existing issue.
>
> Kudos to Ville who suspected a missing fence looking at the corruption
> on the screen.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: ronald@innovation.ch
> Cc: <stable@vger.kernel.org>
> Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Reported-by: ronald@innovation.ch
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108264
> Fixes: bc8d7dffacb1 ("drm/i915/skl: Provide a Skylake version of get_plane_config()")
> Signed-off-by: Imre Deak <imre.deak@intel.com>
I can confirm it fixes the issue for MBP13,3 (Skylake) on kernels
4.18.14, 4.19.0-rc8, and drm-tip.
Cheers,
Ronald
> ---
> drivers/gpu/drm/i915/intel_display.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a2e729fa8d64..3d34b98c4634 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2674,6 +2674,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
> if (size_aligned * 2 > dev_priv->stolen_usable_size)
> return false;
>
> + switch (fb->modifier) {
> + case DRM_FORMAT_MOD_LINEAR:
> + case I915_FORMAT_MOD_X_TILED:
> + case I915_FORMAT_MOD_Y_TILED:
> + break;
> + default:
> + DRM_DEBUG_DRIVER("Unsupported modifier for initial FB: 0x%llx\n",
> + fb->modifier);
> + return false;
> + }
> +
> mutex_lock(&dev->struct_mutex);
> obj = i915_gem_object_create_stolen_for_preallocated(dev_priv,
> base_aligned,
> @@ -2683,8 +2694,17 @@ intel_alloc_initial_plane_obj(struct intel_crtc *crtc,
> if (!obj)
> return false;
>
> - if (plane_config->tiling == I915_TILING_X)
> - obj->tiling_and_stride = fb->pitches[0] | I915_TILING_X;
> + switch (plane_config->tiling) {
> + case I915_TILING_NONE:
> + break;
> + case I915_TILING_X:
> + case I915_TILING_Y:
> + obj->tiling_and_stride = fb->pitches[0] | plane_config->tiling;
> + break;
> + default:
> + MISSING_CASE(plane_config->tiling);
> + return false;
> + }
>
> mode_cmd.pixel_format = fb->format->format;
> mode_cmd.width = fb->width;
> @@ -8827,6 +8847,7 @@ skylake_get_initial_plane_config(struct intel_crtc *crtc,
> fb->modifier = I915_FORMAT_MOD_X_TILED;
> break;
> case PLANE_CTL_TILED_Y:
> + plane_config->tiling = I915_TILING_Y;
> if (val & PLANE_CTL_RENDER_DECOMPRESSION_ENABLE)
> fb->modifier = I915_FORMAT_MOD_Y_TILED_CCS;
> else
> --
> 2.13.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ✓ Fi.CI.IGT: success for drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
2018-10-16 21:26 ` ✓ Fi.CI.IGT: success for " Patchwork
@ 2018-10-17 10:50 ` Imre Deak
0 siblings, 0 replies; 9+ messages in thread
From: Imre Deak @ 2018-10-17 10:50 UTC (permalink / raw)
To: intel-gfx, Mika Westerberg, ronald, Ville Syrjälä; +Cc: Hans de Goede
On Tue, Oct 16, 2018 at 09:26:05PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/gen9+: Fix initial readout for Y tiled framebuffers
> URL : https://patchwork.freedesktop.org/series/51075/
> State : success
Pushed to -dinq, thanks for the report, review and testing.
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4990_full -> Patchwork_10477_full =
>
> == Summary - SUCCESS ==
>
> No regressions found.
>
>
>
> == Known issues ==
>
> Here are the changes found in Patchwork_10477_full that come from known issues:
>
> === IGT changes ===
>
> ==== Issues hit ====
>
> igt@gem_exec_await@wide-contexts:
> shard-skl: PASS -> FAIL (fdo#106680)
>
> igt@gem_ppgtt@blt-vs-render-ctxn:
> shard-skl: NOTRUN -> TIMEOUT (fdo#108039)
>
> igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
> shard-skl: NOTRUN -> FAIL (fdo#108228)
>
> igt@kms_busy@extended-modeset-hang-newfb-render-a:
> shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +1
>
> igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
> shard-glk: NOTRUN -> DMESG-WARN (fdo#107956)
>
> igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
> shard-hsw: NOTRUN -> DMESG-WARN (fdo#107956) +2
>
> igt@kms_cursor_crc@cursor-256x256-suspend:
> shard-skl: NOTRUN -> FAIL (fdo#103191, fdo#103232)
>
> igt@kms_cursor_crc@cursor-256x85-sliding:
> shard-apl: PASS -> FAIL (fdo#103232)
>
> igt@kms_cursor_crc@cursor-64x64-suspend:
> shard-skl: PASS -> INCOMPLETE (fdo#104108)
>
> igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
> shard-skl: NOTRUN -> FAIL (fdo#103184) +2
>
> igt@kms_flip@blocking-absolute-wf_vblank:
> shard-kbl: PASS -> DMESG-WARN (fdo#105345)
>
> igt@kms_flip@flip-vs-expired-vblank-interruptible:
> shard-skl: PASS -> FAIL (fdo#105363)
>
> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
> shard-skl: NOTRUN -> FAIL (fdo#105682) +1
>
> igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-move:
> shard-skl: NOTRUN -> FAIL (fdo#103167) +4
>
> igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
> shard-glk: NOTRUN -> FAIL (fdo#108145) +1
>
> igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
> shard-skl: NOTRUN -> FAIL (fdo#108145) +3
>
> igt@kms_setmode@basic:
> shard-apl: PASS -> FAIL (fdo#99912)
>
> igt@pm_rpm@gem-mmap-cpu:
> shard-skl: PASS -> INCOMPLETE (fdo#107807)
>
>
> ==== Possible fixes ====
>
> igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
> shard-glk: FAIL (fdo#103167) -> PASS
>
>
> fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
> fdo#103184 https://bugs.freedesktop.org/show_bug.cgi?id=103184
> fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
> fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
> fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
> fdo#105345 https://bugs.freedesktop.org/show_bug.cgi?id=105345
> fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
> fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
> fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
> fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
> fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
> fdo#108039 https://bugs.freedesktop.org/show_bug.cgi?id=108039
> fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
> fdo#108228 https://bugs.freedesktop.org/show_bug.cgi?id=108228
> fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
>
>
> == Participating hosts (6 -> 6) ==
>
> No changes in participating hosts
>
>
> == Build changes ==
>
> * Linux: CI_DRM_4990 -> Patchwork_10477
>
> CI_DRM_4990: 0bd34d92e9a27784cb988a300619f497ca0e99ec @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4681: 959d6f95cb1344e0c0dace5b236e17755826fac1 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_10477: 030f7e7d682d65b11f75afd2a5e128e2b839130c @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10477/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-10-17 17:04 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 16:00 [PATCH] drm/i915/gen9+: Fix initial readout for Y tiled framebuffers Imre Deak
2018-10-16 17:16 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-10-16 17:34 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-16 17:56 ` [PATCH] " Ville Syrjälä
2018-10-16 17:56 ` Ville Syrjälä
2018-10-16 21:26 ` ✓ Fi.CI.IGT: success for " Patchwork
2018-10-17 10:50 ` Imre Deak
2018-10-17 9:02 ` [PATCH] " Life is hard, and then you die
2018-10-17 9:02 ` Life is hard, and then you die
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.